Re: [PATCH v1 3/3] mmc: mediatek: add support for SDIO eint irq

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3750 bytes --]

Hi Axe,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on ulf-hansson-mmc-mirror/next linus/master v5.16-rc7 next-20211224]
[cannot apply to mbgg-mediatek/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Axe-Yang/mmc-mediatek-add-support-for-SDIO-async-int/20211227-163820
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: nds32-randconfig-r034-20211229 (https://download.01.org/0day-ci/archive/20211229/202112291914.fj5SEFOD-lkp(a)intel.com/config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c59ac2b1b9742009cad208fe09db8d6cdfba28da
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Axe-Yang/mmc-mediatek-add-support-for-SDIO-async-int/20211227-163820
        git checkout c59ac2b1b9742009cad208fe09db8d6cdfba28da
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash drivers/mmc/host/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/mmc/host/mtk-sd.c: In function 'msdc_request_dat1_eint_irq':
>> drivers/mmc/host/mtk-sd.c:2490:16: error: implicit declaration of function 'devm_gpiod_get_index' [-Werror=implicit-function-declaration]
    2490 |         desc = devm_gpiod_get_index(host->dev, "eint", 0, GPIOD_IN);
         |                ^~~~~~~~~~~~~~~~~~~~
>> drivers/mmc/host/mtk-sd.c:2490:59: error: 'GPIOD_IN' undeclared (first use in this function); did you mean 'GPIOF_IN'?
    2490 |         desc = devm_gpiod_get_index(host->dev, "eint", 0, GPIOD_IN);
         |                                                           ^~~~~~~~
         |                                                           GPIOF_IN
   drivers/mmc/host/mtk-sd.c:2490:59: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/mmc/host/mtk-sd.c:2494:15: error: implicit declaration of function 'gpiod_to_irq'; did you mean 'gpio_to_irq'? [-Werror=implicit-function-declaration]
    2494 |         irq = gpiod_to_irq(desc);
         |               ^~~~~~~~~~~~
         |               gpio_to_irq
   cc1: some warnings being treated as errors


vim +/devm_gpiod_get_index +2490 drivers/mmc/host/mtk-sd.c

  2483	
  2484	static int msdc_request_dat1_eint_irq(struct msdc_host *host)
  2485	{
  2486		struct gpio_desc *desc;
  2487		int ret = 0;
  2488		int irq;
  2489	
> 2490		desc = devm_gpiod_get_index(host->dev, "eint", 0, GPIOD_IN);
  2491		if (IS_ERR(desc))
  2492			return PTR_ERR(desc);
  2493	
> 2494		irq = gpiod_to_irq(desc);
  2495		if (irq >= 0) {
  2496			irq_set_status_flags(irq, IRQ_NOAUTOEN);
  2497			ret = devm_request_threaded_irq(host->dev, irq, NULL, msdc_sdio_eint_irq,
  2498							IRQF_TRIGGER_LOW | IRQF_ONESHOT,
  2499							"sdio-eint", host);
  2500		} else {
  2501			ret = irq;
  2502		}
  2503	
  2504		host->eint_irq = irq;
  2505		return ret;
  2506	}
  2507	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org