From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27747C433F5 for ; Fri, 31 Dec 2021 16:14:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5AAD6830CA; Fri, 31 Dec 2021 17:14:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="AMWiVyqh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 95F7E8307D; Fri, 31 Dec 2021 17:14:02 +0100 (CET) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3236682FB5 for ; Fri, 31 Dec 2021 17:13:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francis.laniel@amarulasolutions.com Received: by mail-wr1-x430.google.com with SMTP id t26so56655545wrb.4 for ; Fri, 31 Dec 2021 08:13:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kb2tikLI+KQMoUxEbmbI74UVqkkRxE1BP6m8PAtlOCY=; b=AMWiVyqh1WUj0rjA50h/HCS1b94Gc2I/8XZBv26fyq8c/5WepwV/pHHXDaB23eXbqJ SPOwUOAOgqgQBdqV2BcBrn6gkkn4HcLRxKiblBwXU/TffRHCjsiPS4k7pLDC7bGWG/No DJWucmIig0Hey5N64tIqeAogPB0iBeCR8jmMM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kb2tikLI+KQMoUxEbmbI74UVqkkRxE1BP6m8PAtlOCY=; b=wfDnLZMuH+kK86U93LDX8PvVLFmaLdEwiFRv4WE7DxJN+ojpcHtiaOqPxADHfRJaZy LrGz2FSdi8//Mgx+qr9lyL2y4p9BsFdFSTqFRVVA/x3t0MlnpVpkKi7OsDCBD+JuVLmt wOKvwczsOCgwBKMJ0RH2cDTOxvD0GdbZ+V6+JYH7liql2cyKj/K9lvl77cTX4kwPS2eZ eEEghMKHUjMpKF3xOkhh8kBdAcKHJzIbaKb+7WsIqQqpWyewcfHkD3oz4S5+74bMTwyO W1HNzLia9+DWrEfYpTZyXXYWKSXQWYPLaXpW2MXRhOoG9IeS2JgCFYriZAlF5DLFcTd4 fmvg== X-Gm-Message-State: AOAM530nsQolZZxnFgwvbfVU96KRAZJ4lnjgPx1ZjYI+UimJAC3Rpx6/ xSw1xyF9Qd61EwL05QTBT5Neex4J4ED1SQ== X-Google-Smtp-Source: ABdhPJwgpDimrJyCd10oaU402ioL7+j8M0SsddJxus3ZsxIVSVL/hzZvKSeYhnJkZG7tNc9toB7Mwg== X-Received: by 2002:a05:6000:1085:: with SMTP id y5mr30551734wrw.696.1640967236625; Fri, 31 Dec 2021 08:13:56 -0800 (PST) Received: from pwmachine.home ([2a01:cb14:983:1f00:eef7:8bf8:8ee0:cb1a]) by smtp.gmail.com with ESMTPSA id f6sm31855522wmq.6.2021.12.31.08.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 08:13:56 -0800 (PST) From: Francis Laniel To: u-boot@lists.denx.de Cc: Marek Behun , Michael Nazzareno Trimarchi , Simon Glass , Wolfgang Denk , Harald Seiler , Francis Laniel Subject: [RFC PATCH v1 00/21] Modernize U-Boot shell Date: Fri, 31 Dec 2021 17:13:06 +0100 Message-Id: <20211231161327.24918-1-francis.laniel@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi. First I hope you are fine and the same for your relatives. During 2021 summer, Sean Anderson wrote a contribution to add a new shell, based on LIL, to U-Boot [1][2]. While one of the goals of this contribution was to address the fact actual U-Boot shell, which is based on Busybox hush, is old there was a discussion about adding a new shell versus updating the actual one [3][4]. So, in this series, with Harald Seiler, we updated the actual U-Boot shell to reflect what is currently in Busybox source code. Basically, this contribution is about taking a snapshot of Busybox shell/hush.c file (as it exists in commit 37460f5da) and adapt it to suit U-Boot needs. This contribution was written to be as backward-compatible as possible to avoid breaking the existing. So, the 2021 hush flavor offers the same as the actual, that is to say: 1. Variable expansion. 2. Instruction lists (;, && and ||). 3. If, then and else. 4. Loops (for, while and until). No new features offered by Busybox hush were implemented (e.g. functions). In terms of testing, new unit tests were added to ut to ensure the new behavior is the same as the old one and it does not add regression. Nonetheless, if old behavior was buggy and fixed upstream, the fix is then added to U-Boot [5]. In sandbox, all of these tests pass smoothly: 2021> printenv board board=sandbox 2021> ut hush Running 20 hush tests ... Failures: 0 Thanks to the effort of Harald Seiler, I was successful booting a board: 2021> printenv board_rev board_rev=iMX8MP 2021> boot ... root@iMX8MPboard:~# fw_printenv board_rev board_rev=iMX8MP I marked this contribution as RFC to indeed collect your opinion. My goal is not to change suddenly actual shell to this one, we clearly need a transition period to think about it. I think it is better to see this contribution as a proof of concept which shows it is possible to update the actual shell. If you want to review it - your review will really be appreciated - here are some information regarding the commits: * commits marked as "test:" deal with unit tests. * commit "cli: Add Busybox upstream hush.c file." copies Busybox shell/hush.c into U-Boot tree, this explain why this commit contains around 12000 additions. * commit "cli: Port Busybox 2021 hush to U-Boot." modifies previously added file to permit us to use this as new shell. The really good idea of #include'ing Busybox code into a wrapper file to define some particular functions while minimizing modifications to upstream code comes from Harald Seiler. * Other commits focus on enabling features we need (e.g. if). Francis Laniel (21): test: Add framework to test hush behavior. test: hush: Test hush if/else. test/py: hush_if_test: Remove the test file. test: hush: Test hush variable expansion. test: hush: Test hush commands list. test: hush: Test hush loops. cli: Add Busybox upstream hush.c file. cli: Port Busybox 2021 hush to U-Boot. cli: Add choice for hush parser. cli: Add HUSH_2021_PARSER to hush parser choice . cli: Enables using hush 2021 parser as command line parser. cli: hush_2021: Enable variables expansion for hush 2021. cli: hush_2021: Add functions to be called from run_command(). cli: Modify run_command() to add hush 2021 as parser. test: hush: Fix instructions list tests for hush 2021. test: hush: Fix variable expansion tests for hush 2021. cli: hush_2021: Enable using \< and \> as string compare operators. cli: hush_2021: Enable if keyword. test: hush: Fix if tests for hush 2021. cli: hush_2021: Enable loops. test: hush: Fix loop tests for hush 2021. cmd/Kconfig | 22 + common/Makefile | 3 +- common/cli.c | 27 +- common/cli_hush_2021.c | 309 + common/cli_hush_2021_upstream.c | 12791 +++++++++++++++++++++++++++ include/cli_hush.h | 8 + include/test/hush.h | 15 + include/test/suites.h | 1 + test/Makefile | 3 + test/cmd_ut.c | 6 + test/hush/Makefile | 10 + test/hush/cmd_ut_hush.c | 20 + test/hush/dollar.c | 242 + test/hush/if.c | 351 + test/hush/list.c | 127 + test/hush/loop.c | 84 + test/py/tests/test_hush_if_test.py | 184 - 17 files changed, 14015 insertions(+), 188 deletions(-) create mode 100644 common/cli_hush_2021.c create mode 100644 common/cli_hush_2021_upstream.c create mode 100644 include/test/hush.h create mode 100644 test/hush/Makefile create mode 100644 test/hush/cmd_ut_hush.c create mode 100644 test/hush/dollar.c create mode 100644 test/hush/if.c create mode 100644 test/hush/list.c create mode 100644 test/hush/loop.c delete mode 100644 test/py/tests/test_hush_if_test.py Best regards, thank you in advance for your reviews and happy new year! --- [1] https://lists.denx.de/pipermail/u-boot/2021-July/453347.html [2] https://runtimeterror.com/tech/lil/ [3] https://lists.denx.de/pipermail/u-boot/2021-July/453790.html [4] https://lists.denx.de/pipermail/u-boot/2021-July/453848.html [5] https://lists.denx.de/pipermail/u-boot/2021-August/458569.html -- 2.25.1