All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: Marek Behun <marek.behun@nic.cz>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Simon Glass <sjg@chromium.org>, Wolfgang Denk <wd@denx.de>,
	Harald Seiler <hws@denx.de>,
	Francis Laniel <francis.laniel@amarulasolutions.com>
Subject: [RFC PATCH v1 11/21] cli: Enables using hush 2021 parser as command line parser.
Date: Fri, 31 Dec 2021 17:13:17 +0100	[thread overview]
Message-ID: <20211231161327.24918-12-francis.laniel@amarulasolutions.com> (raw)
In-Reply-To: <20211231161327.24918-1-francis.laniel@amarulasolutions.com>

If one defines HUSH_2021_PARSER, cli_loop() will jump on hush 2021 parser code.

Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
---
 common/cli.c       | 14 +++++++++++---
 include/cli_hush.h |  8 ++++++++
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/common/cli.c b/common/cli.c
index d86046a728..090677f7a0 100644
--- a/common/cli.c
+++ b/common/cli.c
@@ -40,12 +40,15 @@ int run_command(const char *cmd, int flag)
 		return 1;
 
 	return 0;
-#else
+#elif CONFIG_IS_ENABLED(HUSH_OLD_PARSER)
 	int hush_flags = FLAG_PARSE_SEMICOLON | FLAG_EXIT_FROM_LOOP;
 
 	if (flag & CMD_FLAG_ENV)
 		hush_flags |= FLAG_CONT_ON_NEWLINE;
 	return parse_string_outer(cmd, hush_flags);
+#else /* HUSH_2021_PARSER */
+	/* Not yet implemented. */
+	return 0;
 #endif
 }
 
@@ -104,7 +107,7 @@ int run_command_list(const char *cmd, int len, int flag)
 		memcpy(buff, cmd, len);
 		buff[len] = '\0';
 	}
-#ifdef CONFIG_HUSH_PARSER
+#if CONFIG_IS_ENABLED(HUSH_OLD_PARSER)
 	rcode = parse_string_outer(buff, FLAG_PARSE_SEMICOLON);
 #else
 	/*
@@ -225,7 +228,12 @@ err:
 void cli_loop(void)
 {
 	bootstage_mark(BOOTSTAGE_ID_ENTER_CLI_LOOP);
-#ifdef CONFIG_HUSH_PARSER
+#if CONFIG_IS_ENABLED(HUSH_2021_PARSER)
+	parse_and_run_file();
+	printf("Problem\n");
+	/* This point is never reached */
+	for (;;);
+#elif CONFIG_IS_ENABLED(CONFIG_HUSH_OLD_PARSER)
 	parse_file_outer();
 	/* This point is never reached */
 	for (;;);
diff --git a/include/cli_hush.h b/include/cli_hush.h
index 2bd35670c7..f6c04929b9 100644
--- a/include/cli_hush.h
+++ b/include/cli_hush.h
@@ -14,9 +14,17 @@
 
 extern int u_boot_hush_start(void);
 extern int parse_string_outer(const char *, int);
+#if CONFIG_IS_ENABLED(HUSH_OLD_PARSER)
 extern int parse_file_outer(void);
+#elif CONFIG_IS_ENABLED(HUSH_2021_PARSER)
+extern void parse_and_run_file(void);
+#endif
 
+#if CONFIG_IS_ENABLED(HUSH_OLD_PARSER)
 int set_local_var(const char *s, int flg_export);
+#elif CONFIG_IS_ENABLED(HUSH_2021_PARSER)
+int set_local_var(char *s, int flg_export);
+#endif
 void unset_local_var(const char *name);
 char *get_local_var(const char *s);
 
-- 
2.25.1


  parent reply	other threads:[~2021-12-31 16:17 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-31 16:13 [RFC PATCH v1 00/21] Modernize U-Boot shell Francis Laniel
2021-12-31 16:13 ` [RFC PATCH v1 01/21] test: Add framework to test hush behavior Francis Laniel
2022-01-08 14:53   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 02/21] test: hush: Test hush if/else Francis Laniel
2022-01-08 14:53   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 03/21] test/py: hush_if_test: Remove the test file Francis Laniel
2022-01-08 14:53   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 04/21] test: hush: Test hush variable expansion Francis Laniel
2022-01-08 14:53   ` Simon Glass
2022-02-06 18:22     ` Francis Laniel
2021-12-31 16:13 ` [RFC PATCH v1 05/21] test: hush: Test hush commands list Francis Laniel
2022-01-08 14:54   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 06/21] test: hush: Test hush loops Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 07/21] cli: Add Busybox upstream hush.c file Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 08/21] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 09/21] cli: Add choice for hush parser Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 10/21] cli: Add HUSH_2021_PARSER to hush parser choice Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` Francis Laniel [this message]
2022-01-12 20:03   ` [RFC PATCH v1 11/21] cli: Enables using hush 2021 parser as command line parser Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 12/21] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 13/21] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 14/21] cli: Modify run_command() to add hush 2021 as parser Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 15/21] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 16/21] test: hush: Fix variable expansion " Francis Laniel
2022-01-12 20:03   ` Simon Glass
2022-02-06 18:23     ` Francis Laniel
2022-02-07 20:22       ` Simon Glass
2022-03-24  1:49         ` Francis Laniel
2021-12-31 16:13 ` [RFC PATCH v1 17/21] cli: hush_2021: Enable using \< and \> as string compare operators Francis Laniel
2022-01-12 20:03   ` Simon Glass
2022-02-06 18:23     ` Francis Laniel
2021-12-31 16:13 ` [RFC PATCH v1 18/21] cli: hush_2021: Enable if keyword Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 19/21] test: hush: Fix if tests for hush 2021 Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 20/21] cli: hush_2021: Enable loops Francis Laniel
2022-01-12 20:03   ` Simon Glass
2021-12-31 16:13 ` [RFC PATCH v1 21/21] test: hush: Fix loop tests for hush 2021 Francis Laniel
2022-01-12 20:03   ` Simon Glass
2022-01-31 22:15 ` [RFC PATCH v1 00/21] Modernize U-Boot shell Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211231161327.24918-12-francis.laniel@amarulasolutions.com \
    --to=francis.laniel@amarulasolutions.com \
    --cc=hws@denx.de \
    --cc=marek.behun@nic.cz \
    --cc=michael@amarulasolutions.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.