From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525CDC433F5 for ; Fri, 31 Dec 2021 16:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231264AbhLaQUX (ORCPT ); Fri, 31 Dec 2021 11:20:23 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:46638 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231311AbhLaQUW (ORCPT ); Fri, 31 Dec 2021 11:20:22 -0500 Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 887D24000E for ; Fri, 31 Dec 2021 16:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640967621; bh=TH0oF15Kc0CqVuAFXtLabbq4xKOXn0YXSWaECUHYifY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ohQsEGxu6dujPF8hDVfREz1EEvvQnEnyhJVwDbWg0uxA95gQl7q3cfRBPOKa/R6Dn Uvt8fbMTyknOlQU9QBQxCu4FnZjkA9DvLtLp3SrhO/bL/JmyXWzjnCU1mv8OM9ZSwx WKpC5Ov/10nU1ttIvgJEYV2dSLCJphkFcF2QN+KDgLDCkOO6YZlhpP0/UiVCuRWxYg 9a+3xrryVwXFXfDv1PSPT6pSU/oKTituxnfZud0hUE+mUXxRnjj1qASNwF6i/1WIKh Bbr/Se5i2LiNazEc5E1t5DpAfivHyCNM2Mjb2rqMleDgVXnKX3qG1XDGyuhV+gt34z DfPwVBKZF2NyA== Received: by mail-lf1-f71.google.com with SMTP id k25-20020a056512331900b004259a8d8090so5257935lfe.12 for ; Fri, 31 Dec 2021 08:20:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TH0oF15Kc0CqVuAFXtLabbq4xKOXn0YXSWaECUHYifY=; b=1oKgTEBrtQ2DClBY3Kchc2jx7Fb/8zoEgaGHglsFelIctgrim8R50/pwrw4dTgz/Zv p/K+d9FdwXKFpKQqkSx/5klwdHoIj1C/SMkscEQbXMSJAsS8Xq9WXc4BPtrlUejjOWUp HzlK1vLXxVXvAQtEBPiRZ/riB7264ZyM6n+G5TB4OMO64gJ8HBUFb2tIrpCqb0fDnub6 BgHNiZPeGabRRyvbEP2K8AEjfwcziW2K1A20UYhYpp9vmvOR9k52ROTo3TUIaQ2Nxhdk JC2ue8j1EwmeJcXwkArREpR1mQT+59loZN963IFvOYVeyLE5lStC3bA7jtg86D26j5bN YWow== X-Gm-Message-State: AOAM530zusQkNZydWIm0e04pbn4gUpbRaeVGY7+6HXC9pPQwNb5b3Tas y6b/fkeYdDuTKHGbv5sxVjtriS0VtZKEAWU4lE6JvPzkNsCqrcXjDmZqXuBSwLP2kcord2DAqfU sDbuWPqSl0RaI8vKDUBKaqTkLX9EQt1iq+MNDgQ0= X-Received: by 2002:a05:6512:50c:: with SMTP id o12mr31325059lfb.41.1640967620202; Fri, 31 Dec 2021 08:20:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxMqE/akwbQRGAl1EyK9nwLMn8n/FHmUvm7r3qWQZB4T8laq8h6qcWctul6RIR1PWEOXiId6w== X-Received: by 2002:a05:6512:50c:: with SMTP id o12mr31325047lfb.41.1640967620036; Fri, 31 Dec 2021 08:20:20 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id bx10sm2817607ljb.3.2021.12.31.08.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 08:20:19 -0800 (PST) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Sam Protsenko , Chanho Park Subject: [PATCH 05/24] ARM: dts: exynos: override pins by label in Peach Pit Date: Fri, 31 Dec 2021 17:19:11 +0100 Message-Id: <20211231161930.256733-6-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> References: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Using node paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped label on the other hand, will cause a dtc compile error (during build time). Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 44 +++++++++++----------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index e76fb104db19..1ae5528e9ebf 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -868,27 +868,26 @@ pmic_dvs_1: pmic-dvs-1 { }; }; -&pinctrl_1 { - /* Adjust WiFi drive strengths lower for EMI */ - sd1_clk: sd1-clk { - samsung,pin-drv = ; - }; +/* pinctrl_1 */ +/* Adjust WiFi drive strengths lower for EMI */ +&sd1_bus1 { + samsung,pin-drv = ; +}; - sd1_cmd: sd1-cmd { - samsung,pin-drv = ; - }; +&sd1_bus4 { + samsung,pin-drv = ; +}; - sd1_bus1: sd1-bus-width1 { - samsung,pin-drv = ; - }; +&sd1_bus8 { + samsung,pin-drv = ; +}; - sd1_bus4: sd1-bus-width4 { - samsung,pin-drv = ; - }; +&sd1_clk { + samsung,pin-drv = ; +}; - sd1_bus8: sd1-bus-width8 { - samsung,pin-drv = ; - }; +&sd1_cmd { + samsung,pin-drv = ; }; &pinctrl_2 { @@ -907,12 +906,13 @@ pmic_dvs_3: pmic-dvs-3 { }; }; -&pinctrl_3 { - /* Drive SPI lines at x2 for better integrity */ - spi2-bus { - samsung,pin-drv = ; - }; +/* pinctrl_3*/ +/* Drive SPI lines at x2 for better integrity */ +&spi2_bus { + samsung,pin-drv = ; +}; +&pinctrl_3 { /* Drive SPI chip select at x2 for better integrity */ ec_spi_cs: ec-spi-cs { samsung,pins = "gpb1-2"; -- 2.32.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59017C433FE for ; Fri, 31 Dec 2021 16:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D5hLGO2fIPOJnqp/Ee7NyS9Y4JWJaeEYaw+G722xMeI=; b=4cvpewhEBANF9/ oX7t8Q7ENrA13QVu/YDXZEoNfiM2CdL+fd9MEgVx4kYYzpIXpQhAZHMrOotlUU82A/0u5XSczMapL tEgkri9OliMJOucIR2B8i9q4BFTd05BTpfGofDE1MarMecYRmboDv/nKA1lbZuy7wBgXh2cOOKsbx 8haBhOr35nT+sD4YhJqWq1c+T2mrTZ3cZG3DpQp6qxs4bOcI87AwfhAah2Omb8po/w4z1vwGpKvQ4 3iwZU3BZlltb6fGSOlZeve5XyPy45kouLOh+6SvJ6QlJj3xREXl8wyXE3sTbPy0x1A8q0oUQPtjVP JOtBm9QvgORIuXoi+Ihg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3Ke8-006Gtk-IV; Fri, 31 Dec 2021 16:20:48 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3Kdk-006GnU-Ou for linux-arm-kernel@lists.infradead.org; Fri, 31 Dec 2021 16:20:27 +0000 Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 89C5E3F175 for ; Fri, 31 Dec 2021 16:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640967621; bh=TH0oF15Kc0CqVuAFXtLabbq4xKOXn0YXSWaECUHYifY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ohQsEGxu6dujPF8hDVfREz1EEvvQnEnyhJVwDbWg0uxA95gQl7q3cfRBPOKa/R6Dn Uvt8fbMTyknOlQU9QBQxCu4FnZjkA9DvLtLp3SrhO/bL/JmyXWzjnCU1mv8OM9ZSwx WKpC5Ov/10nU1ttIvgJEYV2dSLCJphkFcF2QN+KDgLDCkOO6YZlhpP0/UiVCuRWxYg 9a+3xrryVwXFXfDv1PSPT6pSU/oKTituxnfZud0hUE+mUXxRnjj1qASNwF6i/1WIKh Bbr/Se5i2LiNazEc5E1t5DpAfivHyCNM2Mjb2rqMleDgVXnKX3qG1XDGyuhV+gt34z DfPwVBKZF2NyA== Received: by mail-lj1-f197.google.com with SMTP id a13-20020a05651c210d00b0022e1dc44d53so1402636ljq.17 for ; Fri, 31 Dec 2021 08:20:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TH0oF15Kc0CqVuAFXtLabbq4xKOXn0YXSWaECUHYifY=; b=K2UuHfIELDREXMCdOY2icPfc9QgTHqmn5quzczmEsvzKswv2uRScuab4d57J/K8NFi qnxlUf8ycxo2dWkHKuILvHXFstrmiPNkeBjDSvwQn1k5I7skzB4Cpp34Amu6iY3B6WZa /meLMpjs+Mjvv7q/66vBEDQvdS8PRH2lYnk27GWbQWyCV8qRyJXu6xxwdO9Jtk3WBxJp RwR7lvcpLSva+leIahx63i8quSIC6kSVts2Tzr7zEFDcYkRb0KKrC37MqDtyhnCDk3lc XtxjFceSnbEcB+NvURIeoX/QG/hFMc8wPJS1k1efWu/+LnG/zGY3O24+VEMMYfPm197c V/4A== X-Gm-Message-State: AOAM5334lwvYKtLPlH7A3nSa6RqBJ5pMQhFmLuyS3jU4xcUeGaCx7Lyk ZyBb647nL/uW+RjSrSgwyYXJhVaDyw2jfzP1rsk7npn0oGyuLLpgrpacqyKwBBrJy1I/j8Kj8gz LfTNRX/bdoMVVV3Bz8xduoQbQRAFiQwQ0s/RMnhZ9pxv25+KzaJ2X X-Received: by 2002:a05:6512:50c:: with SMTP id o12mr31325053lfb.41.1640967620201; Fri, 31 Dec 2021 08:20:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxMqE/akwbQRGAl1EyK9nwLMn8n/FHmUvm7r3qWQZB4T8laq8h6qcWctul6RIR1PWEOXiId6w== X-Received: by 2002:a05:6512:50c:: with SMTP id o12mr31325047lfb.41.1640967620036; Fri, 31 Dec 2021 08:20:20 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id bx10sm2817607ljb.3.2021.12.31.08.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 08:20:19 -0800 (PST) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Sam Protsenko , Chanho Park Subject: [PATCH 05/24] ARM: dts: exynos: override pins by label in Peach Pit Date: Fri, 31 Dec 2021 17:19:11 +0100 Message-Id: <20211231161930.256733-6-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> References: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211231_082025_001425_87A8C850 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using node paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped label on the other hand, will cause a dtc compile error (during build time). Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 44 +++++++++++----------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index e76fb104db19..1ae5528e9ebf 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -868,27 +868,26 @@ pmic_dvs_1: pmic-dvs-1 { }; }; -&pinctrl_1 { - /* Adjust WiFi drive strengths lower for EMI */ - sd1_clk: sd1-clk { - samsung,pin-drv = ; - }; +/* pinctrl_1 */ +/* Adjust WiFi drive strengths lower for EMI */ +&sd1_bus1 { + samsung,pin-drv = ; +}; - sd1_cmd: sd1-cmd { - samsung,pin-drv = ; - }; +&sd1_bus4 { + samsung,pin-drv = ; +}; - sd1_bus1: sd1-bus-width1 { - samsung,pin-drv = ; - }; +&sd1_bus8 { + samsung,pin-drv = ; +}; - sd1_bus4: sd1-bus-width4 { - samsung,pin-drv = ; - }; +&sd1_clk { + samsung,pin-drv = ; +}; - sd1_bus8: sd1-bus-width8 { - samsung,pin-drv = ; - }; +&sd1_cmd { + samsung,pin-drv = ; }; &pinctrl_2 { @@ -907,12 +906,13 @@ pmic_dvs_3: pmic-dvs-3 { }; }; -&pinctrl_3 { - /* Drive SPI lines at x2 for better integrity */ - spi2-bus { - samsung,pin-drv = ; - }; +/* pinctrl_3*/ +/* Drive SPI lines at x2 for better integrity */ +&spi2_bus { + samsung,pin-drv = ; +}; +&pinctrl_3 { /* Drive SPI chip select at x2 for better integrity */ ec_spi_cs: ec-spi-cs { samsung,pins = "gpb1-2"; -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel