From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E0BC433EF for ; Fri, 31 Dec 2021 16:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbhLaQWM (ORCPT ); Fri, 31 Dec 2021 11:22:12 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:46726 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbhLaQWL (ORCPT ); Fri, 31 Dec 2021 11:22:11 -0500 Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id DEE5C3F163 for ; Fri, 31 Dec 2021 16:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640967730; bh=vwFJRx2gAmVsM2SjiJl4digFkX/7ORkgzXaTv+w0Ivo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gBwYVvk3Bck7TJPBbvngTtDd/UHFJeUTT8rgdCbqPh04u0PV+nUEUcNbdRJEMPxq8 3QoeKGvRMKtAbNd4yJHccBRp8Dq75oKgH0W5dFGDblw7E4tBV72LVbhCDJq38mLNJZ jvGfnAJHqbuxNMPi8VaA/b1E/4TYiHIGWkRIv8SIUpyLyahETdyetNiG3G2iL5HZ9s eCnn0XSJ+mtCqJWeYedkCGsF+TlR8pb5EuQwaLyqO23t+u0xTH9LM+cZqjI0a3VRyN Fc9q+QAZj4AIrXq9guc3oxht3IETXiKuDDhG3T4ZymTR+90JxyUvfDFBIj860KXv3B DTxKk0xasEGmw== Received: by mail-lj1-f198.google.com with SMTP id c31-20020a2ebf1f000000b0022d87a28911so9310804ljr.1 for ; Fri, 31 Dec 2021 08:22:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vwFJRx2gAmVsM2SjiJl4digFkX/7ORkgzXaTv+w0Ivo=; b=JO6gsqjKeR67dNOFTgcYl+9GMZwsZ9P7pr86ZmLGqkaZhhHVFUU6EpY+1Dt9rsX+6u CmAkicmwJ2d3jgcyclfJsWXbLOVVL6Uw5QmQiZMXiQ1b6Liqre9GcJCuxVa4OuWqR8aX rGqYJUFJVjjAsIsjxvQvWa2zr0R1CWIsOMufd/uI628uQrHy2TWkIkBl9izCOEvT6Mf6 Mp4Ei7HsLsYSva24JdHYX0FTrS3LNtlIXbdDos9grqG1k0Hp+yiAP4swAzOqWU9G0zMx U1ZpGAscRvVQYuln0gSGzcaJnaXOX30z//bTHmulElafJaGT7mT84PyrJwjnSJIbSKDF duZw== X-Gm-Message-State: AOAM532cr74Xhepk6eNMYxnSrEsc+YVNQ1fe/sXc9iyMG1/wkYX0TvOz ntkhvR+sjGKzz0SUwQ8Jw5u8Ot8TcVw6hoCUxhsKRwbprRYmEeTVL+cgp7r68VJBFg8dVhXOH4e tORXdFEDDL4subgHWJ9pIqIqs1i12udRstJ05e8w= X-Received: by 2002:a2e:a406:: with SMTP id p6mr24918854ljn.13.1640967730327; Fri, 31 Dec 2021 08:22:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzRePFA1r4rMy5Stjb0m7lcPfHvozVux5rIote82Iw0v7IO7g4e2eHmUiX9FdO04m0djEyVQQ== X-Received: by 2002:a2e:a406:: with SMTP id p6mr24918843ljn.13.1640967730180; Fri, 31 Dec 2021 08:22:10 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id y36sm2796514lfa.75.2021.12.31.08.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 08:22:09 -0800 (PST) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Sam Protsenko , Chanho Park Subject: [PATCH 07/24] ARM: dts: exynos: override pins by label in Peach Pi Date: Fri, 31 Dec 2021 17:21:50 +0100 Message-Id: <20211231162207.257478-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> References: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Using node paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped label on the other hand, will cause a dtc compile error (during build time). Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 33 +++++++++++------------ 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 77013ee586f8..6bf3fd37fb2b 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -850,27 +850,26 @@ pmic_dvs_1: pmic-dvs-1 { }; }; -&pinctrl_1 { - /* Adjust WiFi drive strengths lower for EMI */ - sd1_clk: sd1-clk { - samsung,pin-drv = ; - }; +/* pinctrl_1 */ +/* Adjust WiFi drive strengths lower for EMI */ +&sd1_bus1 { + samsung,pin-drv = ; +}; - sd1_cmd: sd1-cmd { - samsung,pin-drv = ; - }; +&sd1_bus4 { + samsung,pin-drv = ; +}; - sd1_bus1: sd1-bus-width1 { - samsung,pin-drv = ; - }; +&sd1_bus8 { + samsung,pin-drv = ; +}; - sd1_bus4: sd1-bus-width4 { - samsung,pin-drv = ; - }; +&sd1_clk { + samsung,pin-drv = ; +}; - sd1_bus8: sd1-bus-width8 { - samsung,pin-drv = ; - }; +&sd1_cmd { + samsung,pin-drv = ; }; &pinctrl_2 { -- 2.32.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65639C433EF for ; Fri, 31 Dec 2021 16:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XlOMp5toaEGRS835+yRaMZKwNUSfYg0ftJ90BzMEkWg=; b=a0oehcXQOSbyOO laJfpw5EIiAe7BX3uwgz6WABF7anDh18S0Uad6X/3a2DZQZ4hoMVJI+/6VYmqxWv8ckEBz1Y2GAig 3XN1eZKvGO9WsbiCdsNmE28wPIrfQVsQM87fDEuvquWWqUIosCru/lDP8zEq0cD11yg5eKVEgNyBq cxdhczATM6OQGrrZMynYCCCZQGSOoSO9+m8L/XZFzPj1+bTveJrOPP766QFf5c3PSr6IK5TcbSf/L W3EHtK2c1cPrwTgdluDesQwgslqOXtYpExxI+3qw1OirNx2tGroEt+qrJRKxqH7PRDl6zb1/sbx/0 NUUvia65TrN9Pd4/MfWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3Kfb-006HVJ-Nl; Fri, 31 Dec 2021 16:22:23 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3KfU-006HRU-8K for linux-arm-kernel@lists.infradead.org; Fri, 31 Dec 2021 16:22:13 +0000 Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id EC1CA3F32C for ; Fri, 31 Dec 2021 16:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640967730; bh=vwFJRx2gAmVsM2SjiJl4digFkX/7ORkgzXaTv+w0Ivo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gBwYVvk3Bck7TJPBbvngTtDd/UHFJeUTT8rgdCbqPh04u0PV+nUEUcNbdRJEMPxq8 3QoeKGvRMKtAbNd4yJHccBRp8Dq75oKgH0W5dFGDblw7E4tBV72LVbhCDJq38mLNJZ jvGfnAJHqbuxNMPi8VaA/b1E/4TYiHIGWkRIv8SIUpyLyahETdyetNiG3G2iL5HZ9s eCnn0XSJ+mtCqJWeYedkCGsF+TlR8pb5EuQwaLyqO23t+u0xTH9LM+cZqjI0a3VRyN Fc9q+QAZj4AIrXq9guc3oxht3IETXiKuDDhG3T4ZymTR+90JxyUvfDFBIj860KXv3B DTxKk0xasEGmw== Received: by mail-lj1-f197.google.com with SMTP id r20-20020a2eb894000000b0021a4e932846so9495486ljp.6 for ; Fri, 31 Dec 2021 08:22:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vwFJRx2gAmVsM2SjiJl4digFkX/7ORkgzXaTv+w0Ivo=; b=rNLAp21IowbofXRxT2pM2Mz/uGskxxnF6cEgvHbNIuXZiZ73DFzH5V9QKQyMc/FfIC iliCKCd9Z7Cvw/7kFinRKNem3p2auVhzKOU085aQ8ptNz8faRJkFxOkJSFdhgoWDSBI4 68ilP55dEx/GEzIm7Bj/MJDM27xqFAsp6nTUXdYTKbEZPm4BMLiobfTdH+4VdU0W+0dQ H3oLgFBbfxk0MQWo0ascXv7inodsOYq8MNZZbOc5LH0OVK/1tPZK2Zl/kG2CPRM34IOk 70Prov5Rf27IxWkBYmbcIUT4Q/mFx/NneA7vVZg98FPXypCXieVC+0HvTvvw7I/A9Hz3 UQCQ== X-Gm-Message-State: AOAM531KcXIbJ9o/s0kKJa1XWNdV67YJFddYZ1Ax/q3NBxFP/+bwdXPC ZtyuONYyV0fpCnQHJbWFSQkofW4gQr0WnXp/D4yL5wbBqZMcdkS/p3KREFUeA/Sz5yWdty6c20P LeXUCjuCRcvBxqnKdto518A2egf+tRkCeRqWGatcpuHhUVS6wMXWA X-Received: by 2002:a2e:a406:: with SMTP id p6mr24918860ljn.13.1640967730328; Fri, 31 Dec 2021 08:22:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzRePFA1r4rMy5Stjb0m7lcPfHvozVux5rIote82Iw0v7IO7g4e2eHmUiX9FdO04m0djEyVQQ== X-Received: by 2002:a2e:a406:: with SMTP id p6mr24918843ljn.13.1640967730180; Fri, 31 Dec 2021 08:22:10 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id y36sm2796514lfa.75.2021.12.31.08.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 08:22:09 -0800 (PST) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Sam Protsenko , Chanho Park Subject: [PATCH 07/24] ARM: dts: exynos: override pins by label in Peach Pi Date: Fri, 31 Dec 2021 17:21:50 +0100 Message-Id: <20211231162207.257478-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> References: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211231_082212_464472_44574E0D X-CRM114-Status: GOOD ( 14.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using node paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped label on the other hand, will cause a dtc compile error (during build time). Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 33 +++++++++++------------ 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 77013ee586f8..6bf3fd37fb2b 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -850,27 +850,26 @@ pmic_dvs_1: pmic-dvs-1 { }; }; -&pinctrl_1 { - /* Adjust WiFi drive strengths lower for EMI */ - sd1_clk: sd1-clk { - samsung,pin-drv = ; - }; +/* pinctrl_1 */ +/* Adjust WiFi drive strengths lower for EMI */ +&sd1_bus1 { + samsung,pin-drv = ; +}; - sd1_cmd: sd1-cmd { - samsung,pin-drv = ; - }; +&sd1_bus4 { + samsung,pin-drv = ; +}; - sd1_bus1: sd1-bus-width1 { - samsung,pin-drv = ; - }; +&sd1_bus8 { + samsung,pin-drv = ; +}; - sd1_bus4: sd1-bus-width4 { - samsung,pin-drv = ; - }; +&sd1_clk { + samsung,pin-drv = ; +}; - sd1_bus8: sd1-bus-width8 { - samsung,pin-drv = ; - }; +&sd1_cmd { + samsung,pin-drv = ; }; &pinctrl_2 { -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel