From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Mueller Subject: Re: [PATCH v12 1/2] crypto: AF_ALG: add AEAD support Date: Fri, 27 Feb 2015 11:26:32 +0100 Message-ID: <2021530.t7zNty0mPn@tauon> References: <1681008.mocmysOoQU@tachyon.chronox.de> <7821728.KTX1G67VgF@tachyon.chronox.de> <20150227094944.GA29071@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: 'Quentin Gouchet' , Daniel Borkmann , 'LKML' , linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Linux API' To: Herbert Xu Return-path: In-Reply-To: <20150227094944.GA29071-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org Am Freitag, 27. Februar 2015, 22:49:44 schrieb Herbert Xu: Hi Herbert, >On Thu, Feb 05, 2015 at 04:10:58PM +0100, Stephan Mueller wrote: >> Am Donnerstag, 29. Januar 2015, 21:24:45 schrieb Stephan Mueller: >> >> Hi Herbert, >> >> > This patch adds the AEAD support for AF_ALG. >> > >> > The implementation is based on algif_skcipher, but contains heavy >> > modifications to streamline the interface for AEAD uses. >> > >> > To use AEAD, the user space consumer has to use the salg_type named >> > "aead". >> >> I just saw Al Viro's patch to use the iov_iter API in >> algif_skcipher.c. I looked at it but lacked documentation for using >> it properly. Now I have a template that I will incorporate into >> algif_aead.c > >Please resubmit once you have done this. I have done that, but as indicated with an email to Al, I cannot get his patch for skcipher and hash to work. Similarly, my modification for the AEAD does not work either. So, I do not see that Al's patch can be merged as is. Therefore, I have not submitted my patch as Al mentioned he wanted to look into his patchset. > >Thanks, Ciao Stephan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbbB0K0j (ORCPT ); Fri, 27 Feb 2015 05:26:39 -0500 Received: from mail.eperm.de ([89.247.134.16]:60324 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbbB0K0h (ORCPT ); Fri, 27 Feb 2015 05:26:37 -0500 X-AuthUser: sm@eperm.de From: Stephan Mueller To: Herbert Xu Cc: "'Quentin Gouchet'" , Daniel Borkmann , "'LKML'" , linux-crypto@vger.kernel.org, "'Linux API'" Subject: Re: [PATCH v12 1/2] crypto: AF_ALG: add AEAD support Date: Fri, 27 Feb 2015 11:26:32 +0100 Message-ID: <2021530.t7zNty0mPn@tauon> User-Agent: KMail/4.14.4 (Linux/3.18.7-200.fc21.x86_64; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150227094944.GA29071@gondor.apana.org.au> References: <1681008.mocmysOoQU@tachyon.chronox.de> <7821728.KTX1G67VgF@tachyon.chronox.de> <20150227094944.GA29071@gondor.apana.org.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 27. Februar 2015, 22:49:44 schrieb Herbert Xu: Hi Herbert, >On Thu, Feb 05, 2015 at 04:10:58PM +0100, Stephan Mueller wrote: >> Am Donnerstag, 29. Januar 2015, 21:24:45 schrieb Stephan Mueller: >> >> Hi Herbert, >> >> > This patch adds the AEAD support for AF_ALG. >> > >> > The implementation is based on algif_skcipher, but contains heavy >> > modifications to streamline the interface for AEAD uses. >> > >> > To use AEAD, the user space consumer has to use the salg_type named >> > "aead". >> >> I just saw Al Viro's patch to use the iov_iter API in >> algif_skcipher.c. I looked at it but lacked documentation for using >> it properly. Now I have a template that I will incorporate into >> algif_aead.c > >Please resubmit once you have done this. I have done that, but as indicated with an email to Al, I cannot get his patch for skcipher and hash to work. Similarly, my modification for the AEAD does not work either. So, I do not see that Al's patch can be merged as is. Therefore, I have not submitted my patch as Al mentioned he wanted to look into his patchset. > >Thanks, Ciao Stephan