From: frowand.list@gmail.com
To: Rob Herring <robh+dt@kernel.org>,
erhard_f@mailbox.org, yinxiujiang@kylinos.cn
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] of: unittest: re-implement overlay tracking
Date: Fri, 31 Dec 2021 21:33:27 -0600 [thread overview]
Message-ID: <20220101033329.1277779-1-frowand.list@gmail.com> (raw)
From: Frank Rowand <frank.rowand@sony.com>
Some overlays are tracked when they are applied. The tracked overlays
are later removed after the overlay tests are completed. The old
implementation makes assumptions about the expected values for
overlay changeset id created by the overlay apply which result
in fragile code. The new code removes the assumptions.
A symptom that exposes a problem with the tracking code is a
warning "UBSAN: shift-out-of-bounds in drivers/of/unittest.c:1933:36",
Kernel Version: 5.15-rc7, PPC-64, Talos II. This results from variable
"id" value of -1 in the final line of of_unittest_untrack_overlay().
The first patch in the series cleans up the inconsistent use of overlay
changeset id and the obsolete overlay id. The id is a core concept in
the overlay tracking that is re-implemented in the second patch in
the series.
Frank Rowand (2):
of: unittest: change references to obsolete overlay id
of: unittest: re-implement overlay tracking
drivers/of/unittest.c | 154 +++++++++++++++++++-----------------------
1 file changed, 71 insertions(+), 83 deletions(-)
--
Frank Rowand <frank.rowand@sony.com>
next reply other threads:[~2022-01-01 3:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 3:33 frowand.list [this message]
2022-01-01 3:33 ` [PATCH 1/2] of: unittest: change references to obsolete overlay id frowand.list
2022-01-05 1:20 ` Rob Herring
2022-01-01 3:33 ` [PATCH 2/2] of: unittest: re-implement overlay tracking frowand.list
2022-01-05 1:22 ` Rob Herring
2022-01-01 3:39 ` [PATCH 0/2] " Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220101033329.1277779-1-frowand.list@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=erhard_f@mailbox.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yinxiujiang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.