All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ovidiu Panait <ovidiu.panait@windriver.com>
To: u-boot@lists.denx.de
Cc: Ovidiu Panait <ovidiu.panait@windriver.com>,
	Simon Glass <sjg@chromium.org>, Bin Meng <bmeng.cn@gmail.com>,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Tim Harvey <tharvey@gateworks.com>
Subject: [PATCH v2 6/7] common: board_r: include asm-generic/gpio.h
Date: Sat,  1 Jan 2022 19:13:30 +0200	[thread overview]
Message-ID: <20220101171332.2676936-6-ovidiu.panait@windriver.com> (raw)
In-Reply-To: <20220101171332.2676936-1-ovidiu.panait@windriver.com>

Not all architectures define <asm/gpio.h> and even on those that do, the
header cannot be included for all boards without causing various build
failures.

Since common/board_r.c only needs gpio_hog_probe_all() declaration, include
<asm-generic/gpio.h> and drop the associated ifdef.

Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---

(no changes since v1)

 common/board_r.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/common/board_r.c b/common/board_r.c
index 7c45e494ed..be225d8f87 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -66,9 +66,7 @@
 #include <linux/err.h>
 #include <efi_loader.h>
 #include <wdt.h>
-#if defined(CONFIG_GPIO_HOG)
-#include <asm/gpio.h>
-#endif
+#include <asm-generic/gpio.h>
 #ifdef CONFIG_EFI_SETUP_EARLY
 #include <efi_loader.h>
 #endif
-- 
2.25.1


  parent reply	other threads:[~2022-01-01 17:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-01 17:13 [PATCH v2 1/7] common: spl: move armv7m-specific code to spl_perform_fixups() Ovidiu Panait
2022-01-01 17:13 ` [PATCH v2 2/7] common: remove bedbug debugger support Ovidiu Panait
2022-01-04  9:17   ` Thomas Huth
2022-01-04 14:11   ` Simon Glass
2022-01-18 17:40   ` Tom Rini
2022-01-01 17:13 ` [PATCH v2 3/7] common: board_r: drop initr_kgdb wrapper Ovidiu Panait
2022-01-18 17:40   ` Tom Rini
2022-01-01 17:13 ` [PATCH v2 4/7] common: board_r: drop initr_addr_map wrapper Ovidiu Panait
2022-01-18 17:40   ` Tom Rini
2022-01-01 17:13 ` [PATCH v2 5/7] common: board_r: move init_addr_map() to init.h Ovidiu Panait
2022-01-18 17:40   ` Tom Rini
2022-01-01 17:13 ` Ovidiu Panait [this message]
2022-01-18 17:40   ` [PATCH v2 6/7] common: board_r: include asm-generic/gpio.h Tom Rini
2022-01-01 17:13 ` [PATCH v2 7/7] common: board_r: drop ifdefs around header includes Ovidiu Panait
2022-01-18 17:40   ` Tom Rini
2022-01-18 17:39 ` [PATCH v2 1/7] common: spl: move armv7m-specific code to spl_perform_fixups() Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220101171332.2676936-6-ovidiu.panait@windriver.com \
    --to=ovidiu.panait@windriver.com \
    --cc=bmeng.cn@gmail.com \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.