From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06FDDC433FE for ; Mon, 3 Jan 2022 06:11:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231815AbiACGLl (ORCPT ); Mon, 3 Jan 2022 01:11:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:41426 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiACGLk (ORCPT ); Mon, 3 Jan 2022 01:11:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641190300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eZWdqglEJRBMyWOswue91QGGug+foo23E07h4yycLxk=; b=UoWwmUTCiOr4Q+ETUTbX7SuB9YDG70Acx/InccEsUaBN57qlBZ9fnR1CQtguM8eqER/inY nyCnZfgqksrUFsvmmBe4bpUVDeA4U713dcMOYPSNmCXJfPMjp3MuOkmGXdwEKSWMRRMhHZ VK4dcFRcZhPxG85cLQNe9ExCQBIAzO0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-jznnFRq4Ox2x6SNXuNadWw-1; Mon, 03 Jan 2022 01:11:36 -0500 X-MC-Unique: jznnFRq4Ox2x6SNXuNadWw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB1321006AA9; Mon, 3 Jan 2022 06:11:33 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76F497B9DB; Mon, 3 Jan 2022 06:11:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C52A6180039F; Mon, 3 Jan 2022 07:11:27 +0100 (CET) Date: Mon, 3 Jan 2022 07:11:27 +0100 From: Gerd Hoffmann To: Niklas Schnelle Cc: Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Dave Airlie , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC 26/32] drm: handle HAS_IOPORT dependencies Message-ID: <20220103061127.jrnsfuxbxk2ywmtg@sirius.home.kraxel.org> References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-27-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211227164317.4146918-27-schnelle@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 27, 2021 at 05:43:11PM +0100, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. There is also a direct and hard coded use in > cirrus.c which according to the comment is only necessary during resume. > Let's just skip this as for example s390 which doesn't have I/O port > support also doesen't support suspend/resume. > config DRM_BOCHS > tristate "DRM Support for bochs dispi vga interface (qemu stdvga)" > depends on DRM && PCI && MMU > + depends on HAS_IOPORT > select DRM_KMS_HELPER > select DRM_VRAM_HELPER > select DRM_TTM On devices with an mmio bar the driver works just fine without inb/outb, see bochs->mmio checks in bochs.c take care, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 342FFC433EF for ; Mon, 3 Jan 2022 06:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vPrL136yNFEz8yzfOc8ZzR6It48vo5NRrjv2FQTplX4=; b=CRmQvVyIf13LZ7 WnVKYAqyq7jjQoL2bjGNJo/5UrUZEKRFneQko/KO5tA2b2uJBPOjyg4yNmHjNW497S7mz+eyJxpCs FfORGn7E/aEJeqyqGLlQ3/V5+Npqc+wxWVI1rF0H7ScVpXcdYLAIgCuNFWmFlEUVMDLEs7Pe41hJz paQoMbhMzEWnEiW4rB/ZbEg1xWuI/zUge1QcYoeT53bL9pRvUITB6yMi8KBOl7WV8yNpUNPRJ3nD5 8nSFVGBO2i32NGA2mez5NXI5hguyWwQRgHrN05HYG05RmWMmhbPLzKPvKKYrcW8oXi85AwssY3O0D asC6Bd3beKcp7DbYiqHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4GZO-008RY4-Rh; Mon, 03 Jan 2022 06:11:46 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4GZL-008RWz-Ff for linux-riscv@lists.infradead.org; Mon, 03 Jan 2022 06:11:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641190300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eZWdqglEJRBMyWOswue91QGGug+foo23E07h4yycLxk=; b=UoWwmUTCiOr4Q+ETUTbX7SuB9YDG70Acx/InccEsUaBN57qlBZ9fnR1CQtguM8eqER/inY nyCnZfgqksrUFsvmmBe4bpUVDeA4U713dcMOYPSNmCXJfPMjp3MuOkmGXdwEKSWMRRMhHZ VK4dcFRcZhPxG85cLQNe9ExCQBIAzO0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-jznnFRq4Ox2x6SNXuNadWw-1; Mon, 03 Jan 2022 01:11:36 -0500 X-MC-Unique: jznnFRq4Ox2x6SNXuNadWw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB1321006AA9; Mon, 3 Jan 2022 06:11:33 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76F497B9DB; Mon, 3 Jan 2022 06:11:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C52A6180039F; Mon, 3 Jan 2022 07:11:27 +0100 (CET) Date: Mon, 3 Jan 2022 07:11:27 +0100 From: Gerd Hoffmann To: Niklas Schnelle Cc: Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Dave Airlie , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC 26/32] drm: handle HAS_IOPORT dependencies Message-ID: <20220103061127.jrnsfuxbxk2ywmtg@sirius.home.kraxel.org> References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-27-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211227164317.4146918-27-schnelle@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220102_221143_644013_62B48518 X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Dec 27, 2021 at 05:43:11PM +0100, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. There is also a direct and hard coded use in > cirrus.c which according to the comment is only necessary during resume. > Let's just skip this as for example s390 which doesn't have I/O port > support also doesen't support suspend/resume. > config DRM_BOCHS > tristate "DRM Support for bochs dispi vga interface (qemu stdvga)" > depends on DRM && PCI && MMU > + depends on HAS_IOPORT > select DRM_KMS_HELPER > select DRM_VRAM_HELPER > select DRM_TTM On devices with an mmio bar the driver works just fine without inb/outb, see bochs->mmio checks in bochs.c take care, Gerd _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8797FC433EF for ; Mon, 3 Jan 2022 06:11:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id F2E3460B0A; Mon, 3 Jan 2022 06:11:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eV2gut_gJz-5; Mon, 3 Jan 2022 06:11:48 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 89E3760AF7; Mon, 3 Jan 2022 06:11:47 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5F193C0030; Mon, 3 Jan 2022 06:11:47 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8B8E3C001E for ; Mon, 3 Jan 2022 06:11:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5BCD4400FC for ; Mon, 3 Jan 2022 06:11:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3EVzPAnNd814 for ; Mon, 3 Jan 2022 06:11:44 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id F3D49400BA for ; Mon, 3 Jan 2022 06:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641190302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eZWdqglEJRBMyWOswue91QGGug+foo23E07h4yycLxk=; b=HRL5YnHa1yulGnOA1JzB549mXs0VZGS41FPJu/odPYeDh13i5tKe7lVZVXRCSXAAEcpO16 OGQAyDzIk3KHK71nS6xhHEVIlvfzZ/l0ceAi/wgS/MSiCWNBCE7qYMkvpmdtEbdxZI8GFR mCvbtmJ9JoC0rEXOU7GhWHzAeFLBWO0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-jznnFRq4Ox2x6SNXuNadWw-1; Mon, 03 Jan 2022 01:11:36 -0500 X-MC-Unique: jznnFRq4Ox2x6SNXuNadWw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB1321006AA9; Mon, 3 Jan 2022 06:11:33 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76F497B9DB; Mon, 3 Jan 2022 06:11:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C52A6180039F; Mon, 3 Jan 2022 07:11:27 +0100 (CET) Date: Mon, 3 Jan 2022 07:11:27 +0100 From: Gerd Hoffmann To: Niklas Schnelle Subject: Re: [RFC 26/32] drm: handle HAS_IOPORT dependencies Message-ID: <20220103061127.jrnsfuxbxk2ywmtg@sirius.home.kraxel.org> References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-27-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211227164317.4146918-27-schnelle@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Cc: linux-arch@vger.kernel.org, Arnd Bergmann , Albert Ou , Dave Airlie , Nick Hu , David Airlie , linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org, John Garry , linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, virtualization@lists.linux-foundation.org, Palmer Dabbelt , Greentime Hu , Daniel Vetter , Paul Walmsley , Bjorn Helgaas , Guo Ren , linux-riscv@lists.infradead.org, Vincent Chen , spice-devel@lists.freedesktop.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Mon, Dec 27, 2021 at 05:43:11PM +0100, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. There is also a direct and hard coded use in > cirrus.c which according to the comment is only necessary during resume. > Let's just skip this as for example s390 which doesn't have I/O port > support also doesen't support suspend/resume. > config DRM_BOCHS > tristate "DRM Support for bochs dispi vga interface (qemu stdvga)" > depends on DRM && PCI && MMU > + depends on HAS_IOPORT > select DRM_KMS_HELPER > select DRM_VRAM_HELPER > select DRM_TTM On devices with an mmio bar the driver works just fine without inb/outb, see bochs->mmio checks in bochs.c take care, Gerd _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1350AC433F5 for ; Mon, 3 Jan 2022 06:11:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A86D089EB7; Mon, 3 Jan 2022 06:11:46 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF6B689EF7 for ; Mon, 3 Jan 2022 06:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641190303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eZWdqglEJRBMyWOswue91QGGug+foo23E07h4yycLxk=; b=LJt80vniwxiBNJUma8fdKWkmrB4qaH+g66DlwDXr0l8RxVYQZLJ0YbN4eXdhYvmSm2C+F3 RPkHCXZa18gkayucj0foUdQMtUHpsqHQIjwo5WxARHPlt7ikxNaWaPOtjXP8IKC1M7M9fM UVE30ZiW/p7Yex8lsb8r9ALKya6jkWc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-jznnFRq4Ox2x6SNXuNadWw-1; Mon, 03 Jan 2022 01:11:36 -0500 X-MC-Unique: jznnFRq4Ox2x6SNXuNadWw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB1321006AA9; Mon, 3 Jan 2022 06:11:33 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76F497B9DB; Mon, 3 Jan 2022 06:11:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C52A6180039F; Mon, 3 Jan 2022 07:11:27 +0100 (CET) Date: Mon, 3 Jan 2022 07:11:27 +0100 From: Gerd Hoffmann To: Niklas Schnelle Subject: Re: [RFC 26/32] drm: handle HAS_IOPORT dependencies Message-ID: <20220103061127.jrnsfuxbxk2ywmtg@sirius.home.kraxel.org> References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-27-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211227164317.4146918-27-schnelle@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Arnd Bergmann , Albert Ou , Dave Airlie , Nick Hu , David Airlie , linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org, John Garry , linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, virtualization@lists.linux-foundation.org, Palmer Dabbelt , Greentime Hu , Paul Walmsley , Bjorn Helgaas , Guo Ren , linux-riscv@lists.infradead.org, Vincent Chen , spice-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Dec 27, 2021 at 05:43:11PM +0100, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. There is also a direct and hard coded use in > cirrus.c which according to the comment is only necessary during resume. > Let's just skip this as for example s390 which doesn't have I/O port > support also doesen't support suspend/resume. > config DRM_BOCHS > tristate "DRM Support for bochs dispi vga interface (qemu stdvga)" > depends on DRM && PCI && MMU > + depends on HAS_IOPORT > select DRM_KMS_HELPER > select DRM_VRAM_HELPER > select DRM_TTM On devices with an mmio bar the driver works just fine without inb/outb, see bochs->mmio checks in bochs.c take care, Gerd