[OE-Core][PATCH v2] gstreamer1.0-plugins-bad: Add support for mpegtsmux

[OE-Core][PATCH v2] gstreamer1.0-plugins-bad: Add support for mpegtsmux

[Joakim Roubert]

From: Joakim Roubert <joakimr@axis.com>

When enabling srt one most likely also wants to use mpegtsmux.

Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb                 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb
index f90dff693d..9233c3bec1 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb
@@ -65,6 +65,7 @@ PACKAGECONFIG[libmms]          = "-Dlibmms=enabled,-Dlibmms=disabled,libmms"
 PACKAGECONFIG[libssh2]         = "-Dcurl-ssh2=enabled,-Dcurl-ssh2=disabled,libssh2"
 PACKAGECONFIG[lcms2]           = "-Dcolormanagement=enabled,-Dcolormanagement=disabled,lcms"
 PACKAGECONFIG[modplug]         = "-Dmodplug=enabled,-Dmodplug=disabled,libmodplug"
+PACKAGECONFIG[mpegtsmux]       = "-Dmpegtsmux=enabled,-Dmpegtsmux=disabled""
 PACKAGECONFIG[msdk]            = "-Dmsdk=enabled,-Dmsdk=disabled,intel-mediasdk"
 PACKAGECONFIG[neon]            = "-Dneon=enabled,-Dneon=disabled,neon"
 PACKAGECONFIG[openal]          = "-Dopenal=enabled,-Dopenal=disabled,openal-soft"
-- 
2.30.2

Re: [OE-Core][PATCH v2] gstreamer1.0-plugins-bad: Add support for mpegtsmux

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 2309 bytes --]

Joakim Roubert <joakim.roubert@axis.com> escreveu no dia segunda, 3/01/2022
à(s) 08:39:

> From: Joakim Roubert <joakimr@axis.com>
>
> When enabling srt one most likely also wants to use mpegtsmux.
>
> Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
> ---
>  .../gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb                 | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.18.5.bb b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.18.5.bb
> index f90dff693d..9233c3bec1 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb
> @@ -65,6 +65,7 @@ PACKAGECONFIG[libmms]          =
> "-Dlibmms=enabled,-Dlibmms=disabled,libmms"
>  PACKAGECONFIG[libssh2]         =
> "-Dcurl-ssh2=enabled,-Dcurl-ssh2=disabled,libssh2"
>  PACKAGECONFIG[lcms2]           =
> "-Dcolormanagement=enabled,-Dcolormanagement=disabled,lcms"
>  PACKAGECONFIG[modplug]         =
> "-Dmodplug=enabled,-Dmodplug=disabled,libmodplug"
> +PACKAGECONFIG[mpegtsmux]       =
> "-Dmpegtsmux=enabled,-Dmpegtsmux=disabled""
>

this patch is not backward compatible as it will disable the mpegtsmux
plugin because PACKAGECONFIG don't have mpegtsmux

mpegtsmux doesn't have any external dependencies and is not present
in EXTRA_OEMESON so it is always enabled.
with this patch the default config will build it with -Dmpegtsmux=disabled

Jose


>  PACKAGECONFIG[msdk]            =
> "-Dmsdk=enabled,-Dmsdk=disabled,intel-mediasdk"
>  PACKAGECONFIG[neon]            = "-Dneon=enabled,-Dneon=disabled,neon"
>  PACKAGECONFIG[openal]          =
> "-Dopenal=enabled,-Dopenal=disabled,openal-soft"
> --
> 2.30.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#160115):
> https://lists.openembedded.org/g/openembedded-core/message/160115
> Mute This Topic: https://lists.openembedded.org/mt/88108871/5052612
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 4164 bytes --]

Re: [OE-Core][PATCH v2] gstreamer1.0-plugins-bad: Add support for mpegtsmux

[Joakim Roubert]

On 2022-01-03 16:32, Jose Quaresma wrote:
> mpegtsmux doesn't have any external dependencies and is not present 
> in EXTRA_OEMESON so it is always enabled.
> with this patch the default config will build it with -Dmpegtsmux=disabled

I can see that now, having had it explained to me. Thank you, then my 
submission should of course be void and ignored.

BR,

/Joakim