From: Jakub Kicinski <kuba@kernel.org>
To: Saurav Kashyap <skashyap@marvell.com>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
Javed Hasan <jhasan@marvell.com>,
GR-QLogic-Storage-Upstream
<GR-QLogic-Storage-Upstream@marvell.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer
Date: Mon, 3 Jan 2022 09:12:22 -0800 [thread overview]
Message-ID: <20220103091222.194ef58f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <DM6PR18MB30344528373170A95E67B50CD2499@DM6PR18MB3034.namprd18.prod.outlook.com>
On Mon, 3 Jan 2022 04:58:41 +0000 Saurav Kashyap wrote:
> > QEDF_TERM_BUFF_SIZE,
> > &term_params_dma, GFP_KERNEL);
> > + if (!term_params)
> > + return;
>
> <SK> Adding message about failure before returning will help in debugging.
Memory allocations produce a pretty detailed splat.
next prev parent reply other threads:[~2022-01-03 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 10:14 [PATCH] scsi: qedf: potential dereference of null pointer Jiasheng Jiang
2022-01-03 4:58 ` [EXT] " Saurav Kashyap
2022-01-03 17:12 ` Jakub Kicinski [this message]
2022-01-04 4:05 ` Saurav Kashyap
2022-01-05 5:20 ` Martin K. Petersen
2022-01-10 22:04 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103091222.194ef58f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=jejb@linux.ibm.com \
--cc=jhasan@marvell.com \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=martin.petersen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.