Re: [PATCH 2/2] btrfs: output more debug message for uncommitted transaction

[David Sterba <dsterba@suse.cz>]

On Thu, Dec 16, 2021 at 07:47:36PM +0800, Qu Wenruo wrote:
> The extra info like how many dirty bytes this uncommitted transaction
> has can be very helpful.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>

This does not depend on the first patch, so I'll apply that now.

> ---
>  fs/btrfs/disk-io.c | 43 ++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 5c598e124c25..25e0248e3c55 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -4491,6 +4491,47 @@ int btrfs_commit_super(struct btrfs_fs_info *fs_info)
>  	return btrfs_commit_transaction(trans);
>  }
>  
> +static void warn_about_uncommitted_trans(struct btrfs_fs_info *fs_info)
> +{
> +	struct btrfs_transaction *trans;
> +	struct btrfs_transaction *tmp;
> +	bool found = false;
> +
> +	if (likely(list_empty(&fs_info->trans_list)))
> +		return;
> +
> +	/*
> +	 * This function is only called at the very end of close_ctree(),
> +	 * thus no other running transaction, no need to take trans_lock.
> +	 */

I've added an assert

	ASSERT(test_bit(BTRFS_FS_CLOSING_DONE, &fs_info->flags));

just in case somebody would use it as a warning function outside of the
close_tree context.