All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/21] Improve compile test coverage
@ 2022-01-04  9:04 Damien Le Moal
  2022-01-04  9:04 ` [PATCH 01/21] ata: sata_fsl: add compile test support Damien Le Moal
                   ` (20 more replies)
  0 siblings, 21 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Patches 1 to 18 enable the compilation of all ata drivers that can be   
compiled with CONFIG_COMPILE_TEST to improve compile test coverage.     
The last 3 patches fix compilation and sparse warnings found by enabling
COMPILE_TEST on a x86_64 host.

Damien Le Moal (21):
  ata: sata_fsl: add compile test support
  ata: ahci_brcm: add compile test support
  ata: ahci_da850: add compile test support
  ata: ahci_dm816: add compile test support
  ata: ahci_st: add compile test support
  ata: ahci_mtk: add compile test support
  ata: ahci_mvebu: add compile test support
  ata: ahci_sunxi: add compile test support
  ata: ahci_tegra: add compile test support
  ata: ahci_xgene: add compile test support
  ata: ahci_seattle: add compile test support
  ata: pata_bk3710: add compile test support
  ata: pata_cs5535: add compile test support
  ata: pata_ftide010: add compile test support
  ata: pata_imx: add compile test support
  ata: pata_pxa: add compile test support
  ata: pata_legacy: add compile test support
  ata: pata_samsung_cf: add compile test support
  ata: sata_fsl: fix scsi host initialization
  ata: ahci_xgene: use correct type for port mmio address
  ata: ahci_xgene: Fix id array access in xgene_ahci_read_id()

 drivers/ata/Kconfig      | 38 +++++++++++++++++++-------------------
 drivers/ata/ahci_xgene.c |  9 +++++----
 drivers/ata/sata_fsl.c   |  3 +--
 include/linux/libata.h   | 11 +++++++++++
 4 files changed, 36 insertions(+), 25 deletions(-)

-- 
2.31.1


^ permalink raw reply	[flat|nested] 22+ messages in thread
* [PATCH 01/21] ata: sata_fsl: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 02/21] ata: ahci_brcm: " Damien Le Moal
                   ` (19 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add dependendy on COMPILE_TEST to allow compile tests with configs that
do not enable FSL_SOC.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 9ebaa3c288dd..80bad7cba631 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -290,7 +290,7 @@ config AHCI_QORIQ
 
 config SATA_FSL
 	tristate "Freescale 3.0Gbps SATA support"
-	depends on FSL_SOC
+	depends on FSL_SOC || COMPILE_TEST
 	select SATA_HOST
 	help
 	  This option enables support for Freescale 3.0Gbps SATA controller.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 02/21] ata: ahci_brcm: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
  2022-01-04  9:04 ` [PATCH 01/21] ata: sata_fsl: add compile test support Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 03/21] ata: ahci_da850: " Damien Le Moal
                   ` (18 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_BRCMSTB, BMIPS_GENERIC or ARCH_BCM_XXX.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 80bad7cba631..3bf38a328851 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -163,7 +163,7 @@ config SATA_AHCI_PLATFORM
 config AHCI_BRCM
 	tristate "Broadcom AHCI SATA support"
 	depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_NSP || \
-		   ARCH_BCM_63XX
+		   ARCH_BCM_63XX || COMPILE_TEST
 	select SATA_HOST
 	help
 	  This option enables support for the AHCI SATA3 controller found on
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 03/21] ata: ahci_da850: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
  2022-01-04  9:04 ` [PATCH 01/21] ata: sata_fsl: add compile test support Damien Le Moal
  2022-01-04  9:04 ` [PATCH 02/21] ata: ahci_brcm: " Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 04/21] ata: ahci_dm816: " Damien Le Moal
                   ` (17 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_DAVINCI_DA850.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 3bf38a328851..9f1288fd5482 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -173,7 +173,7 @@ config AHCI_BRCM
 
 config AHCI_DA850
 	tristate "DaVinci DA850 AHCI SATA support"
-	depends on ARCH_DAVINCI_DA850
+	depends on ARCH_DAVINCI_DA850 || COMPILE_TEST
 	select SATA_HOST
 	help
 	  This option enables support for the DaVinci DA850 SoC's
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 04/21] ata: ahci_dm816: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (2 preceding siblings ...)
  2022-01-04  9:04 ` [PATCH 03/21] ata: ahci_da850: " Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 05/21] ata: ahci_st: " Damien Le Moal
                   ` (16 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_OMAP2PLUS.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 9f1288fd5482..e9f919f17d09 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -183,7 +183,7 @@ config AHCI_DA850
 
 config AHCI_DM816
 	tristate "DaVinci DM816 AHCI SATA support"
-	depends on ARCH_OMAP2PLUS
+	depends on ARCH_OMAP2PLUS || COMPILE_TEST
 	select SATA_HOST
 	help
 	  This option enables support for the DaVinci DM816 SoC's
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 05/21] ata: ahci_st: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (3 preceding siblings ...)
  2022-01-04  9:04 ` [PATCH 04/21] ata: ahci_dm816: " Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 06/21] ata: ahci_mtk: " Damien Le Moal
                   ` (15 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_STI.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index e9f919f17d09..83fac101744c 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -193,7 +193,7 @@ config AHCI_DM816
 
 config AHCI_ST
 	tristate "ST AHCI SATA support"
-	depends on ARCH_STI
+	depends on ARCH_STI || COMPILE_TEST
 	select SATA_HOST
 	help
 	  This option enables support for ST AHCI SATA controller.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 06/21] ata: ahci_mtk: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (4 preceding siblings ...)
  2022-01-04  9:04 ` [PATCH 05/21] ata: ahci_st: " Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 07/21] ata: ahci_mvebu: " Damien Le Moal
                   ` (14 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_MEDIATEK.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 83fac101744c..1545201b9104 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -223,7 +223,7 @@ config AHCI_CEVA
 
 config AHCI_MTK
 	tristate "MediaTek AHCI SATA support"
-	depends on ARCH_MEDIATEK
+	depends on ARCH_MEDIATEK || COMPILE_TEST
 	select MFD_SYSCON
 	select SATA_HOST
 	help
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 07/21] ata: ahci_mvebu: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (5 preceding siblings ...)
  2022-01-04  9:04 ` [PATCH 06/21] ata: ahci_mtk: " Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 08/21] ata: ahci_sunxi: " Damien Le Moal
                   ` (13 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_MVEBU.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 1545201b9104..237124624db4 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -234,7 +234,7 @@ config AHCI_MTK
 
 config AHCI_MVEBU
 	tristate "Marvell EBU AHCI SATA support"
-	depends on ARCH_MVEBU
+	depends on ARCH_MVEBU || COMPILE_TEST
 	select SATA_HOST
 	help
 	  This option enables support for the Marvebu EBU SoC's
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 08/21] ata: ahci_sunxi: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (6 preceding siblings ...)
  2022-01-04  9:04 ` [PATCH 07/21] ata: ahci_mvebu: " Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 09/21] ata: ahci_tegra: " Damien Le Moal
                   ` (12 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_SUNXI.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 237124624db4..db3f65ae1ed5 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -253,7 +253,7 @@ config AHCI_OCTEON
 
 config AHCI_SUNXI
 	tristate "Allwinner sunxi AHCI SATA support"
-	depends on ARCH_SUNXI
+	depends on ARCH_SUNXI || COMPILE_TEST
 	select SATA_HOST
 	help
 	  This option enables support for the Allwinner sunxi SoC's
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 09/21] ata: ahci_tegra: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (7 preceding siblings ...)
  2022-01-04  9:04 ` [PATCH 08/21] ata: ahci_sunxi: " Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 10/21] ata: ahci_xgene: " Damien Le Moal
                   ` (11 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_TEGRA.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index db3f65ae1ed5..9def63c7e9ad 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -263,7 +263,7 @@ config AHCI_SUNXI
 
 config AHCI_TEGRA
 	tristate "NVIDIA Tegra AHCI SATA support"
-	depends on ARCH_TEGRA
+	depends on ARCH_TEGRA || COMPILE_TEST
 	select SATA_HOST
 	help
 	  This option enables support for the NVIDIA Tegra SoC's
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 10/21] ata: ahci_xgene: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (8 preceding siblings ...)
  2022-01-04  9:04 ` [PATCH 09/21] ata: ahci_tegra: " Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 11/21] ata: ahci_seattle: " Damien Le Moal
                   ` (10 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable PHY_XGENE.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 9def63c7e9ad..1be6a14e46e1 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -273,7 +273,7 @@ config AHCI_TEGRA
 
 config AHCI_XGENE
 	tristate "APM X-Gene 6.0Gbps AHCI SATA host controller support"
-	depends on PHY_XGENE
+	depends on PHY_XGENE || COMPILE_TEST
 	select SATA_HOST
 	help
 	 This option enables support for APM X-Gene SoC SATA host controller.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 11/21] ata: ahci_seattle: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (9 preceding siblings ...)
  2022-01-04  9:04 ` [PATCH 10/21] ata: ahci_xgene: " Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:04 ` [PATCH 12/21] ata: pata_bk3710: " Damien Le Moal
                   ` (9 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_SEATTLE.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 1be6a14e46e1..8df5b32e6879 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -311,7 +311,7 @@ config SATA_GEMINI
 
 config SATA_AHCI_SEATTLE
 	tristate "AMD Seattle 6.0Gbps AHCI SATA host controller support"
-	depends on ARCH_SEATTLE
+	depends on ARCH_SEATTLE || COMPILE_TEST
 	select SATA_HOST
 	help
 	 This option enables support for AMD Seattle SATA host controller.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 12/21] ata: pata_bk3710: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (10 preceding siblings ...)
  2022-01-04  9:04 ` [PATCH 11/21] ata: ahci_seattle: " Damien Le Moal
@ 2022-01-04  9:04 ` Damien Le Moal
  2022-01-04  9:05 ` [PATCH 13/21] ata: pata_cs5535: " Damien Le Moal
                   ` (8 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:04 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_DAVINCI.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 8df5b32e6879..b706a3a64b11 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -616,7 +616,7 @@ config PATA_ATP867X
 
 config PATA_BK3710
 	tristate "Palmchip BK3710 PATA support"
-	depends on ARCH_DAVINCI
+	depends on ARCH_DAVINCI || COMPILE_TEST
 	select PATA_TIMINGS
 	help
 	  This option enables support for the integrated IDE controller on
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 13/21] ata: pata_cs5535: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (11 preceding siblings ...)
  2022-01-04  9:04 ` [PATCH 12/21] ata: pata_bk3710: " Damien Le Moal
@ 2022-01-04  9:05 ` Damien Le Moal
  2022-01-04  9:05 ` [PATCH 14/21] ata: pata_ftide010: " Damien Le Moal
                   ` (7 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:05 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not have X86_32 enabled.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index b706a3a64b11..daf57a4e8196 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -654,7 +654,7 @@ config PATA_CS5530
 
 config PATA_CS5535
 	tristate "CS5535 PATA support (Experimental)"
-	depends on PCI && X86_32
+	depends on PCI && (X86_32 || COMPILE_TEST)
 	help
 	  This option enables support for the NatSemi/AMD CS5535
 	  companion chip used with the Geode processor family.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 14/21] ata: pata_ftide010: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (12 preceding siblings ...)
  2022-01-04  9:05 ` [PATCH 13/21] ata: pata_cs5535: " Damien Le Moal
@ 2022-01-04  9:05 ` Damien Le Moal
  2022-01-04  9:05 ` [PATCH 15/21] ata: pata_imx: " Damien Le Moal
                   ` (6 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:05 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARM.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index daf57a4e8196..1b18de61e8df 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -702,7 +702,7 @@ config PATA_EP93XX
 config PATA_FTIDE010
 	tristate "Faraday Technology FTIDE010 PATA support"
 	depends on OF
-	depends on ARM
+	depends on ARM || COMPILE_TEST
 	depends on SATA_GEMINI
 	help
 	  This option enables support for the Faraday FTIDE010
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 15/21] ata: pata_imx: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (13 preceding siblings ...)
  2022-01-04  9:05 ` [PATCH 14/21] ata: pata_ftide010: " Damien Le Moal
@ 2022-01-04  9:05 ` Damien Le Moal
  2022-01-04  9:05 ` [PATCH 16/21] ata: pata_pxa: " Damien Le Moal
                   ` (5 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:05 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_MXC.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 1b18de61e8df..e4e4460cb1fe 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -765,7 +765,7 @@ config PATA_ICSIDE
 
 config PATA_IMX
 	tristate "PATA support for Freescale iMX"
-	depends on ARCH_MXC
+	depends on ARCH_MXC || COMPILE_TEST
 	select PATA_TIMINGS
 	help
 	  This option enables support for the PATA host available on Freescale
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 16/21] ata: pata_pxa: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (14 preceding siblings ...)
  2022-01-04  9:05 ` [PATCH 15/21] ata: pata_imx: " Damien Le Moal
@ 2022-01-04  9:05 ` Damien Le Moal
  2022-01-04  9:05 ` [PATCH 17/21] ata: pata_legacy: " Damien Le Moal
                   ` (4 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:05 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ARCH_PXA.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index e4e4460cb1fe..59576f92c730 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -986,7 +986,7 @@ config PATA_VIA
 
 config PATA_PXA
 	tristate "PXA DMA-capable PATA support"
-	depends on ARCH_PXA
+	depends on ARCH_PXA || COMPILE_TEST
 	help
 	  This option enables support for harddrive attached to PXA CPU's bus.
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 17/21] ata: pata_legacy: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (15 preceding siblings ...)
  2022-01-04  9:05 ` [PATCH 16/21] ata: pata_pxa: " Damien Le Moal
@ 2022-01-04  9:05 ` Damien Le Moal
  2022-01-04  9:05 ` [PATCH 18/21] ata: pata_samsung_cf: " Damien Le Moal
                   ` (3 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:05 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable ISA.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 59576f92c730..490f0856a271 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1137,7 +1137,7 @@ config PATA_OF_PLATFORM
 
 config PATA_QDI
 	tristate "QDI VLB PATA support"
-	depends on ISA
+	depends on ISA || COMPILE_TEST
 	select PATA_LEGACY
 	help
 	  Support for QDI 6500 and 6580 PATA controllers on VESA local bus.
@@ -1172,7 +1172,7 @@ config PATA_SAMSUNG_CF
 
 config PATA_WINBOND_VLB
 	tristate "Winbond W83759A VLB PATA support (Experimental)"
-	depends on ISA
+	depends on ISA || COMPILE_TEST
 	select PATA_LEGACY
 	help
 	  Support for the Winbond W83759A controller on Vesa Local Bus
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 18/21] ata: pata_samsung_cf: add compile test support
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (16 preceding siblings ...)
  2022-01-04  9:05 ` [PATCH 17/21] ata: pata_legacy: " Damien Le Moal
@ 2022-01-04  9:05 ` Damien Le Moal
  2022-01-04  9:05 ` [PATCH 19/21] ata: sata_fsl: fix scsi host initialization Damien Le Moal
                   ` (2 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:05 UTC (permalink / raw)
  To: linux-ide

Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
configs that do not enable SAMSUNG_DEV_IDE.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 490f0856a271..8af5659a7676 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1162,7 +1162,7 @@ config PATA_RZ1000
 
 config PATA_SAMSUNG_CF
 	tristate "Samsung SoC PATA support"
-	depends on SAMSUNG_DEV_IDE
+	depends on SAMSUNG_DEV_IDE || COMPILE_TEST
 	select PATA_TIMINGS
 	help
 	  This option enables basic support for Samsung's S3C/S5P board
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 19/21] ata: sata_fsl: fix scsi host initialization
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (17 preceding siblings ...)
  2022-01-04  9:05 ` [PATCH 18/21] ata: pata_samsung_cf: " Damien Le Moal
@ 2022-01-04  9:05 ` Damien Le Moal
  2022-01-04  9:05 ` [PATCH 20/21] ata: ahci_xgene: use correct type for port mmio address Damien Le Moal
  2022-01-04  9:05 ` [PATCH 21/21] ata: ahci_xgene: Fix id array access in xgene_ahci_read_id() Damien Le Moal
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:05 UTC (permalink / raw)
  To: linux-ide

When compiling with W=1, the sata_fsl driver compilation throws the
warning:

drivers/ata/sata_fsl.c:1385:22: error: initialized field overwritten
[-Werror=override-init]
 1385 |         .can_queue = SATA_FSL_QUEUE_DEPTH,

This is due to the driver scsi host template initialization overwriting
the can_queue field that is already set using the ATA_NCQ_SHT()
initializer macro, resulting in the same field being initialized twice
in the host template declaration.

To remove this warning, introduce the ATA_SUBBASE_SHT_QD() and
ATA_NCQ_SHT_QD() initialization macros to allow specifying a queue depth
different from the default ATA_DEF_QUEUE using an additional argument to
the macro.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/sata_fsl.c |  3 +--
 include/linux/libata.h | 11 +++++++++++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 142e65d5efc7..101d4dd79f62 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1380,8 +1380,7 @@ static void sata_fsl_host_stop(struct ata_host *host)
  * scsi mid-layer and libata interface structures
  */
 static struct scsi_host_template sata_fsl_sht = {
-	ATA_NCQ_SHT("sata_fsl"),
-	.can_queue = SATA_FSL_QUEUE_DEPTH,
+	ATA_NCQ_SHT_QD("sata_fsl", SATA_FSL_QUEUE_DEPTH),
 	.sg_tablesize = SATA_FSL_MAX_PRD_USABLE,
 	.dma_boundary = ATA_DMA_BOUNDARY,
 };
diff --git a/include/linux/libata.h b/include/linux/libata.h
index ab2d404cde08..cafe360ab3cd 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1385,6 +1385,12 @@ extern const struct attribute_group *ata_common_sdev_groups[];
 	.tag_alloc_policy	= BLK_TAG_ALLOC_RR,		\
 	.slave_configure	= ata_scsi_slave_config
 
+#define ATA_SUBBASE_SHT_QD(drv_name, drv_qd)			\
+	__ATA_BASE_SHT(drv_name),				\
+	.can_queue		= drv_qd,			\
+	.tag_alloc_policy	= BLK_TAG_ALLOC_RR,		\
+	.slave_configure	= ata_scsi_slave_config
+
 #define ATA_BASE_SHT(drv_name)					\
 	ATA_SUBBASE_SHT(drv_name),				\
 	.sdev_groups		= ata_common_sdev_groups
@@ -1396,6 +1402,11 @@ extern const struct attribute_group *ata_ncq_sdev_groups[];
 	ATA_SUBBASE_SHT(drv_name),				\
 	.sdev_groups		= ata_ncq_sdev_groups,		\
 	.change_queue_depth	= ata_scsi_change_queue_depth
+
+#define ATA_NCQ_SHT_QD(drv_name, drv_qd)			\
+	ATA_SUBBASE_SHT_QD(drv_name, drv_qd),			\
+	.sdev_groups		= ata_ncq_sdev_groups,		\
+	.change_queue_depth	= ata_scsi_change_queue_depth
 #endif
 
 /*
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 20/21] ata: ahci_xgene: use correct type for port mmio address
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (18 preceding siblings ...)
  2022-01-04  9:05 ` [PATCH 19/21] ata: sata_fsl: fix scsi host initialization Damien Le Moal
@ 2022-01-04  9:05 ` Damien Le Moal
  2022-01-04  9:05 ` [PATCH 21/21] ata: ahci_xgene: Fix id array access in xgene_ahci_read_id() Damien Le Moal
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:05 UTC (permalink / raw)
  To: linux-ide

Sparse complains about an incorrect type for port_mmio pointer
variables:

drivers/ata/ahci_xgene.c:196:41: warning: incorrect type in initializer
(different address spaces)
drivers/ata/ahci_xgene.c:196:41:    expected void *port_mmio
drivers/ata/ahci_xgene.c:196:41:    got void [noderef] __iomem *

Fix this by declaring port_mmio as "void __iomem *" instead of "void *".

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/ahci_xgene.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 4d8a186ec12a..68ec7e9430b2 100644
--- a/drivers/ata/ahci_xgene.c
+++ b/drivers/ata/ahci_xgene.c
@@ -193,7 +193,7 @@ static unsigned int xgene_ahci_qc_issue(struct ata_queued_cmd *qc)
 	struct xgene_ahci_context *ctx = hpriv->plat_data;
 	int rc = 0;
 	u32 port_fbs;
-	void *port_mmio = ahci_port_base(ap);
+	void __iomem *port_mmio = ahci_port_base(ap);
 
 	/*
 	 * Write the pmp value to PxFBS.DEV
@@ -454,7 +454,7 @@ static int xgene_ahci_pmp_softreset(struct ata_link *link, unsigned int *class,
 	int pmp = sata_srst_pmp(link);
 	struct ata_port *ap = link->ap;
 	u32 rc;
-	void *port_mmio = ahci_port_base(ap);
+	void __iomem *port_mmio = ahci_port_base(ap);
 	u32 port_fbs;
 
 	/*
@@ -499,7 +499,7 @@ static int xgene_ahci_softreset(struct ata_link *link, unsigned int *class,
 	struct ata_port *ap = link->ap;
 	struct ahci_host_priv *hpriv = ap->host->private_data;
 	struct xgene_ahci_context *ctx = hpriv->plat_data;
-	void *port_mmio = ahci_port_base(ap);
+	void __iomem *port_mmio = ahci_port_base(ap);
 	u32 port_fbs;
 	u32 port_fbs_save;
 	u32 retry = 1;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 21/21] ata: ahci_xgene: Fix id array access in xgene_ahci_read_id()
  2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
                   ` (19 preceding siblings ...)
  2022-01-04  9:05 ` [PATCH 20/21] ata: ahci_xgene: use correct type for port mmio address Damien Le Moal
@ 2022-01-04  9:05 ` Damien Le Moal
  20 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-04  9:05 UTC (permalink / raw)
  To: linux-ide

ATA IDENTIFY command returns an array of le16 words. Accessing it as a
u16 array triggers the following sparse warning:

drivers/ata/ahci_xgene.c:262:33: warning: invalid assignment: &=
drivers/ata/ahci_xgene.c:262:33:    left side has type unsigned short
drivers/ata/ahci_xgene.c:262:33:    right side has type restricted __le16

Use a local variable to explicitly cast the id array to __le16 to avoid
this warning.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/ahci_xgene.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 68ec7e9430b2..d5075d0f8cb1 100644
--- a/drivers/ata/ahci_xgene.c
+++ b/drivers/ata/ahci_xgene.c
@@ -239,6 +239,7 @@ static bool xgene_ahci_is_memram_inited(struct xgene_ahci_context *ctx)
 static unsigned int xgene_ahci_read_id(struct ata_device *dev,
 				       struct ata_taskfile *tf, u16 *id)
 {
+	__le16 *__id = (__le16 *)id;
 	u32 err_mask;
 
 	err_mask = ata_do_dev_read_id(dev, tf, id);
@@ -259,7 +260,7 @@ static unsigned int xgene_ahci_read_id(struct ata_device *dev,
 	 *
 	 * Clear reserved bit 8 (DEVSLP bit) as we don't support DEVSLP
 	 */
-	id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));
+	__id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));
 
 	return 0;
 }
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
end of thread, other threads:[~2022-01-04  9:05 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04  9:04 [PATCH 00/21] Improve compile test coverage Damien Le Moal
2022-01-04  9:04 ` [PATCH 01/21] ata: sata_fsl: add compile test support Damien Le Moal
2022-01-04  9:04 ` [PATCH 02/21] ata: ahci_brcm: " Damien Le Moal
2022-01-04  9:04 ` [PATCH 03/21] ata: ahci_da850: " Damien Le Moal
2022-01-04  9:04 ` [PATCH 04/21] ata: ahci_dm816: " Damien Le Moal
2022-01-04  9:04 ` [PATCH 05/21] ata: ahci_st: " Damien Le Moal
2022-01-04  9:04 ` [PATCH 06/21] ata: ahci_mtk: " Damien Le Moal
2022-01-04  9:04 ` [PATCH 07/21] ata: ahci_mvebu: " Damien Le Moal
2022-01-04  9:04 ` [PATCH 08/21] ata: ahci_sunxi: " Damien Le Moal
2022-01-04  9:04 ` [PATCH 09/21] ata: ahci_tegra: " Damien Le Moal
2022-01-04  9:04 ` [PATCH 10/21] ata: ahci_xgene: " Damien Le Moal
2022-01-04  9:04 ` [PATCH 11/21] ata: ahci_seattle: " Damien Le Moal
2022-01-04  9:04 ` [PATCH 12/21] ata: pata_bk3710: " Damien Le Moal
2022-01-04  9:05 ` [PATCH 13/21] ata: pata_cs5535: " Damien Le Moal
2022-01-04  9:05 ` [PATCH 14/21] ata: pata_ftide010: " Damien Le Moal
2022-01-04  9:05 ` [PATCH 15/21] ata: pata_imx: " Damien Le Moal
2022-01-04  9:05 ` [PATCH 16/21] ata: pata_pxa: " Damien Le Moal
2022-01-04  9:05 ` [PATCH 17/21] ata: pata_legacy: " Damien Le Moal
2022-01-04  9:05 ` [PATCH 18/21] ata: pata_samsung_cf: " Damien Le Moal
2022-01-04  9:05 ` [PATCH 19/21] ata: sata_fsl: fix scsi host initialization Damien Le Moal
2022-01-04  9:05 ` [PATCH 20/21] ata: ahci_xgene: use correct type for port mmio address Damien Le Moal
2022-01-04  9:05 ` [PATCH 21/21] ata: ahci_xgene: Fix id array access in xgene_ahci_read_id() Damien Le Moal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.