From: Christoph Hellwig <hch@lst.de>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] block: remove dead queue_dma_alignment branch from bio_map_user_iov()
Date: Tue, 4 Jan 2022 13:47:24 +0100 [thread overview]
Message-ID: <20220104124724.GA21670@lst.de> (raw)
In-Reply-To: <20220104120158.20177-1-lukas.bulwahn@gmail.com>
On Tue, Jan 04, 2022 at 01:01:58PM +0100, Lukas Bulwahn wrote:
> If queue_dma_alignment(rq->q), then blk_rq_map_user_iov() will call
> bio_copy_user_iov() and not bio_map_user_iov(). So, bio_map_user_iov() does
> not need to handle the queue_dma_alignment(rq->q) case in any special way.
>
> Remove this dead branch from bio_map_user_iov().
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2022-01-04 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 12:01 [PATCH] block: remove dead queue_dma_alignment branch from bio_map_user_iov() Lukas Bulwahn
2022-01-04 12:47 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220104124724.GA21670@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.