All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Lobakin <alexandr.lobakin@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Alexander Lobakin <alexandr.lobakin@intel.com>,
	Christoph Hellwig <hch@infradead.org>,
	jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
	davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] intel: Simplify DMA setting
Date: Tue,  4 Jan 2022 14:29:36 +0100	[thread overview]
Message-ID: <20220104132936.252202-1-alexandr.lobakin@intel.com> (raw)
In-Reply-To: <c7a34d0096eb4ba98dd9ce5b64ba079126cab708.1641255235.git.christophe.jaillet@wanadoo.fr>

From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Tue, 4 Jan 2022 01:15:20 +0100

> As stated in [1], dma_set_mask() with a 64-bit mask will never fail if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
> 
> Simplify code and remove some dead code accordingly.
> 
> [1]: https://lkml.org/lkml/2021/6/7/398
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c    | 22 ++++++-------------
>  drivers/net/ethernet/intel/i40e/i40e_main.c   |  9 +++-----
>  drivers/net/ethernet/intel/iavf/iavf_main.c   |  9 +++-----
>  drivers/net/ethernet/intel/ice/ice_main.c     |  2 --
>  drivers/net/ethernet/intel/ixgb/ixgb_main.c   | 19 +++++-----------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 20 ++++++-----------
>  .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 20 +++++------------
>  7 files changed, 31 insertions(+), 70 deletions(-)

I like it, thanks!

Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>

Tony might ask to split it into per-driver patches tho, will see.

--- 8< ---

Al

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Lobakin <alexandr.lobakin@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] intel: Simplify DMA setting
Date: Tue,  4 Jan 2022 14:29:36 +0100	[thread overview]
Message-ID: <20220104132936.252202-1-alexandr.lobakin@intel.com> (raw)
In-Reply-To: <c7a34d0096eb4ba98dd9ce5b64ba079126cab708.1641255235.git.christophe.jaillet@wanadoo.fr>

From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Tue, 4 Jan 2022 01:15:20 +0100

> As stated in [1], dma_set_mask() with a 64-bit mask will never fail if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
> 
> Simplify code and remove some dead code accordingly.
> 
> [1]: https://lkml.org/lkml/2021/6/7/398
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c    | 22 ++++++-------------
>  drivers/net/ethernet/intel/i40e/i40e_main.c   |  9 +++-----
>  drivers/net/ethernet/intel/iavf/iavf_main.c   |  9 +++-----
>  drivers/net/ethernet/intel/ice/ice_main.c     |  2 --
>  drivers/net/ethernet/intel/ixgb/ixgb_main.c   | 19 +++++-----------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 20 ++++++-----------
>  .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 20 +++++------------
>  7 files changed, 31 insertions(+), 70 deletions(-)

I like it, thanks!

Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>

Tony might ask to split it into per-driver patches tho, will see.

--- 8< ---

Al

  parent reply	other threads:[~2022-01-04 13:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04  0:15 [PATCH] intel: Simplify DMA setting Christophe JAILLET
2022-01-04  0:15 ` [Intel-wired-lan] " Christophe JAILLET
2022-01-04  7:53 ` Christoph Hellwig
2022-01-04  7:53   ` [Intel-wired-lan] " Christoph Hellwig
2022-01-04 13:29 ` Alexander Lobakin [this message]
2022-01-04 13:29   ` Alexander Lobakin
2022-01-04 21:56   ` Nguyen, Anthony L
2022-01-04 21:56     ` Nguyen, Anthony L
2022-01-05  6:31     ` Christophe JAILLET
2022-01-05  6:31       ` Christophe JAILLET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220104132936.252202-1-alexandr.lobakin@intel.com \
    --to=alexandr.lobakin@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=davem@davemloft.net \
    --cc=hch@infradead.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.