From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84896C43219 for ; Tue, 4 Jan 2022 15:38:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234948AbiADPic (ORCPT ); Tue, 4 Jan 2022 10:38:32 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:36470 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234911AbiADPi1 (ORCPT ); Tue, 4 Jan 2022 10:38:27 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0DF0A614CF; Tue, 4 Jan 2022 15:38:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B41E7C36AE9; Tue, 4 Jan 2022 15:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641310706; bh=D10rA3MjwxR7qTzv97luAxovzVKA6suYoqpXAFLKS9k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OzpgEAElAyWzz/0nZBUIsCwel/q7ZhFrboYFoIwxEBG1KcxMn9yKT8fho2XQuWHwx pXR6qU4doQhumTzzA5CntyeowzznY73QsLxrxvpf3r6zDAQnYK8xf62hwzvrtIGRjE +kdl/z3udLQxOP1hupaWtVIs2hyRbtzCGtiPr4pz9+axBiCkCsWSimwHyGjtbhdmdb F46aJ+ZGMIB9lsfEy+Ub0pcyEYLFjZO6zXUxWWVc9khmVSOmRRCwC6RV8a8B4kJLpo gYeW3/PDnOvX/B8lyIwRzgjyoLdwRdU5wga8xfMpmt34b/gXXLWug8n+DLjWTxzeu4 vRSEhEIbGS76Q== Received: by pali.im (Postfix) id ABA8F284E; Tue, 4 Jan 2022 16:38:24 +0100 (CET) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Thomas Petazzoni , Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , =?UTF-8?q?Marek=20Beh=C3=BAn?= Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/11] PCI: pci-bridge-emul: Rename PCI_BRIDGE_EMUL_NO_PREFETCHABLE_BAR to PCI_BRIDGE_EMUL_NO_PREFMEM_FORWARD Date: Tue, 4 Jan 2022 16:35:21 +0100 Message-Id: <20220104153529.31647-4-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220104153529.31647-1-pali@kernel.org> References: <20211221141455.30011-1-pali@kernel.org> <20220104153529.31647-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This flag describe whether PCI bridge supports forwarding of prefetchable memory requests in given range between primary and secondary buses. It does not specify if bridge has support for prefetchable memory BAR (moreover this pci-bridge-emul.c driver does not provide support for BARs). So change name of this flag to be less misleading and add comment. Signed-off-by: Pali Rohár --- Changes in v2: * Add comment into code. --- drivers/pci/controller/pci-mvebu.c | 2 +- drivers/pci/pci-bridge-emul.c | 2 +- drivers/pci/pci-bridge-emul.h | 6 +++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c index 2ecc1ab12249..2e10ade660a1 100644 --- a/drivers/pci/controller/pci-mvebu.c +++ b/drivers/pci/controller/pci-mvebu.c @@ -747,7 +747,7 @@ static int mvebu_pci_bridge_emul_init(struct mvebu_pcie_port *port) bridge->data = port; bridge->ops = &mvebu_pci_bridge_emul_ops; - return pci_bridge_emul_init(bridge, PCI_BRIDGE_EMUL_NO_PREFETCHABLE_BAR); + return pci_bridge_emul_init(bridge, PCI_BRIDGE_EMUL_NO_PREFMEM_FORWARD); } static inline struct mvebu_pcie *sys_to_pcie(struct pci_sys_data *sys) diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c index 79b947528455..432b1bec2e22 100644 --- a/drivers/pci/pci-bridge-emul.c +++ b/drivers/pci/pci-bridge-emul.c @@ -373,7 +373,7 @@ int pci_bridge_emul_init(struct pci_bridge_emul *bridge, ~(BIT(10) << 16); } - if (flags & PCI_BRIDGE_EMUL_NO_PREFETCHABLE_BAR) { + if (flags & PCI_BRIDGE_EMUL_NO_PREFMEM_FORWARD) { bridge->pci_regs_behavior[PCI_PREF_MEMORY_BASE / 4].ro = ~0; bridge->pci_regs_behavior[PCI_PREF_MEMORY_BASE / 4].rw = 0; } diff --git a/drivers/pci/pci-bridge-emul.h b/drivers/pci/pci-bridge-emul.h index 0690b6369755..087b5fa01bcf 100644 --- a/drivers/pci/pci-bridge-emul.h +++ b/drivers/pci/pci-bridge-emul.h @@ -120,7 +120,11 @@ struct pci_bridge_emul { }; enum { - PCI_BRIDGE_EMUL_NO_PREFETCHABLE_BAR = BIT(0), + /* + * PCI bridge does not support forwarding of prefetchable memory + * requests between primary and secondary buses. + */ + PCI_BRIDGE_EMUL_NO_PREFMEM_FORWARD = BIT(0), }; int pci_bridge_emul_init(struct pci_bridge_emul *bridge, -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62430C433EF for ; Tue, 4 Jan 2022 15:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m9MBZ0Stbs+IBGZOWWB1iDZ2LTMIf+Qhz08bpeAVOmc=; b=mvDD7rm4TcDdGJ 1XHYvSriGkPH2pO336w7PD+lnu3ybm2HZHsa0VXfB3PO0hd8ERTdiQqK6fKwZ8WcLibxCiGRAe5GD hEBtYpgmDlVmtOCoGG3duUsAmvQIWJTa5CKIOfpfh6EHbrilH32jzuuHEp7/q2APxE87SjNuPNCS9 nZhICo06FViQEXbQWIeJsLyXpc3ZD+04mdFQPupbeeIK6jOWabVONJrKjKKSNasTbVjqbhtl9GMHz 9aSTNEYTxHxXZRpxtW09/LknIdpFTsxdRTdrUmtww+SdPE6mWp/KvsRzjgZwrpkshySAncQZ+q+OT d2d7VtTdA1vQt2vfywwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4ltw-00By2J-Lq; Tue, 04 Jan 2022 15:39:04 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4ltM-00BxlF-4K for linux-arm-kernel@lists.infradead.org; Tue, 04 Jan 2022 15:38:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0DF5B614D3; Tue, 4 Jan 2022 15:38:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B41E7C36AE9; Tue, 4 Jan 2022 15:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641310706; bh=D10rA3MjwxR7qTzv97luAxovzVKA6suYoqpXAFLKS9k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OzpgEAElAyWzz/0nZBUIsCwel/q7ZhFrboYFoIwxEBG1KcxMn9yKT8fho2XQuWHwx pXR6qU4doQhumTzzA5CntyeowzznY73QsLxrxvpf3r6zDAQnYK8xf62hwzvrtIGRjE +kdl/z3udLQxOP1hupaWtVIs2hyRbtzCGtiPr4pz9+axBiCkCsWSimwHyGjtbhdmdb F46aJ+ZGMIB9lsfEy+Ub0pcyEYLFjZO6zXUxWWVc9khmVSOmRRCwC6RV8a8B4kJLpo gYeW3/PDnOvX/B8lyIwRzgjyoLdwRdU5wga8xfMpmt34b/gXXLWug8n+DLjWTxzeu4 vRSEhEIbGS76Q== Received: by pali.im (Postfix) id ABA8F284E; Tue, 4 Jan 2022 16:38:24 +0100 (CET) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Thomas Petazzoni , Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , =?UTF-8?q?Marek=20Beh=C3=BAn?= Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/11] PCI: pci-bridge-emul: Rename PCI_BRIDGE_EMUL_NO_PREFETCHABLE_BAR to PCI_BRIDGE_EMUL_NO_PREFMEM_FORWARD Date: Tue, 4 Jan 2022 16:35:21 +0100 Message-Id: <20220104153529.31647-4-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220104153529.31647-1-pali@kernel.org> References: <20211221141455.30011-1-pali@kernel.org> <20220104153529.31647-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_073828_273260_FC3FB950 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhpcyBmbGFnIGRlc2NyaWJlIHdoZXRoZXIgUENJIGJyaWRnZSBzdXBwb3J0cyBmb3J3YXJkaW5n IG9mIHByZWZldGNoYWJsZQptZW1vcnkgcmVxdWVzdHMgaW4gZ2l2ZW4gcmFuZ2UgYmV0d2VlbiBw cmltYXJ5IGFuZCBzZWNvbmRhcnkgYnVzZXMuIEl0IGRvZXMKbm90IHNwZWNpZnkgaWYgYnJpZGdl IGhhcyBzdXBwb3J0IGZvciBwcmVmZXRjaGFibGUgbWVtb3J5IEJBUiAobW9yZW92ZXIKdGhpcyBw Y2ktYnJpZGdlLWVtdWwuYyBkcml2ZXIgZG9lcyBub3QgcHJvdmlkZSBzdXBwb3J0IGZvciBCQVJz KS4KClNvIGNoYW5nZSBuYW1lIG9mIHRoaXMgZmxhZyB0byBiZSBsZXNzIG1pc2xlYWRpbmcgYW5k IGFkZCBjb21tZW50LgoKU2lnbmVkLW9mZi1ieTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9y Zz4KCi0tLQpDaGFuZ2VzIGluIHYyOgoqIEFkZCBjb21tZW50IGludG8gY29kZS4KLS0tCiBkcml2 ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1tdmVidS5jIHwgMiArLQogZHJpdmVycy9wY2kvcGNpLWJy aWRnZS1lbXVsLmMgICAgICB8IDIgKy0KIGRyaXZlcnMvcGNpL3BjaS1icmlkZ2UtZW11bC5oICAg ICAgfCA2ICsrKysrLQogMyBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktbXZlYnUuYyBi L2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLW12ZWJ1LmMKaW5kZXggMmVjYzFhYjEyMjQ5Li4y ZTEwYWRlNjYwYTEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLW12ZWJ1 LmMKKysrIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktbXZlYnUuYwpAQCAtNzQ3LDcgKzc0 Nyw3IEBAIHN0YXRpYyBpbnQgbXZlYnVfcGNpX2JyaWRnZV9lbXVsX2luaXQoc3RydWN0IG12ZWJ1 X3BjaWVfcG9ydCAqcG9ydCkKIAlicmlkZ2UtPmRhdGEgPSBwb3J0OwogCWJyaWRnZS0+b3BzID0g Jm12ZWJ1X3BjaV9icmlkZ2VfZW11bF9vcHM7CiAKLQlyZXR1cm4gcGNpX2JyaWRnZV9lbXVsX2lu aXQoYnJpZGdlLCBQQ0lfQlJJREdFX0VNVUxfTk9fUFJFRkVUQ0hBQkxFX0JBUik7CisJcmV0dXJu IHBjaV9icmlkZ2VfZW11bF9pbml0KGJyaWRnZSwgUENJX0JSSURHRV9FTVVMX05PX1BSRUZNRU1f Rk9SV0FSRCk7CiB9CiAKIHN0YXRpYyBpbmxpbmUgc3RydWN0IG12ZWJ1X3BjaWUgKnN5c190b19w Y2llKHN0cnVjdCBwY2lfc3lzX2RhdGEgKnN5cykKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL3Bj aS1icmlkZ2UtZW11bC5jIGIvZHJpdmVycy9wY2kvcGNpLWJyaWRnZS1lbXVsLmMKaW5kZXggNzli OTQ3NTI4NDU1Li40MzJiMWJlYzJlMjIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL3BjaS1icmlk Z2UtZW11bC5jCisrKyBiL2RyaXZlcnMvcGNpL3BjaS1icmlkZ2UtZW11bC5jCkBAIC0zNzMsNyAr MzczLDcgQEAgaW50IHBjaV9icmlkZ2VfZW11bF9pbml0KHN0cnVjdCBwY2lfYnJpZGdlX2VtdWwg KmJyaWRnZSwKIAkJCX4oQklUKDEwKSA8PCAxNik7CiAJfQogCi0JaWYgKGZsYWdzICYgUENJX0JS SURHRV9FTVVMX05PX1BSRUZFVENIQUJMRV9CQVIpIHsKKwlpZiAoZmxhZ3MgJiBQQ0lfQlJJREdF X0VNVUxfTk9fUFJFRk1FTV9GT1JXQVJEKSB7CiAJCWJyaWRnZS0+cGNpX3JlZ3NfYmVoYXZpb3Jb UENJX1BSRUZfTUVNT1JZX0JBU0UgLyA0XS5ybyA9IH4wOwogCQlicmlkZ2UtPnBjaV9yZWdzX2Jl aGF2aW9yW1BDSV9QUkVGX01FTU9SWV9CQVNFIC8gNF0ucncgPSAwOwogCX0KZGlmZiAtLWdpdCBh L2RyaXZlcnMvcGNpL3BjaS1icmlkZ2UtZW11bC5oIGIvZHJpdmVycy9wY2kvcGNpLWJyaWRnZS1l bXVsLmgKaW5kZXggMDY5MGI2MzY5NzU1Li4wODdiNWZhMDFiY2YgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvcGNpL3BjaS1icmlkZ2UtZW11bC5oCisrKyBiL2RyaXZlcnMvcGNpL3BjaS1icmlkZ2UtZW11 bC5oCkBAIC0xMjAsNyArMTIwLDExIEBAIHN0cnVjdCBwY2lfYnJpZGdlX2VtdWwgewogfTsKIAog ZW51bSB7Ci0JUENJX0JSSURHRV9FTVVMX05PX1BSRUZFVENIQUJMRV9CQVIgPSBCSVQoMCksCisJ LyoKKwkgKiBQQ0kgYnJpZGdlIGRvZXMgbm90IHN1cHBvcnQgZm9yd2FyZGluZyBvZiBwcmVmZXRj aGFibGUgbWVtb3J5CisJICogcmVxdWVzdHMgYmV0d2VlbiBwcmltYXJ5IGFuZCBzZWNvbmRhcnkg YnVzZXMuCisJICovCisJUENJX0JSSURHRV9FTVVMX05PX1BSRUZNRU1fRk9SV0FSRCA9IEJJVCgw KSwKIH07CiAKIGludCBwY2lfYnJpZGdlX2VtdWxfaW5pdChzdHJ1Y3QgcGNpX2JyaWRnZV9lbXVs ICpicmlkZ2UsCi0tIAoyLjIwLjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==