All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel.thompson@linaro.org>
To: "Christian Löhle" <CLoehle@hyperstone.com>
Cc: "jason.wessel@windriver.com" <jason.wessel@windriver.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dianders@chromium.org" <dianders@chromium.org>,
	"corbet@lwn.net" <corbet@lwn.net>
Subject: Re: [PATCH] Documentation: kgdb: Replace deprecated remotebaud
Date: Tue, 4 Jan 2022 17:27:01 +0000	[thread overview]
Message-ID: <20220104172701.7ychluvlcts4anab@maple.lan> (raw)
In-Reply-To: <13287b7914344c7995de27224cd2fa73@hyperstone.com>

On Tue, Jan 04, 2022 at 04:56:51PM +0000, Christian Löhle wrote:
> The gdb remotebaud to set baudrate has been replaced in favor of
> set serial baud many years ago.

I'd prefer to have a little more historical info in the patch header
so that anyone still running gdb-7.6 has a better shot at finding out
what is going on (some folks in the embedded world end up relying on
surprisingly old cross-toolsets).

In other words something more like:

  Using set remotebaud to set the baud rate was deprecated in
  gdb-7.7 and completely removed from the command parser in gdb-7.8
  (released in 2014). Adopt set serial baud instead.

Other than that the change looks good to me so with an improved
description containing the above versions and dates this can be:
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Thanks

Daniel.


> 
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
> ---
>  Documentation/dev-tools/kgdb.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
> index 43456244651a..7c90e111b364 100644
> --- a/Documentation/dev-tools/kgdb.rst
> +++ b/Documentation/dev-tools/kgdb.rst
> @@ -557,7 +557,7 @@ Connecting with gdb to a serial port
>     Example (using a directly connected port)::
> 
>             % gdb ./vmlinux
> -           (gdb) set remotebaud 115200
> +           (gdb) set serial baud 115200
>             (gdb) target remote /dev/ttyS0
> 
> 
> --
> 2.34.1
> Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
> Managing Director: Dr. Jan Peter Berns.
> Commercial register of local courts: Freiburg HRB381782
> 

  reply	other threads:[~2022-01-04 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 16:56 [PATCH] Documentation: kgdb: Replace deprecated remotebaud Christian Löhle
2022-01-04 17:27 ` Daniel Thompson [this message]
2022-01-05  9:58 ` [PATCHv2] " Christian Löhle
2022-01-05 10:52   ` Daniel Thompson
2022-01-06 22:28   ` Jonathan Corbet
2022-01-10  8:26     ` [PATCHv3] " Christian Löhle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220104172701.7ychluvlcts4anab@maple.lan \
    --to=daniel.thompson@linaro.org \
    --cc=CLoehle@hyperstone.com \
    --cc=corbet@lwn.net \
    --cc=dianders@chromium.org \
    --cc=jason.wessel@windriver.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.