All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Duskett <aduskett@gmail.com>
To: buildroot@buildroot.org
Cc: Adam Duskett <aduskett@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [Buildroot] [PATCH v2 0/1] Fix per-package builds with qt5 submodule packages
Date: Tue,  4 Jan 2022 09:48:57 -0800	[thread overview]
Message-ID: <20220104174858.2665848-1-aduskett@gmail.com> (raw)

Based off of Louis-Paul's earlier work[1] and And Yann Morin's feedback to a
different patch set[2], this simple fix adds a new pre-configure hook
method to pkg-generic.mk which searches for .pc,.cmake, and .pri files for any
line that has a PER_PACKAGE_DIR path and replaces it with the appropriate
PER_PACKAGE_DIR path for the package being compiled.

$(HOST_DIR) is used instead of $(STAGING_DIR) as that covers both host and
staging directories in one step.

IE: If building qt5svg:
buildroot/output/per-package/qt5base -> buildroot/output/per-package/qt5svg

Feedback is welcome!

Adam

1) https://lore.kernel.org/buildroot/a339f273-33f3-f232-eac4-6e50427abf6d@cordier.org/
2) https://patchwork.ozlabs.org/project/buildroot/patch/20200217212350.29750-21-anaumann@ultratronik.de/

Adam Duskett (1):
  package/pkg-generic.mk: fix absolute paths in per-package config files

 package/pkg-generic.mk | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

-- 
changes v1 -> v2
  - Drop patches 2 and 3 and combine them into a single macro in pkg-generic.mk
  - Move the PRE_CONFIGURE_HOOK to inner-generic-package so it actually runs
  - Rename FIXUP_PC_FILES_ABSOLUTE_PATHS to FIXUP_CONFIG_FILES_ABSOLUTE_PATHS
  - Use $(HOST_DIR) instead of $(STAGING_DIR) to cover both stagin and host
    directories in a single step.


2.33.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2022-01-04 17:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 17:48 Adam Duskett [this message]
2022-01-04 17:48 ` [Buildroot] [PATCH v2 1/1] package/pkg-generic.mk: fix absolute paths in per-package config files Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220104174858.2665848-1-aduskett@gmail.com \
    --to=aduskett@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.