All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] Config.in.legacy: fix removed bootlin riscv64 toolchains
Date: Tue, 4 Jan 2022 23:14:07 +0100	[thread overview]
Message-ID: <20220104221407.GC614810@scaer> (raw)
In-Reply-To: <20220104171128.956397-1-arnout@mind.be>

Arnout, All,

On 2022-01-04 18:11 +0100, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> commit b3c66481e1f1503fcbf193d0c780271e880ad500 replaced RISC-V LP64
> bootlin toolchains by RISC-V LP64D. However, Config.in.legacy was added
> for BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE, which never
> existed (the stable version was only added after the switch to LP64D).
> Conversely, BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE,
> which was removed, was not mentioned in Config.in.legacy.
> 
> Correct the symbol name and its comment in Config.in.legacy.

Thanks for spotting what I missed. How did you notice, so that I can add
that to my check-list?

> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  Config.in.legacy | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 5994d94487..e5349e58ac 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -153,8 +153,8 @@ config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_BLEEDING_EDGE
>  	  The RISC-V 64-bit LP64 Bootlin toolchains have been removed,
>  	  in favor of RISC-V 64-bit LP64D toolchains.
>  
> -config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE
> -	bool "Bootlin riscv64 glibc bleeding-edge toolchain removed"
> +config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE
> +	bool "Bootlin riscv64 musl bleeding-edge toolchain removed"
>  	select BR2_LEGACY
>  	help
>  	  The RISC-V 64-bit LP64 Bootlin toolchains have been removed,
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-04 22:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 17:11 [Buildroot] [PATCH] Config.in.legacy: fix removed bootlin riscv64 toolchains Arnout Vandecappelle (Essensium/Mind)
2022-01-04 22:14 ` Yann E. MORIN [this message]
2022-01-05  7:54 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220104221407.GC614810@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.