From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Guenter Roeck <groeck@google.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Benson Leung <bleung@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel@pengutronix.de
Subject: Re: [PATCH v2] platform/chrome: cros_ec: Make cros_ec_unregister() return return void
Date: Wed, 5 Jan 2022 00:19:08 +0100 [thread overview]
Message-ID: <20220104231908.tmcubfbywn5yywpt@pengutronix.de> (raw)
In-Reply-To: <CABXOdTcgbobZwVarxXt8J+MTB2v4fO5uq+wZWCTwWsg=4mQTzg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
Hello,
On Wed, Oct 20, 2021 at 05:54:24AM -0700, Guenter Roeck wrote:
> On Wed, Oct 20, 2021 at 12:17 AM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > Up to now cros_ec_unregister() returns zero unconditionally. Make it
> > return void instead which makes it easier to see in the callers that
> > there is no error to handle.
> >
> > Also the return value of i2c, platform and spi remove callbacks is
> > ignored anyway.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>
This patch is one of the very few ones that are still required to change
spi_driver::remove to return void.
It doesn't appear in next up to now. Who feels responsible to merge it?
If it's still possible to go in during the next merge window this would
be great. I guess we'll have to prepare an unmutable branch to change
struct spi_driver and the patch can also be included there.
Whatever works best for the involved maintainers ... I just have to know
your preferences.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-04 23:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 20:38 [PATCH] platform/chrome: cros_ec: Make cros_ec_unregister() return void Uwe Kleine-König
2021-10-19 21:31 ` Guenter Roeck
2021-10-20 7:17 ` [PATCH v2] platform/chrome: cros_ec: Make cros_ec_unregister() return " Uwe Kleine-König
2021-10-20 12:54 ` Guenter Roeck
2022-01-04 23:19 ` Uwe Kleine-König [this message]
2021-10-20 13:28 ` [PATCH] platform/chrome: cros_ec: Make cros_ec_unregister() " kernel test robot
2021-10-20 13:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220104231908.tmcubfbywn5yywpt@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.