From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B63DC433EF for ; Wed, 5 Jan 2022 08:53:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238672AbiAEIx3 (ORCPT ); Wed, 5 Jan 2022 03:53:29 -0500 Received: from smtp21.cstnet.cn ([159.226.251.21]:32798 "EHLO cstnet.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230087AbiAEIx2 (ORCPT ); Wed, 5 Jan 2022 03:53:28 -0500 Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-01 (Coremail) with SMTP id qwCowAAXHp50XNVh6ZzRBQ--.10901S2; Wed, 05 Jan 2022 16:53:08 +0800 (CST) From: Jiasheng Jiang To: mika.westerberg@linux.intel.com Cc: andreas.noever@gmail.com, michael.jamet@intel.com, YehezkelShB@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: Re: Re: [PATCH] thunderbolt: Check for null pointer after calling kmemdup Date: Wed, 5 Jan 2022 16:53:07 +0800 Message-Id: <20220105085307.2410653-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: qwCowAAXHp50XNVh6ZzRBQ--.10901S2 X-Coremail-Antispam: 1UD129KBjvdXoWrKF1xJw1rAF1kCrWxtF43ZFb_yoW3AwbEyr W8J3srGw4rZay8tFs0kr4UAry7XrW0g3srXw4xWF48uryY9rW7JrWq9rnxZr1fWay29Fy3 KryxJayjqw43XjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb48FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc2xSY4AK67AK6r43 MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJV W8JwCI42IY6xAIw20EY4v20xvaj40_Wr1j6rW3Jr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1l IxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUjNJ55UUUU U== X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 05, 2022 at 03:30:47PM +0800, Mika Westerberg wrote: > This is doing two things so I suggest sending two patches instead. Fine, I have already sent the patch for icm_handle_event() independently. > However, for the UUID part, I think it works fine if we get NULL (and I > think kmemdup() issues warning too). > > There are probably not needed either since the "fix" here is for pretty > rare case of running out of memory. I think there is not even a NULL > pointer dereference because UUID is optional. As for icm_icl_set_uuid(), I think the check for kmemdup() is needed. Because users need to know that icm_start() fails, or they will be puzzled why the uuid is unsetted. So at least it is a cleanup. if so, I would like to send patch for icm_icl_set_uuid() without fixes tag.