* [Buildroot] [PATCH] Config.in.legacy: fix removed bootlin riscv64 toolchains
@ 2022-01-04 17:11 Arnout Vandecappelle (Essensium/Mind)
2022-01-04 22:14 ` Yann E. MORIN
2022-01-05 7:54 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Arnout Vandecappelle (Essensium/Mind) @ 2022-01-04 17:11 UTC (permalink / raw)
To: buildroot
commit b3c66481e1f1503fcbf193d0c780271e880ad500 replaced RISC-V LP64
bootlin toolchains by RISC-V LP64D. However, Config.in.legacy was added
for BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE, which never
existed (the stable version was only added after the switch to LP64D).
Conversely, BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE,
which was removed, was not mentioned in Config.in.legacy.
Correct the symbol name and its comment in Config.in.legacy.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Config.in.legacy | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Config.in.legacy b/Config.in.legacy
index 5994d94487..e5349e58ac 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -153,8 +153,8 @@ config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_BLEEDING_EDGE
The RISC-V 64-bit LP64 Bootlin toolchains have been removed,
in favor of RISC-V 64-bit LP64D toolchains.
-config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE
- bool "Bootlin riscv64 glibc bleeding-edge toolchain removed"
+config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE
+ bool "Bootlin riscv64 musl bleeding-edge toolchain removed"
select BR2_LEGACY
help
The RISC-V 64-bit LP64 Bootlin toolchains have been removed,
--
2.31.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] Config.in.legacy: fix removed bootlin riscv64 toolchains
2022-01-04 17:11 [Buildroot] [PATCH] Config.in.legacy: fix removed bootlin riscv64 toolchains Arnout Vandecappelle (Essensium/Mind)
@ 2022-01-04 22:14 ` Yann E. MORIN
2022-01-05 7:54 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2022-01-04 22:14 UTC (permalink / raw)
To: Arnout Vandecappelle (Essensium/Mind); +Cc: buildroot
Arnout, All,
On 2022-01-04 18:11 +0100, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> commit b3c66481e1f1503fcbf193d0c780271e880ad500 replaced RISC-V LP64
> bootlin toolchains by RISC-V LP64D. However, Config.in.legacy was added
> for BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE, which never
> existed (the stable version was only added after the switch to LP64D).
> Conversely, BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE,
> which was removed, was not mentioned in Config.in.legacy.
>
> Correct the symbol name and its comment in Config.in.legacy.
Thanks for spotting what I missed. How did you notice, so that I can add
that to my check-list?
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Config.in.legacy | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 5994d94487..e5349e58ac 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -153,8 +153,8 @@ config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_BLEEDING_EDGE
> The RISC-V 64-bit LP64 Bootlin toolchains have been removed,
> in favor of RISC-V 64-bit LP64D toolchains.
>
> -config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE
> - bool "Bootlin riscv64 glibc bleeding-edge toolchain removed"
> +config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE
> + bool "Bootlin riscv64 musl bleeding-edge toolchain removed"
> select BR2_LEGACY
> help
> The RISC-V 64-bit LP64 Bootlin toolchains have been removed,
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] Config.in.legacy: fix removed bootlin riscv64 toolchains
2022-01-04 17:11 [Buildroot] [PATCH] Config.in.legacy: fix removed bootlin riscv64 toolchains Arnout Vandecappelle (Essensium/Mind)
2022-01-04 22:14 ` Yann E. MORIN
@ 2022-01-05 7:54 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2022-01-05 7:54 UTC (permalink / raw)
To: Arnout Vandecappelle (Essensium/Mind); +Cc: buildroot
Hello Arnout,
On Tue, 4 Jan 2022 18:11:28 +0100
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> wrote:
> commit b3c66481e1f1503fcbf193d0c780271e880ad500 replaced RISC-V LP64
> bootlin toolchains by RISC-V LP64D. However, Config.in.legacy was added
> for BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE, which never
> existed (the stable version was only added after the switch to LP64D).
> Conversely, BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE,
> which was removed, was not mentioned in Config.in.legacy.
>
> Correct the symbol name and its comment in Config.in.legacy.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> Config.in.legacy | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Too late, but:
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thanks for fixing this!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-05 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 17:11 [Buildroot] [PATCH] Config.in.legacy: fix removed bootlin riscv64 toolchains Arnout Vandecappelle (Essensium/Mind)
2022-01-04 22:14 ` Yann E. MORIN
2022-01-05 7:54 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.