From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Peter Geis" <pgwipeout@gmail.com>,
"Kever Yang" <Kever.yang@rock-chips.com>
Subject: Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver
Date: Wed, 5 Jan 2022 13:20:39 +0100 [thread overview]
Message-ID: <20220105122039.GU6003@pengutronix.de> (raw)
In-Reply-To: <a0942adc-52c1-811e-0de6-d0616266ce2d@rock-chips.com>
Hi Andy,
On Tue, Jan 04, 2022 at 07:07:23PM +0800, Andy Yan wrote:
>
>
> I thinks we should be very carefully about switch to regmap.
>
> Most of the registers are take effect by frame sync(that is you write the
> config done bit and when vsync interrupt come),
>
> Not only windows register, but also the SYS_CTRL, post processor(VP0/1/2),
> OVERLAY, hdr and so on.
That's why I marked these as nonvolatile, so that reading the registers
comes from the cache. I may have missed some registers, these could be
added when needed.
> > + ret = vop2_win_init(vop2);
> > + if (ret)
> > + return ret;
> Do you have a count about how much time the function vop2_win_init cost ?
No. Why does that matter?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Peter Geis" <pgwipeout@gmail.com>,
"Kever Yang" <Kever.yang@rock-chips.com>
Subject: Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver
Date: Wed, 5 Jan 2022 13:20:39 +0100 [thread overview]
Message-ID: <20220105122039.GU6003@pengutronix.de> (raw)
In-Reply-To: <a0942adc-52c1-811e-0de6-d0616266ce2d@rock-chips.com>
Hi Andy,
On Tue, Jan 04, 2022 at 07:07:23PM +0800, Andy Yan wrote:
>
>
> I thinks we should be very carefully about switch to regmap.
>
> Most of the registers are take effect by frame sync(that is you write the
> config done bit and when vsync interrupt come),
>
> Not only windows register, but also the SYS_CTRL, post processor(VP0/1/2),
> OVERLAY, hdr and so on.
That's why I marked these as nonvolatile, so that reading the registers
comes from the cache. I may have missed some registers, these could be
added when needed.
> > + ret = vop2_win_init(vop2);
> > + if (ret)
> > + return ret;
> Do you have a count about how much time the function vop2_win_init cost ?
No. Why does that matter?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: devicetree@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Sandy Huang <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org,
Kever Yang <Kever.yang@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Michael Riesch <michael.riesch@wolfvision.net>,
kernel@pengutronix.de, Peter Geis <pgwipeout@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver
Date: Wed, 5 Jan 2022 13:20:39 +0100 [thread overview]
Message-ID: <20220105122039.GU6003@pengutronix.de> (raw)
In-Reply-To: <a0942adc-52c1-811e-0de6-d0616266ce2d@rock-chips.com>
Hi Andy,
On Tue, Jan 04, 2022 at 07:07:23PM +0800, Andy Yan wrote:
>
>
> I thinks we should be very carefully about switch to regmap.
>
> Most of the registers are take effect by frame sync(that is you write the
> config done bit and when vsync interrupt come),
>
> Not only windows register, but also the SYS_CTRL, post processor(VP0/1/2),
> OVERLAY, hdr and so on.
That's why I marked these as nonvolatile, so that reading the registers
comes from the cache. I may have missed some registers, these could be
added when needed.
> > + ret = vop2_win_init(vop2);
> > + if (ret)
> > + return ret;
> Do you have a count about how much time the function vop2_win_init cost ?
No. Why does that matter?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Peter Geis" <pgwipeout@gmail.com>,
"Kever Yang" <Kever.yang@rock-chips.com>
Subject: Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver
Date: Wed, 5 Jan 2022 13:20:39 +0100 [thread overview]
Message-ID: <20220105122039.GU6003@pengutronix.de> (raw)
In-Reply-To: <a0942adc-52c1-811e-0de6-d0616266ce2d@rock-chips.com>
Hi Andy,
On Tue, Jan 04, 2022 at 07:07:23PM +0800, Andy Yan wrote:
>
>
> I thinks we should be very carefully about switch to regmap.
>
> Most of the registers are take effect by frame sync(that is you write the
> config done bit and when vsync interrupt come),
>
> Not only windows register, but also the SYS_CTRL, post processor(VP0/1/2),
> OVERLAY, hdr and so on.
That's why I marked these as nonvolatile, so that reading the registers
comes from the cache. I may have missed some registers, these could be
added when needed.
> > + ret = vop2_win_init(vop2);
> > + if (ret)
> > + return ret;
> Do you have a count about how much time the function vop2_win_init cost ?
No. Why does that matter?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-05 12:20 UTC|newest]
Thread overview: 189+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 11:06 [PATCH v3 00/22] drm/rockchip: RK356x VOP2 support Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 01/22] drm/rockchip: dw_hdmi: Do not leave clock enabled in error case Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 02/22] drm/rockchip: dw_hdmi: rename vpll clock to reference clock Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 03/22] drm/rockchip: dw_hdmi: add rk3568 support Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 04/22] drm/rockchip: dw_hdmi: add regulator support Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 05/22] drm/rockchip: dw_hdmi: Add support for hclk Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 06/22] dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 07/22] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-20 11:06 ` [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-21 14:31 ` Rob Herring
2021-12-21 14:31 ` Rob Herring
2021-12-21 14:31 ` Rob Herring
2021-12-21 14:31 ` Rob Herring
2021-12-22 10:47 ` Sascha Hauer
2021-12-22 10:47 ` Sascha Hauer
2021-12-22 10:47 ` Sascha Hauer
2021-12-22 10:47 ` Sascha Hauer
2021-12-22 13:52 ` Rob Herring
2021-12-22 13:52 ` Rob Herring
2021-12-22 13:52 ` Rob Herring
2021-12-22 13:52 ` Rob Herring
2021-12-22 19:39 ` Heiko Stübner
2021-12-22 19:39 ` Heiko Stübner
2021-12-22 19:39 ` Heiko Stübner
2021-12-22 19:39 ` Heiko Stübner
2021-12-22 19:44 ` Nicolas Frattaroli
2021-12-22 19:44 ` Nicolas Frattaroli
2021-12-22 19:44 ` Nicolas Frattaroli
2021-12-22 19:44 ` Nicolas Frattaroli
2021-12-22 19:56 ` Rob Herring
2021-12-22 19:56 ` Rob Herring
2021-12-22 19:56 ` Rob Herring
2021-12-22 19:56 ` Rob Herring
2021-12-20 11:06 ` [PATCH 09/22] dt-bindings: display: rockchip: dw-hdmi: Add regulator support Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-20 11:06 ` [PATCH 10/22] dt-bindings: display: rockchip: dw-hdmi: Add additional clock Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 11/22] dt-bindings: display: rockchip: Add binding for VOP2 Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-20 14:27 ` Rob Herring
2021-12-21 14:33 ` Rob Herring
2021-12-21 14:33 ` Rob Herring
2021-12-21 14:33 ` Rob Herring
2021-12-21 14:33 ` Rob Herring
2021-12-20 11:06 ` [PATCH 12/22] arm64: dts: rockchip: rk3399: reorder hmdi clocks Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 13/22] arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref' Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 14/22] arm64: dts: rockchip: rk356x: Add VOP2 nodes Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 15/22] arm64: dts: rockchip: rk356x: Add HDMI nodes Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 16/22] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 17/22] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 18/22] clk: rk3568: drop CLK_SET_RATE_PARENT from dclk_vop* Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 19/22] clk: rk3568: Add CLK_SET_RATE_PARENT to the HDMI reference clock Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 20/22] drm/encoder: Add of_graph port to struct drm_encoder Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-21 17:31 ` Heiko Stübner
2021-12-21 17:31 ` Heiko Stübner
2021-12-21 17:31 ` Heiko Stübner
2021-12-21 17:31 ` Heiko Stübner
2021-12-20 11:06 ` [PATCH 21/22] drm/rockchip: Make VOP driver optional Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` [PATCH 22/22] drm: rockchip: Add VOP2 driver Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 11:06 ` Sascha Hauer
2021-12-20 14:16 ` Nicolas Frattaroli
2021-12-20 14:16 ` Nicolas Frattaroli
2021-12-20 14:16 ` Nicolas Frattaroli
2021-12-20 14:16 ` Nicolas Frattaroli
2021-12-20 16:53 ` Nicolas Frattaroli
2021-12-20 16:53 ` Nicolas Frattaroli
2021-12-20 16:53 ` Nicolas Frattaroli
2021-12-20 16:53 ` Nicolas Frattaroli
2021-12-20 18:51 ` Sascha Hauer
2021-12-20 18:51 ` Sascha Hauer
2021-12-20 18:51 ` Sascha Hauer
2021-12-20 18:51 ` Sascha Hauer
2021-12-20 23:20 ` kernel test robot
2021-12-20 23:20 ` kernel test robot
2021-12-20 23:20 ` kernel test robot
2021-12-21 13:44 ` Nicolas Frattaroli
2021-12-21 13:44 ` Nicolas Frattaroli
2021-12-21 13:44 ` Nicolas Frattaroli
2021-12-21 13:44 ` Nicolas Frattaroli
2021-12-22 17:07 ` Nicolas Frattaroli
2021-12-22 17:07 ` Nicolas Frattaroli
2021-12-22 17:07 ` Nicolas Frattaroli
2021-12-22 17:07 ` Nicolas Frattaroli
2022-01-03 14:55 ` Sascha Hauer
2022-01-03 14:55 ` Sascha Hauer
2022-01-03 14:55 ` Sascha Hauer
2022-01-03 14:55 ` Sascha Hauer
2022-01-04 11:07 ` Andy Yan
2022-01-04 11:07 ` Andy Yan
2022-01-04 11:07 ` Andy Yan
2022-01-05 12:20 ` Sascha Hauer [this message]
2022-01-05 12:20 ` Sascha Hauer
2022-01-05 12:20 ` Sascha Hauer
2022-01-05 12:20 ` Sascha Hauer
2021-12-20 11:51 ` [PATCH v3 00/22] drm/rockchip: RK356x VOP2 support Nicolas Frattaroli
2021-12-20 11:51 ` Nicolas Frattaroli
2021-12-20 11:51 ` Nicolas Frattaroli
2021-12-20 11:51 ` Nicolas Frattaroli
2022-01-19 11:29 ` Piotr Oniszczuk
2022-01-19 11:29 ` Piotr Oniszczuk
2022-01-19 11:29 ` Piotr Oniszczuk
2022-01-19 11:29 ` Piotr Oniszczuk
2022-01-21 10:32 ` Sascha Hauer
2022-01-21 10:32 ` Sascha Hauer
2022-01-21 10:32 ` Sascha Hauer
2022-01-21 10:32 ` Sascha Hauer
2022-01-21 15:43 ` Piotr Oniszczuk
2022-01-21 15:43 ` Piotr Oniszczuk
2022-01-21 15:43 ` Piotr Oniszczuk
2022-01-21 15:43 ` Piotr Oniszczuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105122039.GU6003@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=Kever.yang@rock-chips.com \
--cc=andy.yan@rock-chips.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--subject='Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.