From: "Darrick J. Wong" <djwong@kernel.org>
To: Chandan Babu R <chandan.babu@oracle.com>
Cc: linux-xfs@vger.kernel.org, david@fromorbit.com
Subject: Re: [PATCH V4 08/16] xfs: Introduce XFS_FSOP_GEOM_FLAGS_NREXT64
Date: Wed, 5 Jan 2022 09:22:15 -0800 [thread overview]
Message-ID: <20220105172215.GI656707@magnolia> (raw)
In-Reply-To: <87y23u8fft.fsf@debian-BULLSEYE-live-builder-AMD64>
On Wed, Jan 05, 2022 at 07:14:55PM +0530, Chandan Babu R wrote:
> On 05 Jan 2022 at 05:35, Darrick J. Wong wrote:
> > On Tue, Dec 14, 2021 at 02:15:11PM +0530, Chandan Babu R wrote:
> >> XFS_FSOP_GEOM_FLAGS_NREXT64 indicates that the current filesystem instance
> >> supports 64-bit per-inode extent counters.
> >>
> >> Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
> >> ---
> >> fs/xfs/libxfs/xfs_fs.h | 1 +
> >> fs/xfs/libxfs/xfs_sb.c | 2 ++
> >> 2 files changed, 3 insertions(+)
> >>
> >> diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
> >> index c43877c8a279..42bc39501d81 100644
> >> --- a/fs/xfs/libxfs/xfs_fs.h
> >> +++ b/fs/xfs/libxfs/xfs_fs.h
> >> @@ -251,6 +251,7 @@ typedef struct xfs_fsop_resblks {
> >> #define XFS_FSOP_GEOM_FLAGS_REFLINK (1 << 20) /* files can share blocks */
> >> #define XFS_FSOP_GEOM_FLAGS_BIGTIME (1 << 21) /* 64-bit nsec timestamps */
> >> #define XFS_FSOP_GEOM_FLAGS_INOBTCNT (1 << 22) /* inobt btree counter */
> >> +#define XFS_FSOP_GEOM_FLAGS_NREXT64 (1 << 23) /* 64-bit extent counter */
> >>
> >> /*
> >> * Minimum and maximum sizes need for growth checks.
> >> diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
> >> index bd632389ae92..0c1add39177f 100644
> >> --- a/fs/xfs/libxfs/xfs_sb.c
> >> +++ b/fs/xfs/libxfs/xfs_sb.c
> >> @@ -1138,6 +1138,8 @@ xfs_fs_geometry(
> >> } else {
> >> geo->logsectsize = BBSIZE;
> >> }
> >> + if (xfs_has_nrext64(mp))
> >> + geo->flags |= XFS_FSOP_GEOM_FLAGS_NREXT64;
> >> geo->rtsectsize = sbp->sb_blocksize;
> >> geo->dirblocksize = xfs_dir2_dirblock_bytes(sbp);
> >>
> >> --
> >> 2.30.2
> >>
>
> I think you accidently missed typing your response to this patch?
Yep.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
>
> --
> chandan
next prev parent reply other threads:[~2022-01-05 17:22 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 8:45 [PATCH V4 00/16] xfs: Extend per-inode extent counters Chandan Babu R
2021-12-14 8:45 ` [PATCH V4 01/16] xfs: Move extent count limits to xfs_format.h Chandan Babu R
2022-01-04 23:28 ` Darrick J. Wong
2021-12-14 8:45 ` [PATCH V4 02/16] xfs: Introduce xfs_iext_max_nextents() helper Chandan Babu R
2022-01-04 23:30 ` Darrick J. Wong
2021-12-14 8:45 ` [PATCH V4 03/16] xfs: Use xfs_extnum_t instead of basic data types Chandan Babu R
2021-12-14 8:45 ` [PATCH V4 04/16] xfs: Introduce xfs_dfork_nextents() helper Chandan Babu R
2022-01-04 23:48 ` Darrick J. Wong
2021-12-14 8:45 ` [PATCH V4 05/16] xfs: Use basic types to define xfs_log_dinode's di_nextents and di_anextents Chandan Babu R
2022-01-04 23:50 ` Darrick J. Wong
2022-01-05 13:43 ` Chandan Babu R
2021-12-14 8:45 ` [PATCH V4 06/16] xfs: Promote xfs_extnum_t and xfs_aextnum_t to 64 and 32-bits respectively Chandan Babu R
2021-12-14 14:54 ` kernel test robot
2021-12-14 14:54 ` kernel test robot
2021-12-14 15:05 ` kernel test robot
2021-12-14 15:05 ` kernel test robot
2021-12-14 15:15 ` kernel test robot
2021-12-14 15:15 ` kernel test robot
2021-12-15 9:19 ` Chandan Babu R
2021-12-15 9:19 ` Chandan Babu R
2022-01-04 23:54 ` Darrick J. Wong
2022-01-04 23:54 ` Darrick J. Wong
2022-01-05 14:14 ` Chandan Babu R
2022-01-05 14:14 ` Chandan Babu R
2022-01-05 17:21 ` Darrick J. Wong
2022-01-05 17:21 ` Darrick J. Wong
2022-01-06 7:03 ` Chandan Babu R
2022-01-06 7:03 ` Chandan Babu R
2022-01-06 20:31 ` Darrick J. Wong
2022-01-06 20:31 ` Darrick J. Wong
2021-12-14 8:45 ` [PATCH V4 07/16] xfs: Introduce XFS_SB_FEAT_INCOMPAT_NREXT64 and associated per-fs feature bit Chandan Babu R
2022-01-05 0:03 ` Darrick J. Wong
2021-12-14 8:45 ` [PATCH V4 08/16] xfs: Introduce XFS_FSOP_GEOM_FLAGS_NREXT64 Chandan Babu R
2022-01-05 0:05 ` Darrick J. Wong
2022-01-05 13:44 ` Chandan Babu R
2022-01-05 17:22 ` Darrick J. Wong [this message]
2021-12-14 8:45 ` [PATCH V4 09/16] xfs: Introduce XFS_DIFLAG2_NREXT64 and associated helpers Chandan Babu R
2022-01-05 0:43 ` Darrick J. Wong
2021-12-14 8:45 ` [PATCH V4 10/16] xfs: Use xfs_rfsblock_t to count maximum blocks that can be used by BMBT Chandan Babu R
2021-12-14 18:15 ` kernel test robot
2021-12-14 18:15 ` kernel test robot
2021-12-14 8:45 ` [PATCH V4 11/16] xfs: Introduce macros to represent new maximum extent counts for data/attr forks Chandan Babu R
2022-01-05 0:42 ` Darrick J. Wong
2022-01-05 13:46 ` Chandan Babu R
2021-12-14 8:45 ` [PATCH V4 12/16] xfs: Introduce per-inode 64-bit extent counters Chandan Babu R
2022-01-05 1:04 ` Darrick J. Wong
2022-01-05 13:47 ` Chandan Babu R
2021-12-14 8:45 ` [PATCH V4 13/16] xfs: Conditionally upgrade existing inodes to use " Chandan Babu R
2022-01-05 0:18 ` Darrick J. Wong
2022-01-05 13:49 ` Chandan Babu R
2021-12-14 8:45 ` [PATCH V4 14/16] xfs: Enable bulkstat ioctl to support 64-bit per-inode " Chandan Babu R
2022-01-05 0:28 ` Darrick J. Wong
2022-01-05 13:50 ` Chandan Babu R
2021-12-14 8:45 ` [PATCH V4 15/16] xfs: Add XFS_SB_FEAT_INCOMPAT_NREXT64 to the list of supported flags Chandan Babu R
2022-01-05 0:47 ` Darrick J. Wong
2021-12-14 8:45 ` [PATCH V4 16/16] xfs: Define max extent length based on on-disk format definition Chandan Babu R
2022-01-05 0:47 ` Darrick J. Wong
2022-01-05 13:51 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105172215.GI656707@magnolia \
--to=djwong@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.