All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hugo Mills <hugo@carfax.org.uk>
To: Filipe Manana <fdmanana@kernel.org>,
	Chris Murphy <lists@colorremedies.com>,
	Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
	Josef Bacik <josef@toxicpanda.com>
Subject: Re: [bug] GNOME loses all settings following failure to resume from suspend
Date: Wed, 5 Jan 2022 21:53:59 +0000	[thread overview]
Message-ID: <20220105215359.GG14058@savella.carfax.org.uk> (raw)
In-Reply-To: <20220105213921.GF14058@savella.carfax.org.uk>

On Wed, Jan 05, 2022 at 09:39:21PM +0000, Hugo Mills wrote:
> On Wed, Jan 05, 2022 at 09:31:57PM +0000, Hugo Mills wrote:
> > On Wed, Jan 05, 2022 at 08:38:37PM +0000, Filipe Manana wrote:
> > > On Wed, Jan 5, 2022 at 6:34 PM Hugo Mills <hugo@carfax.org.uk> wrote:
> > > >
> > > >    Hi, Filipe,
> > > >
> > > > On Wed, Jan 05, 2022 at 06:04:38PM +0000, Filipe Manana wrote:
> > > > > I don't think I have a wiki account enabled, but I'll see if I get that
> > > > > updated soon.
> > > >
> > > >    If you can't (or don't want to), feel free to put the text you want
> > > > to replace it with here, and I'll update the wiki for you...
> > > 
> > > Hi Hugo,
> > > 
> > > That would be great.
> > > I don't have a concrete text, but as you are a native english speaker,
> > > a version from you would sound better :)
> > > 
> > > Perhaps just mention that as of kernel 3.17 (and maybe point to that
> > > commit too), the behaviour is no longer guaranteed, and we can end up
> > > getting a file of 0 bytes.
> > 
> >    I'd rather not reinforce the wrong usage with an example of it. :)
> > Better to document the correct usage...
> > 
> > > So an explicit fsync on the file is needed (just like ext4 and other
> > > filesystems).
> > 
> >    At what point in the process does the fsync need to be done?
> > Before/after/instead of the sync?
> 
>    Hmm. That doesn't make sense, of course (sorry, it's late, I've had
> a hard day). I'm guessing that the fsync needs to go after the write
> of the new data and before the rename. Is there any other constraint
> on what needs to be done to make this work safely?

   Right, I think I've got it. Ping me in the morning if it's not
correct.

   Hugo.

-- 
Hugo Mills             | Great films about cricket: Monster's No-Ball
hugo@... carfax.org.uk |
http://carfax.org.uk/  |
PGP: E2AB1DE4          |

  reply	other threads:[~2022-01-05 21:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05 17:34 [bug] GNOME loses all settings following failure to resume from suspend Chris Murphy
2022-01-05 18:04 ` Filipe Manana
2022-01-05 18:32   ` Filipe Manana
2022-01-05 18:34   ` Hugo Mills
2022-01-05 20:38     ` Filipe Manana
2022-01-05 21:31       ` Hugo Mills
2022-01-05 21:39         ` Hugo Mills
2022-01-05 21:53           ` Hugo Mills [this message]
2022-01-06  9:51             ` Filipe Manana
2022-01-06 10:20               ` Hugo Mills
2022-01-06 10:27                 ` Filipe Manana
2022-01-06 20:02                   ` Chris Murphy
2022-01-06 20:06                     ` Chris Murphy
2022-01-06 20:23                       ` Hugo Mills
2022-01-06 21:07                 ` Adam Borowski
2022-01-05 18:40   ` Chris Murphy
2022-01-05 20:32     ` Filipe Manana
2022-01-09 17:04   ` Remi Gauvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220105215359.GG14058@savella.carfax.org.uk \
    --to=hugo@carfax.org.uk \
    --cc=fdmanana@kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=lists@colorremedies.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.