From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41DCEC433EF for ; Thu, 6 Jan 2022 12:21:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 992CF830CA; Thu, 6 Jan 2022 13:21:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="R1LApwOO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 97E42834A3; Thu, 6 Jan 2022 13:21:04 +0100 (CET) Received: from mail.nic.cz (mail.nic.cz [217.31.204.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8EF81811BB for ; Thu, 6 Jan 2022 13:21:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPSA id 10640140FC8; Thu, 6 Jan 2022 13:21:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1641471661; bh=TiR3Ap1VMSmNlNhI4To1H1+fEZZMiN5GOuzmeB/0X3Q=; h=Date:From:To; b=R1LApwOO1ZiHjel6+plZ8m6kMzv9rsPDc3R0/aUZS7XEX4QyJ1I1Xm1TwwCeKaZsE aImBtK1jfVj+tIQLoP92MV6uiSfut0QM+exJoJl4j+VL9fpARRJILH8JDhBcxZHqDy Bl5ZkSj5sM7+EL46dtp6L5fr6a2YRTKFYpXM62jg= Date: Thu, 6 Jan 2022 13:21:00 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Simon Glass Cc: U-Boot Mailing List Subject: difference between fdtdec and fdt_support ? Message-ID: <20220106132100.56f55e02@thinkpad> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, I am a little confused. We have common/fdt_support.c and lib/fdtdec.c The second one implements for example fdtdec_get_is_enabled(), which I would rather expect in fdt_support by name fdt_node_is_available(), or something like that. Also fdtdec does a strange thing with compatible strings: it declares an enum for compatible strings and then a map which maps this enum values to compatible strings... Why not just use the compatible strings? What is the purpose of having two files implementing fdt stuff? Marek