* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
@ 2022-01-04 13:50 ` Robert Foss
0 siblings, 0 replies; 21+ messages in thread
From: Robert Foss @ 2022-01-04 13:50 UTC (permalink / raw)
To: Vinay Simha B N
Cc: Jiri Vanek, Jonas Karlman, David Airlie,
open list:DRM PANEL DRIVERS, Neil Armstrong, open list,
Jernej Skrabec, Zheng Bin, Andrzej Hajda, Laurent Pinchart
Jiri: Are you able to test this patch?
Vinay: Could you supply a R-b tag, if you feel that it is warranted?
On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote:
>
> Robert,
> I do not have the hardware to test this feature. Sorry for the late response.
>
> On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote:
>>
>> + Zhen & Vinay
>>
>> This patch looks good in itself, but I would like to see a tested by
>> tag. At the very least testing for regression in single-link LVDS but
>> ideally some third party verification of this patch.
>>
>> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote:
>> >
>> > Fixed wrong register shift for single/dual link LVDS output.
>> >
>> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
>> > ---
>> > drivers/gpu/drm/bridge/tc358775.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
>> > index 2272adcc5b4a..1d6ec1baeff2 100644
>> > --- a/drivers/gpu/drm/bridge/tc358775.c
>> > +++ b/drivers/gpu/drm/bridge/tc358775.c
>> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
>> > }
>> >
>> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002
>> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0
>> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1
>> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
>> > {
>> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
>> > --
>> > 2.30.2
>> >
>
>
>
> --
> regards,
> vinaysimha
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
2022-01-04 13:50 ` Robert Foss
(?)
@ 2022-01-04 14:29 ` Jiří Vaněk
2022-01-04 14:36 ` Robert Foss
2022-01-04 17:04 ` Vinay Simha B N
-1 siblings, 2 replies; 21+ messages in thread
From: Jiří Vaněk @ 2022-01-04 14:29 UTC (permalink / raw)
To: Robert Foss
Cc: Jonas Karlman, David Airlie, open list:DRM PANEL DRIVERS,
Neil Armstrong, open list, Jernej Skrabec, Zheng Bin,
Andrzej Hajda, Laurent Pinchart, Vinay Simha B N
[-- Attachment #1: Type: text/plain, Size: 2025 bytes --]
Actually, this patch is based on testing with a real HW with dual-link LVDS
display (full HD) and it also matches with a datasheet. Without this fix it
does not work at all.
út 4. 1. 2022 v 14:51 odesílatel Robert Foss <robert.foss@linaro.org>
napsal:
> Jiri: Are you able to test this patch?
>
> Vinay: Could you supply a R-b tag, if you feel that it is warranted?
>
> On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote:
> >
> > Robert,
> > I do not have the hardware to test this feature. Sorry for the late
> response.
> >
> > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org>
> wrote:
> >>
> >> + Zhen & Vinay
> >>
> >> This patch looks good in itself, but I would like to see a tested by
> >> tag. At the very least testing for regression in single-link LVDS but
> >> ideally some third party verification of this patch.
> >>
> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote:
> >> >
> >> > Fixed wrong register shift for single/dual link LVDS output.
> >> >
> >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
> >> > ---
> >> > drivers/gpu/drm/bridge/tc358775.c | 2 +-
> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c
> b/drivers/gpu/drm/bridge/tc358775.c
> >> > index 2272adcc5b4a..1d6ec1baeff2 100644
> >> > --- a/drivers/gpu/drm/bridge/tc358775.c
> >> > +++ b/drivers/gpu/drm/bridge/tc358775.c
> >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t
> val)
> >> > }
> >> >
> >> > #define TC358775_LVCFG_LVDLINK__MASK
> 0x00000002
> >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0
> >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1
> >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
> >> > {
> >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
> >> > --
> >> > 2.30.2
> >> >
> >
> >
> >
> > --
> > regards,
> > vinaysimha
>
[-- Attachment #2: Type: text/html, Size: 3044 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
2022-01-04 14:29 ` Jiří Vaněk
@ 2022-01-04 14:36 ` Robert Foss
2022-01-04 17:04 ` Vinay Simha B N
1 sibling, 0 replies; 21+ messages in thread
From: Robert Foss @ 2022-01-04 14:36 UTC (permalink / raw)
To: Jiří Vaněk
Cc: Vinay Simha B N, Zheng Bin, Andrzej Hajda, Neil Armstrong,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, open list:DRM PANEL DRIVERS, open list
Excellent.
Jiri, can you add your Tested-by tag to this patch?
On Tue, 4 Jan 2022 at 15:29, Jiří Vaněk <jirivanek1@gmail.com> wrote:
>
> Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all.
>
> út 4. 1. 2022 v 14:51 odesílatel Robert Foss <robert.foss@linaro.org> napsal:
>>
>> Jiri: Are you able to test this patch?
>>
>> Vinay: Could you supply a R-b tag, if you feel that it is warranted?
>>
>> On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote:
>> >
>> > Robert,
>> > I do not have the hardware to test this feature. Sorry for the late response.
>> >
>> > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote:
>> >>
>> >> + Zhen & Vinay
>> >>
>> >> This patch looks good in itself, but I would like to see a tested by
>> >> tag. At the very least testing for regression in single-link LVDS but
>> >> ideally some third party verification of this patch.
>> >>
>> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote:
>> >> >
>> >> > Fixed wrong register shift for single/dual link LVDS output.
>> >> >
>> >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
>> >> > ---
>> >> > drivers/gpu/drm/bridge/tc358775.c | 2 +-
>> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >> >
>> >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
>> >> > index 2272adcc5b4a..1d6ec1baeff2 100644
>> >> > --- a/drivers/gpu/drm/bridge/tc358775.c
>> >> > +++ b/drivers/gpu/drm/bridge/tc358775.c
>> >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
>> >> > }
>> >> >
>> >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002
>> >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0
>> >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1
>> >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
>> >> > {
>> >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
>> >> > --
>> >> > 2.30.2
>> >> >
>> >
>> >
>> >
>> > --
>> > regards,
>> > vinaysimha
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
@ 2022-01-04 14:36 ` Robert Foss
0 siblings, 0 replies; 21+ messages in thread
From: Robert Foss @ 2022-01-04 14:36 UTC (permalink / raw)
To: Jiří Vaněk
Cc: Jonas Karlman, David Airlie, open list:DRM PANEL DRIVERS,
Neil Armstrong, open list, Jernej Skrabec, Zheng Bin,
Andrzej Hajda, Laurent Pinchart, Vinay Simha B N
Excellent.
Jiri, can you add your Tested-by tag to this patch?
On Tue, 4 Jan 2022 at 15:29, Jiří Vaněk <jirivanek1@gmail.com> wrote:
>
> Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all.
>
> út 4. 1. 2022 v 14:51 odesílatel Robert Foss <robert.foss@linaro.org> napsal:
>>
>> Jiri: Are you able to test this patch?
>>
>> Vinay: Could you supply a R-b tag, if you feel that it is warranted?
>>
>> On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote:
>> >
>> > Robert,
>> > I do not have the hardware to test this feature. Sorry for the late response.
>> >
>> > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote:
>> >>
>> >> + Zhen & Vinay
>> >>
>> >> This patch looks good in itself, but I would like to see a tested by
>> >> tag. At the very least testing for regression in single-link LVDS but
>> >> ideally some third party verification of this patch.
>> >>
>> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote:
>> >> >
>> >> > Fixed wrong register shift for single/dual link LVDS output.
>> >> >
>> >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
>> >> > ---
>> >> > drivers/gpu/drm/bridge/tc358775.c | 2 +-
>> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >> >
>> >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
>> >> > index 2272adcc5b4a..1d6ec1baeff2 100644
>> >> > --- a/drivers/gpu/drm/bridge/tc358775.c
>> >> > +++ b/drivers/gpu/drm/bridge/tc358775.c
>> >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
>> >> > }
>> >> >
>> >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002
>> >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0
>> >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1
>> >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
>> >> > {
>> >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
>> >> > --
>> >> > 2.30.2
>> >> >
>> >
>> >
>> >
>> > --
>> > regards,
>> > vinaysimha
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
2022-01-04 14:29 ` Jiří Vaněk
@ 2022-01-04 17:04 ` Vinay Simha B N
2022-01-04 17:04 ` Vinay Simha B N
1 sibling, 0 replies; 21+ messages in thread
From: Vinay Simha B N @ 2022-01-04 17:04 UTC (permalink / raw)
To: Jiří Vaněk
Cc: Robert Foss, Zheng Bin, Andrzej Hajda, Neil Armstrong,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, open list:DRM PANEL DRIVERS, open list
Jiri Vanek,
Could you please share the part number or datasheet of the dual-link
LVDS display used.
On Tue, Jan 4, 2022 at 7:59 PM Jiří Vaněk <jirivanek1@gmail.com> wrote:
>
> Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all.
>
> út 4. 1. 2022 v 14:51 odesílatel Robert Foss <robert.foss@linaro.org> napsal:
>>
>> Jiri: Are you able to test this patch?
>>
>> Vinay: Could you supply a R-b tag, if you feel that it is warranted?
>>
>> On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote:
>> >
>> > Robert,
>> > I do not have the hardware to test this feature. Sorry for the late response.
>> >
>> > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote:
>> >>
>> >> + Zhen & Vinay
>> >>
>> >> This patch looks good in itself, but I would like to see a tested by
>> >> tag. At the very least testing for regression in single-link LVDS but
>> >> ideally some third party verification of this patch.
>> >>
>> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote:
>> >> >
>> >> > Fixed wrong register shift for single/dual link LVDS output.
>> >> >
>> >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
>> >> > ---
>> >> > drivers/gpu/drm/bridge/tc358775.c | 2 +-
>> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >> >
>> >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
>> >> > index 2272adcc5b4a..1d6ec1baeff2 100644
>> >> > --- a/drivers/gpu/drm/bridge/tc358775.c
>> >> > +++ b/drivers/gpu/drm/bridge/tc358775.c
>> >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
>> >> > }
>> >> >
>> >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002
>> >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0
>> >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1
>> >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
>> >> > {
>> >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
>> >> > --
>> >> > 2.30.2
>> >> >
>> >
>> >
>> >
>> > --
>> > regards,
>> > vinaysimha
--
regards,
vinaysimha
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
@ 2022-01-04 17:04 ` Vinay Simha B N
0 siblings, 0 replies; 21+ messages in thread
From: Vinay Simha B N @ 2022-01-04 17:04 UTC (permalink / raw)
To: Jiří Vaněk
Cc: Jernej Skrabec, Jonas Karlman, David Airlie,
open list:DRM PANEL DRIVERS, Neil Armstrong, open list,
Robert Foss, Zheng Bin, Andrzej Hajda, Laurent Pinchart
Jiri Vanek,
Could you please share the part number or datasheet of the dual-link
LVDS display used.
On Tue, Jan 4, 2022 at 7:59 PM Jiří Vaněk <jirivanek1@gmail.com> wrote:
>
> Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all.
>
> út 4. 1. 2022 v 14:51 odesílatel Robert Foss <robert.foss@linaro.org> napsal:
>>
>> Jiri: Are you able to test this patch?
>>
>> Vinay: Could you supply a R-b tag, if you feel that it is warranted?
>>
>> On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote:
>> >
>> > Robert,
>> > I do not have the hardware to test this feature. Sorry for the late response.
>> >
>> > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote:
>> >>
>> >> + Zhen & Vinay
>> >>
>> >> This patch looks good in itself, but I would like to see a tested by
>> >> tag. At the very least testing for regression in single-link LVDS but
>> >> ideally some third party verification of this patch.
>> >>
>> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote:
>> >> >
>> >> > Fixed wrong register shift for single/dual link LVDS output.
>> >> >
>> >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
>> >> > ---
>> >> > drivers/gpu/drm/bridge/tc358775.c | 2 +-
>> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >> >
>> >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
>> >> > index 2272adcc5b4a..1d6ec1baeff2 100644
>> >> > --- a/drivers/gpu/drm/bridge/tc358775.c
>> >> > +++ b/drivers/gpu/drm/bridge/tc358775.c
>> >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
>> >> > }
>> >> >
>> >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002
>> >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0
>> >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1
>> >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
>> >> > {
>> >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
>> >> > --
>> >> > 2.30.2
>> >> >
>> >
>> >
>> >
>> > --
>> > regards,
>> > vinaysimha
--
regards,
vinaysimha
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
2022-01-04 13:50 ` Robert Foss
@ 2022-01-04 16:56 ` Vinay Simha B N
-1 siblings, 0 replies; 21+ messages in thread
From: Vinay Simha B N @ 2022-01-04 16:56 UTC (permalink / raw)
To: Robert Foss
Cc: Jiri Vanek, Zheng Bin, Andrzej Hajda, Neil Armstrong,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, open list:DRM PANEL DRIVERS, open list
Robert,
What is R-b tag?
On Tue, Jan 4, 2022 at 7:21 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> Jiri: Are you able to test this patch?
>
> Vinay: Could you supply a R-b tag, if you feel that it is warranted?
>
> On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote:
> >
> > Robert,
> > I do not have the hardware to test this feature. Sorry for the late response.
> >
> > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote:
> >>
> >> + Zhen & Vinay
> >>
> >> This patch looks good in itself, but I would like to see a tested by
> >> tag. At the very least testing for regression in single-link LVDS but
> >> ideally some third party verification of this patch.
> >>
> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote:
> >> >
> >> > Fixed wrong register shift for single/dual link LVDS output.
> >> >
> >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
> >> > ---
> >> > drivers/gpu/drm/bridge/tc358775.c | 2 +-
> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
> >> > index 2272adcc5b4a..1d6ec1baeff2 100644
> >> > --- a/drivers/gpu/drm/bridge/tc358775.c
> >> > +++ b/drivers/gpu/drm/bridge/tc358775.c
> >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
> >> > }
> >> >
> >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002
> >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0
> >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1
> >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
> >> > {
> >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
> >> > --
> >> > 2.30.2
> >> >
> >
> >
> >
> > --
> > regards,
> > vinaysimha
--
regards,
vinaysimha
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
@ 2022-01-04 16:56 ` Vinay Simha B N
0 siblings, 0 replies; 21+ messages in thread
From: Vinay Simha B N @ 2022-01-04 16:56 UTC (permalink / raw)
To: Robert Foss
Cc: Jiri Vanek, Jonas Karlman, David Airlie,
open list:DRM PANEL DRIVERS, Neil Armstrong, open list,
Jernej Skrabec, Zheng Bin, Andrzej Hajda, Laurent Pinchart
Robert,
What is R-b tag?
On Tue, Jan 4, 2022 at 7:21 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> Jiri: Are you able to test this patch?
>
> Vinay: Could you supply a R-b tag, if you feel that it is warranted?
>
> On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote:
> >
> > Robert,
> > I do not have the hardware to test this feature. Sorry for the late response.
> >
> > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote:
> >>
> >> + Zhen & Vinay
> >>
> >> This patch looks good in itself, but I would like to see a tested by
> >> tag. At the very least testing for regression in single-link LVDS but
> >> ideally some third party verification of this patch.
> >>
> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote:
> >> >
> >> > Fixed wrong register shift for single/dual link LVDS output.
> >> >
> >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
> >> > ---
> >> > drivers/gpu/drm/bridge/tc358775.c | 2 +-
> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
> >> > index 2272adcc5b4a..1d6ec1baeff2 100644
> >> > --- a/drivers/gpu/drm/bridge/tc358775.c
> >> > +++ b/drivers/gpu/drm/bridge/tc358775.c
> >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
> >> > }
> >> >
> >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002
> >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0
> >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1
> >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
> >> > {
> >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
> >> > --
> >> > 2.30.2
> >> >
> >
> >
> >
> > --
> > regards,
> > vinaysimha
--
regards,
vinaysimha
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
2022-01-04 16:56 ` Vinay Simha B N
(?)
@ 2022-01-04 17:09 ` Robert Foss
-1 siblings, 0 replies; 21+ messages in thread
From: Robert Foss @ 2022-01-04 17:09 UTC (permalink / raw)
To: Vinay Simha B N
Cc: Jiri Vanek, Jonas Karlman, David Airlie,
open list:DRM PANEL DRIVERS, Neil Armstrong, open list,
Jernej Skrabec, Zheng Bin, Andrzej Hajda, Laurent Pinchart
[-- Attachment #1: Type: text/plain, Size: 2208 bytes --]
On Tue, Jan 4, 2022, 17:56 Vinay Simha B N <simhavcs@gmail.com> wrote:
> Robert,
> What is R-b tag?
>
It looks like this Reviewed-by: Name Lastname <email address>
Maybe have a quick look at this document.
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
>
> On Tue, Jan 4, 2022 at 7:21 PM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > Jiri: Are you able to test this patch?
> >
> > Vinay: Could you supply a R-b tag, if you feel that it is warranted?
> >
> > On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com>
> wrote:
> > >
> > > Robert,
> > > I do not have the hardware to test this feature. Sorry for the late
> response.
> > >
> > > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org>
> wrote:
> > >>
> > >> + Zhen & Vinay
> > >>
> > >> This patch looks good in itself, but I would like to see a tested by
> > >> tag. At the very least testing for regression in single-link LVDS but
> > >> ideally some third party verification of this patch.
> > >>
> > >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com>
> wrote:
> > >> >
> > >> > Fixed wrong register shift for single/dual link LVDS output.
> > >> >
> > >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
> > >> > ---
> > >> > drivers/gpu/drm/bridge/tc358775.c | 2 +-
> > >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >> >
> > >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c
> b/drivers/gpu/drm/bridge/tc358775.c
> > >> > index 2272adcc5b4a..1d6ec1baeff2 100644
> > >> > --- a/drivers/gpu/drm/bridge/tc358775.c
> > >> > +++ b/drivers/gpu/drm/bridge/tc358775.c
> > >> > @@ -241,7 +241,7 @@ static inline u32
> TC358775_LVCFG_PCLKDIV(uint32_t val)
> > >> > }
> > >> >
> > >> > #define TC358775_LVCFG_LVDLINK__MASK
> 0x00000002
> > >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0
> > >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1
> > >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
> > >> > {
> > >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
> > >> > --
> > >> > 2.30.2
> > >> >
> > >
> > >
> > >
> > > --
> > > regards,
> > > vinaysimha
>
>
>
> --
> regards,
> vinaysimha
>
[-- Attachment #2: Type: text/html, Size: 4015 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread