From: Jakub Kicinski <kuba@kernel.org>
To: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Cc: "Sornek, Karen" <karen.sornek@intel.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Patynowski, PrzemyslawX" <przemyslawx.patynowski@intel.com>,
"Jankowski, Konrad0" <konrad0.jankowski@intel.com>
Subject: Re: [PATCH net-next 2/7] i40e: Add placeholder for ndo set VLANs
Date: Fri, 7 Jan 2022 09:28:42 -0800 [thread overview]
Message-ID: <20220107092842.61631642@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <9f5f4b4521194293714afab1d69dbcea9cd07030.camel@intel.com>
On Fri, 7 Jan 2022 17:16:33 +0000 Nguyen, Anthony L wrote:
> On Thu, 2022-01-06 at 20:32 -0800, Jakub Kicinski wrote:
> > On Thu, 6 Jan 2022 13:32:56 -0800 Tony Nguyen wrote:
> > > From: Karen Sornek <karen.sornek@intel.com>
> > >
> > > VLANs set by ndo, were not accounted.
> > > Implement placeholder, by which driver can account VLANs set by
> > > ndo. Ensure that once PF changes trunk, every guest filter
> > > is removed from the list 'vm_vlan_list'.
> > > Implement logic for deletion/addition of guest(from VM) filters.
> >
> > I could not understand what this change is achieving from reading
> > this.
> >
> The author is currently out on holiday. I'm going to drop this from the
> series so the other patches can make it before net-next closes. She'll
> respond and/or make changes when she returns.
SG! The rest of the patches LGTM, thanks!
next prev parent reply other threads:[~2022-01-07 17:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 21:32 [PATCH net-next 0/7][pull request] 40GbE Intel Wired LAN Driver Updates 2022-01-06 Tony Nguyen
2022-01-06 21:32 ` [PATCH net-next 1/7] i40e: Add ensurance of MacVlan resources for every trusted VF Tony Nguyen
2022-01-06 21:32 ` [PATCH net-next 2/7] i40e: Add placeholder for ndo set VLANs Tony Nguyen
2022-01-07 4:32 ` Jakub Kicinski
2022-01-07 17:16 ` Nguyen, Anthony L
2022-01-07 17:28 ` Jakub Kicinski [this message]
2022-01-06 21:32 ` [PATCH net-next 3/7] i40e: Minimize amount of busy-waiting during AQ send Tony Nguyen
2022-01-06 21:32 ` [PATCH net-next 4/7] i40e: Update FW API version Tony Nguyen
2022-01-06 21:32 ` [PATCH net-next 5/7] i40e: Remove non-inclusive language Tony Nguyen
2022-01-06 21:33 ` [PATCH net-next 6/7] i40e: remove variables set but not used Tony Nguyen
2022-01-06 21:33 ` [PATCH net-next 7/7] iavf: remove an unneeded variable Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107092842.61631642@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=karen.sornek@intel.com \
--cc=konrad0.jankowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslawx.patynowski@intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.