From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69283C433F5 for ; Fri, 7 Jan 2022 14:56:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239012AbiAGO4u (ORCPT ); Fri, 7 Jan 2022 09:56:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239425AbiAGO4m (ORCPT ); Fri, 7 Jan 2022 09:56:42 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4023C061401; Fri, 7 Jan 2022 06:56:41 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 829E561560; Fri, 7 Jan 2022 14:56:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8184C36AEB; Fri, 7 Jan 2022 14:56:39 +0000 (UTC) Date: Fri, 7 Jan 2022 09:56:38 -0500 From: Steven Rostedt To: Sai Prakash Ranjan Cc: Will Deacon , Catalin Marinas , Marc Zyngier , Arnd Bergmann , gregkh , , , , , Prasad Sodagudi Subject: Re: [PATCHv6 4/5] tracing: Add register read/write tracing support Message-ID: <20220107095638.7d81c1b9@gandalf.local.home> In-Reply-To: References: <76983c26d889df7252a17017a48754163fb6b0d5.1638858747.git.quic_saipraka@quicinc.com> <20220106131824.073fbe5c@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 7 Jan 2022 10:40:05 +0530 Sai Prakash Ranjan wrote: > Hi Steve, > > On 1/6/2022 11:48 PM, Steven Rostedt wrote: > > This should not be in the kernel/trace directory. It should be in the > > Hmm these are called from low level generic io header file > (include/asm-generic/) where > we wouldn't have any Kconfig to control this feature flexibly and as we > can have this as > a generic feature selectable by other architectures, wouldn't this be > suited in kernel/trace? Isn't there a place for generic rwmmio code? > I thought you were ok with the folder structure in the initial versions > of the series? Sorry, I missed the C file in kernel/trace. The files in kernel/trace tend to be specific for the internals of tracing. This C file is more to hold helper functions for mmio, which to me should be someplace for mmio code. Perhaps in mm/ ? -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9ADDC433F5 for ; Fri, 7 Jan 2022 14:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eHGrKD+rjXK+dyd8W9IHW0X491IWj7+/A6NtlxCcyf4=; b=ijXcxVKLLI8O7m UzP8PNwmH7BJCURABYLyNHwirxRCkdGKqUNeYqUbOPe9uFpOSt8AxEJZov5DaYW21aQ66g75c94A4 oUFEQHPl3hBa3BMuIgn8ZQ452cUIkW0lvgwR/m1CoWFSaYBQw0jJ9LC+7YlN67Akb2aQMJzG43xGJ ofKp+5Q5O9c29cgbzUwA/GyU/mcIqn1lNarMCfjiCVbs08K9XkKInwLosUK2G4in22yZLi3FcoEB9 B2fZ67AJRpDTuzuPJTC5yWKZ1TkyPEmsNhhY/795VutUKIpPX4PvZc7cefAxOFe3Mcvs/K9VHWRHI qV7tngYYY8hOEuhgYuuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5qh4-004LQu-3C; Fri, 07 Jan 2022 14:58:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5qfZ-004KTv-V1 for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 14:56:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E249612D8; Fri, 7 Jan 2022 14:56:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8184C36AEB; Fri, 7 Jan 2022 14:56:39 +0000 (UTC) Date: Fri, 7 Jan 2022 09:56:38 -0500 From: Steven Rostedt To: Sai Prakash Ranjan Cc: Will Deacon , Catalin Marinas , Marc Zyngier , Arnd Bergmann , gregkh , , , , , Prasad Sodagudi Subject: Re: [PATCHv6 4/5] tracing: Add register read/write tracing support Message-ID: <20220107095638.7d81c1b9@gandalf.local.home> In-Reply-To: References: <76983c26d889df7252a17017a48754163fb6b0d5.1638858747.git.quic_saipraka@quicinc.com> <20220106131824.073fbe5c@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_065642_128201_A211DFC1 X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 7 Jan 2022 10:40:05 +0530 Sai Prakash Ranjan wrote: > Hi Steve, > > On 1/6/2022 11:48 PM, Steven Rostedt wrote: > > This should not be in the kernel/trace directory. It should be in the > > Hmm these are called from low level generic io header file > (include/asm-generic/) where > we wouldn't have any Kconfig to control this feature flexibly and as we > can have this as > a generic feature selectable by other architectures, wouldn't this be > suited in kernel/trace? Isn't there a place for generic rwmmio code? > I thought you were ok with the folder structure in the initial versions > of the series? Sorry, I missed the C file in kernel/trace. The files in kernel/trace tend to be specific for the internals of tracing. This C file is more to hold helper functions for mmio, which to me should be someplace for mmio code. Perhaps in mm/ ? -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel