From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE08C433F5 for ; Fri, 7 Jan 2022 13:52:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347691AbiAGNwm (ORCPT ); Fri, 7 Jan 2022 08:52:42 -0500 Received: from sin.source.kernel.org ([145.40.73.55]:35862 "EHLO sin.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347679AbiAGNwm (ORCPT ); Fri, 7 Jan 2022 08:52:42 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A154ACE2AF3 for ; Fri, 7 Jan 2022 13:52:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95481C36AE0; Fri, 7 Jan 2022 13:52:37 +0000 (UTC) Date: Fri, 7 Jan 2022 14:52:29 +0100 From: Christian Brauner To: David Disseldorp Cc: linux-fsdevel@vger.kernel.org, Martin Wilck , viro@zeniv.linux.org.uk, willy@infradead.org Subject: Re: [PATCH v6 1/6] initramfs: refactor do_header() cpio magic checks Message-ID: <20220107135229.d3moxxff3clzslrr@wittgenstein> References: <20220107133814.32655-1-ddiss@suse.de> <20220107133814.32655-2-ddiss@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220107133814.32655-2-ddiss@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Jan 07, 2022 at 02:38:09PM +0100, David Disseldorp wrote: > do_header() is called for each cpio entry and fails if the first six > bytes don't match "newc" magic. The magic check includes a special case > error message if POSIX.1 ASCII (cpio -H odc) magic is detected. This > special case POSIX.1 check can be nested under the "newc" mismatch code > path to avoid calling memcmp() twice in a non-error case. > > Signed-off-by: David Disseldorp > Reviewed-by: Martin Wilck > --- Acked-by: Christian Brauner