All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Wei Yang <richard.weiyang@gmail.com>,
	peterz@infradead.org, vbabka@suse.cz, will@kernel.org,
	linyunsheng@huawei.com, aarcange@redhat.com, feng.tang@intel.com,
	ebiederm@xmission.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remove offset check on page->compound_head and folio->lru
Date: Fri, 7 Jan 2022 16:08:25 -0800	[thread overview]
Message-ID: <20220107160825.13c71fdd871d7d5611d116b9@linux-foundation.org> (raw)
In-Reply-To: <Ydi6iMbSZ/FewYPT@casper.infradead.org>

On Fri, 7 Jan 2022 22:11:20 +0000 Matthew Wilcox <willy@infradead.org> wrote:

> On Fri, Jan 07, 2022 at 01:40:59PM +0000, Wei Yang wrote:
> > On Fri, Jan 07, 2022 at 03:59:01AM +0000, Matthew Wilcox wrote:
> > >On Thu, Jan 06, 2022 at 11:52:54PM +0000, Wei Yang wrote:
> > >> FOLIO_MATCH() is used to make sure struct page and folio has identical
> > >> layout for the first several words.
> > >> 
> > >> The comparison of offset between page->compound_head and folio->lru is
> > >> more like an internal check in struct page.
> > >> 
> > >> This patch just removes it.
> > >> 
> > >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> > >
> > >No.
> > 
> > Hi, Matthew
> > 
> > Would you mind sharing some insight on this check?
> 
> It's right there in the comments.

Well I can't figure out which comment you're referring to?

> If you can't be bothered to read, why should I write?

I don't think the punishment comes close to fitting the crime here :(

  reply	other threads:[~2022-01-08  0:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06 23:52 [PATCH] mm: remove offset check on page->compound_head and folio->lru Wei Yang
2022-01-07  3:59 ` Matthew Wilcox
2022-01-07 13:40   ` Wei Yang
2022-01-07 22:11     ` Matthew Wilcox
2022-01-08  0:08       ` Andrew Morton [this message]
2022-01-08  0:49         ` Matthew Wilcox
2022-01-08  2:41           ` Andrew Morton
2022-01-08  8:13           ` Wei Yang
2022-01-23  1:38             ` Wei Yang
2022-01-24 10:30               ` Vlastimil Babka
2022-01-24 22:55                 ` Wei Yang
2022-01-25 10:11                   ` Vlastimil Babka
2022-01-27  1:10                     ` Wei Yang
2022-01-27 15:42                       ` Vlastimil Babka
2022-01-29  0:47                         ` Wei Yang
2022-02-24  1:03                 ` Wei Yang
2022-02-17  0:34           ` Wei Yang
2022-01-08  0:27       ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107160825.13c71fdd871d7d5611d116b9@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=aarcange@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=feng.tang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linyunsheng@huawei.com \
    --cc=peterz@infradead.org \
    --cc=richard.weiyang@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.