From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD99C433F5 for ; Fri, 7 Jan 2022 23:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231361AbiAGXRg (ORCPT ); Fri, 7 Jan 2022 18:17:36 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:44614 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbiAGXRg (ORCPT ); Fri, 7 Jan 2022 18:17:36 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CB5A61FC5 for ; Fri, 7 Jan 2022 23:17:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 607FAC36AE5; Fri, 7 Jan 2022 23:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641597455; bh=zvCY63wkuhA6xusndM1kWXxr+uS2GDbkVZWNJx3BRJM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=QaKfTzWMgOtbyVvZcR0o2lq0qnN0rfqWo0ZOaogLd7CnphHsFSnvhQRA6kQ+gFMX2 tapu6l9bx/OKOJH4PGpay61ZZ6DItuQPCjt5fMYwwGzKN4S0ytd+ZeVC5HUWcqll4F 14QpbHySjN9OVmobc2lYq61MgHc2KC3DduCgNsAeIgtkSq4p6pSG7jSFnNZI2iLWrd X4TXHpVMzdife9MpNlvf5/Vcr8h/8ZJsgsRt9HdkwAcU+vFbcsWF5/GyZ2Y7xf6+CI hEsVde8T0ZohQ0O+auwhp/DFt6m4weMhq0kkLKl7uL2G8QGPgYfO3uO13lS8Lq0OXd 9cc4Miap0tAuA== Date: Fri, 7 Jan 2022 17:17:34 -0600 From: Bjorn Helgaas To: Thomas Petazzoni Cc: Bjorn Helgaas , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Russell King , Antoine Tenart , Gregory Clement , Maxime Chevallier , Nadav Haklai , Victor Gu , =?iso-8859-1?Q?Miqu=E8l?= Raynal , Zachary Zhang , Wilson Ding , linux-arm-kernel@lists.infradead.org, Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH 3/3] PCI: aardvark: Implement emulated root PCI bridge Message-ID: <20220107231734.GA426583@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220107212736.GA404447@bhelgaas> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org [+cc Pali; sorry, I meant to cc you on this but forgot] On Fri, Jan 07, 2022 at 03:27:38PM -0600, Bjorn Helgaas wrote: > On Fri, Jun 29, 2018 at 11:22:31AM +0200, Thomas Petazzoni wrote: > > > +static void advk_sw_pci_bridge_init(struct advk_pcie *pcie) > > +{ > > + struct pci_sw_bridge *bridge = &pcie->bridge; > > > + /* Support interrupt A for MSI feature */ > > + bridge->conf.intpin = PCIE_CORE_INT_A_ASSERT_ENABLE; > > Only 3.5 years later, IIUC, this is the value you get when you read > PCI_INTERRUPT_PIN, so I think this should be PCI_INTERRUPT_INTA, not > PCIE_CORE_INT_A_ASSERT_ENABLE. > > Readers expect to get the values defined in the PCI spec, i.e., > > PCI_INTERRUPT_UNKNOWN > PCI_INTERRUPT_INTA > PCI_INTERRUPT_INTB > PCI_INTERRUPT_INTC > PCI_INTERRUPT_INTD > > Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A6BAC433F5 for ; Fri, 7 Jan 2022 23:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=xqaFRL/lT4aSrKA0oE98si7ZaskqMh+81BUtqOpvou4=; b=H9vKoi6hODXqRH F7X6yPb1Zzn+jpEXIwvVnkfBSttm4q+Dao5jj/fiCWKEzVBvkNVGYeGYhlzUNy90wPnUIPjX9SHAH KFVG7NmQhQa2L1hitrqaQVwNSbbK6XknQLWNbtNo7uqY2S2GISzYfx0d6XowwdoqZ1a1A1JaqfaYP pr9vWnG5pBQa49l8h3zJsM6lNxMV2w73hg/Cr7fdgwY7239OTKKSa3iSvqeZaXUfxz3DGIPJFCizA eQdDqxIHD0xMwZRsCnez2Vj9tiWsbO0TlAzv63LpAGI2bJ/eVR2IgCksENtOxXUMy4QTSyvet1dCw aX7BLyRBZ3GaJaB2wL8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5yUO-005TSn-11; Fri, 07 Jan 2022 23:17:40 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5yUL-005TRJ-7w for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 23:17:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 39C8461F95; Fri, 7 Jan 2022 23:17:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 607FAC36AE5; Fri, 7 Jan 2022 23:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641597455; bh=zvCY63wkuhA6xusndM1kWXxr+uS2GDbkVZWNJx3BRJM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=QaKfTzWMgOtbyVvZcR0o2lq0qnN0rfqWo0ZOaogLd7CnphHsFSnvhQRA6kQ+gFMX2 tapu6l9bx/OKOJH4PGpay61ZZ6DItuQPCjt5fMYwwGzKN4S0ytd+ZeVC5HUWcqll4F 14QpbHySjN9OVmobc2lYq61MgHc2KC3DduCgNsAeIgtkSq4p6pSG7jSFnNZI2iLWrd X4TXHpVMzdife9MpNlvf5/Vcr8h/8ZJsgsRt9HdkwAcU+vFbcsWF5/GyZ2Y7xf6+CI hEsVde8T0ZohQ0O+auwhp/DFt6m4weMhq0kkLKl7uL2G8QGPgYfO3uO13lS8Lq0OXd 9cc4Miap0tAuA== Date: Fri, 7 Jan 2022 17:17:34 -0600 From: Bjorn Helgaas To: Thomas Petazzoni Cc: Bjorn Helgaas , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Russell King , Antoine Tenart , Gregory Clement , Maxime Chevallier , Nadav Haklai , Victor Gu , =?iso-8859-1?Q?Miqu=E8l?= Raynal , Zachary Zhang , Wilson Ding , linux-arm-kernel@lists.infradead.org, Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH 3/3] PCI: aardvark: Implement emulated root PCI bridge Message-ID: <20220107231734.GA426583@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220107212736.GA404447@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_151737_350362_1E700563 X-CRM114-Status: GOOD ( 14.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+cc Pali; sorry, I meant to cc you on this but forgot] On Fri, Jan 07, 2022 at 03:27:38PM -0600, Bjorn Helgaas wrote: > On Fri, Jun 29, 2018 at 11:22:31AM +0200, Thomas Petazzoni wrote: > > > +static void advk_sw_pci_bridge_init(struct advk_pcie *pcie) > > +{ > > + struct pci_sw_bridge *bridge = &pcie->bridge; > > > + /* Support interrupt A for MSI feature */ > > + bridge->conf.intpin = PCIE_CORE_INT_A_ASSERT_ENABLE; > > Only 3.5 years later, IIUC, this is the value you get when you read > PCI_INTERRUPT_PIN, so I think this should be PCI_INTERRUPT_INTA, not > PCIE_CORE_INT_A_ASSERT_ENABLE. > > Readers expect to get the values defined in the PCI spec, i.e., > > PCI_INTERRUPT_UNKNOWN > PCI_INTERRUPT_INTA > PCI_INTERRUPT_INTB > PCI_INTERRUPT_INTC > PCI_INTERRUPT_INTD > > Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel