From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA3AC433EF for ; Mon, 10 Jan 2022 01:50:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237991AbiAJBug (ORCPT ); Sun, 9 Jan 2022 20:50:36 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:59138 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237983AbiAJBuf (ORCPT ); Sun, 9 Jan 2022 20:50:35 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 15C6360ED2 for ; Mon, 10 Jan 2022 01:50:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEA50C36AF5; Mon, 10 Jan 2022 01:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641779434; bh=Ih0N11jBn2l6o2OI2QlXgP3YmCz6NpbiIcjRFrzHARs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OFaP9vUVWZXR3ZczLtC+6MyLXkdZ7RCGMTN5aRwZzFf70UgSXQyB6IyGvM9tzb0gX 9ZNV99122IfE8cBbIoj84RWwrfNr7uO0itLMH9xXF4bfzFoMaOs7U1GF/K9vsY+NiJ MIBSOyWVBo5f3Hl+G7+2qY3VqJBtVlRWa8MnPVI8TX2N5wkhY0SNUbvf8dHk1mpjYb wJDoS5qLaTZ4Z7pImdPBXeSLZ2SOrl/u2poOSuHoMpnqIeuIm97lHByOXsQq7aF5i0 9Glcf7lXzEyVRM/JPA0tX8Ts5DkE3EwIbZK4apkyx9Adz+oNs7Vdo4YKDUrWbpffHw WhdD9Lql11tcQ== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Marc Zyngier , Lorenzo Pieralisi , Bjorn Helgaas Cc: pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH v2 05/23] PCI: aardvark: Check return value of generic_handle_domain_irq() when processing INTx IRQ Date: Mon, 10 Jan 2022 02:50:00 +0100 Message-Id: <20220110015018.26359-6-kabel@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220110015018.26359-1-kabel@kernel.org> References: <20220110015018.26359-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Pali Rohár It is possible that we receive spurious INTx interrupt. Check for the return value of generic_handle_domain_irq() when processing INTx IRQ. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún --- drivers/pci/controller/pci-aardvark.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 315147f2812f..252033a46e1e 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -1434,7 +1434,9 @@ static void advk_pcie_handle_int(struct advk_pcie *pcie) advk_writel(pcie, PCIE_ISR1_INTX_ASSERT(i), PCIE_ISR1_REG); - generic_handle_domain_irq(pcie->irq_domain, i); + if (generic_handle_domain_irq(pcie->irq_domain, i) == -EINVAL) + dev_err_ratelimited(&pcie->pdev->dev, "unexpected INT%c IRQ\n", + (char)i + 'A'); } } -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D488DC433EF for ; Mon, 10 Jan 2022 01:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Je4cdNmZ5JwJDZ2V5bM+PRlmqcmmwYZl55OKN03UMNg=; b=2+1vjlutnQ1lSW BLE5W6SXSk4IX8jsPAW1Fs5GN3hqh0KYB+dT/P9aokPDFJ7XZTgwl6Pu2w4TTmNTq3Ao73HvWc1gM AxeD39vOMSyJIXIRJhAiiUao8wL2euNeb5s4DQc6x3DjWPJyPChqW7iIG5Vb6VsG+CrTZYzhOQ+Oz u+HsidlLTaxNq9OaFoq2BXOsgM9A3SK3BVPdT94XO6j1JRgd3eCuIrvo+nmJW1zUeqG5b75FMbVF2 CdbgBxMkxZhz+kmGW1xvW7o7cazqKYFrQNkgFUl4/Syje8Zrq6SothKot9Wy/fFBtYuGJ0DEPWeP6 QCiigu56qd389A3c2cXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6jqL-008m2a-UT; Mon, 10 Jan 2022 01:51:30 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6jpU-008lcR-R0 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 01:50:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8A301B8111D; Mon, 10 Jan 2022 01:50:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEA50C36AF5; Mon, 10 Jan 2022 01:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641779434; bh=Ih0N11jBn2l6o2OI2QlXgP3YmCz6NpbiIcjRFrzHARs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OFaP9vUVWZXR3ZczLtC+6MyLXkdZ7RCGMTN5aRwZzFf70UgSXQyB6IyGvM9tzb0gX 9ZNV99122IfE8cBbIoj84RWwrfNr7uO0itLMH9xXF4bfzFoMaOs7U1GF/K9vsY+NiJ MIBSOyWVBo5f3Hl+G7+2qY3VqJBtVlRWa8MnPVI8TX2N5wkhY0SNUbvf8dHk1mpjYb wJDoS5qLaTZ4Z7pImdPBXeSLZ2SOrl/u2poOSuHoMpnqIeuIm97lHByOXsQq7aF5i0 9Glcf7lXzEyVRM/JPA0tX8Ts5DkE3EwIbZK4apkyx9Adz+oNs7Vdo4YKDUrWbpffHw WhdD9Lql11tcQ== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Marc Zyngier , Lorenzo Pieralisi , Bjorn Helgaas Cc: pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH v2 05/23] PCI: aardvark: Check return value of generic_handle_domain_irq() when processing INTx IRQ Date: Mon, 10 Jan 2022 02:50:00 +0100 Message-Id: <20220110015018.26359-6-kabel@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220110015018.26359-1-kabel@kernel.org> References: <20220110015018.26359-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220109_175037_066158_14982D74 X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KCkl0IGlzIHBvc3NpYmxlIHRoYXQg d2UgcmVjZWl2ZSBzcHVyaW91cyBJTlR4IGludGVycnVwdC4gQ2hlY2sgZm9yIHRoZQpyZXR1cm4g dmFsdWUgb2YgZ2VuZXJpY19oYW5kbGVfZG9tYWluX2lycSgpIHdoZW4gcHJvY2Vzc2luZyBJTlR4 IElSUS4KClNpZ25lZC1vZmYtYnk6IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+ClNpZ25l ZC1vZmYtYnk6IE1hcmVrIEJlaMO6biA8a2FiZWxAa2VybmVsLm9yZz4KLS0tCiBkcml2ZXJzL3Bj aS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jIHwgNCArKystCiAxIGZpbGUgY2hhbmdlZCwgMyBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29u dHJvbGxlci9wY2ktYWFyZHZhcmsuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2 YXJrLmMKaW5kZXggMzE1MTQ3ZjI4MTJmLi4yNTIwMzNhNDZlMWUgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJrLmMKKysrIGIvZHJpdmVycy9wY2kvY29udHJv bGxlci9wY2ktYWFyZHZhcmsuYwpAQCAtMTQzNCw3ICsxNDM0LDkgQEAgc3RhdGljIHZvaWQgYWR2 a19wY2llX2hhbmRsZV9pbnQoc3RydWN0IGFkdmtfcGNpZSAqcGNpZSkKIAkJYWR2a193cml0ZWwo cGNpZSwgUENJRV9JU1IxX0lOVFhfQVNTRVJUKGkpLAogCQkJICAgIFBDSUVfSVNSMV9SRUcpOwog Ci0JCWdlbmVyaWNfaGFuZGxlX2RvbWFpbl9pcnEocGNpZS0+aXJxX2RvbWFpbiwgaSk7CisJCWlm IChnZW5lcmljX2hhbmRsZV9kb21haW5faXJxKHBjaWUtPmlycV9kb21haW4sIGkpID09IC1FSU5W QUwpCisJCQlkZXZfZXJyX3JhdGVsaW1pdGVkKCZwY2llLT5wZGV2LT5kZXYsICJ1bmV4cGVjdGVk IElOVCVjIElSUVxuIiwKKwkJCQkJICAgIChjaGFyKWkgKyAnQScpOwogCX0KIH0KIAotLSAKMi4z NC4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=