From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1970C433F5 for ; Mon, 10 Jan 2022 02:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235488AbiAJCVh (ORCPT ); Sun, 9 Jan 2022 21:21:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235951AbiAJCVg (ORCPT ); Sun, 9 Jan 2022 21:21:36 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64BF7C06173F for ; Sun, 9 Jan 2022 18:21:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C5ED61126 for ; Mon, 10 Jan 2022 02:21:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70B29C36AEB; Mon, 10 Jan 2022 02:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641781294; bh=fwMzkUGrOc9jyiZkpGZAtpxJf9LJXqEcnc+KKGBFvf8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ar30fuVGg1V2g41ZPuij/58aOVQyg3aKxP8VS1YkTIb0ovXVH4rsRFKXIS0o1wuy3 o1zTCUgYsF5Tos8BP1/kqYV+UlWK2niqJwEEkynEBGo7TLLekRAbJjD+ZDt4eQVfWg opAQapfVoSySv0pw29DPXfppBn6sU1ybkPtaelnOz4XgJ947fs51xHn9mWg7jrZgfE tI9DA5+B1q3YfX5W7E6e1weTNk/hmU8ZrVFmRYrEL5VVdjkxxvrR3tBYfX6QeatE2W bLgjHSQjWtzT0/KYga4o1j/a+DxEY4zavfNPeNNsWgBlF+U4kS8qb/Z/On9v7peWLt tFRUU6mkpAEiQ== Date: Mon, 10 Jan 2022 03:21:27 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Bjorn Helgaas Cc: Thomas Petazzoni , Bjorn Helgaas , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Russell King , Antoine Tenart , Gregory Clement , Maxime Chevallier , Nadav Haklai , Victor Gu , =?UTF-8?B?TWlxdcOobA==?= Raynal , Zachary Zhang , Wilson Ding , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] PCI: aardvark: Implement emulated root PCI bridge Message-ID: <20220110032127.4ea60dc9@thinkpad> In-Reply-To: <20220107212736.GA404447@bhelgaas> References: <20180629092231.32207-4-thomas.petazzoni@bootlin.com> <20220107212736.GA404447@bhelgaas> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 7 Jan 2022 15:27:36 -0600 Bjorn Helgaas wrote: > On Fri, Jun 29, 2018 at 11:22:31AM +0200, Thomas Petazzoni wrote: > > > +static void advk_sw_pci_bridge_init(struct advk_pcie *pcie) > > +{ > > + struct pci_sw_bridge *bridge = &pcie->bridge; > > > + /* Support interrupt A for MSI feature */ > > + bridge->conf.intpin = PCIE_CORE_INT_A_ASSERT_ENABLE; > > Only 3.5 years later, IIUC, this is the value you get when you read > PCI_INTERRUPT_PIN, so I think this should be PCI_INTERRUPT_INTA, not > PCIE_CORE_INT_A_ASSERT_ENABLE. > > Readers expect to get the values defined in the PCI spec, i.e., > > PCI_INTERRUPT_UNKNOWN > PCI_INTERRUPT_INTA > PCI_INTERRUPT_INTB > PCI_INTERRUPT_INTC > PCI_INTERRUPT_INTD Hello Bjorn, now sent v2 of batch 4 of fixes for pci-aardvark, where this is fixed in the first patch. https://lore.kernel.org/linux-pci/20220110015018.26359-1-kabel@kernel.org/ Could you find time to review the series? :-) Marek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19F92C433F5 for ; Mon, 10 Jan 2022 02:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FO8Vly+e3qYlb6KYOmePchkbCzqBhFDMrHmNc0t2CZs=; b=pWDGx6jfAXzWok DdLhRo2eUyXEDwUMNLaA30F98pabllyMsuy6mjfCgYw1uWmEyBDrSzQV+uED1pvKJFV+XdUfDAV9W Fwai3RMkPB1GtZKH+gLs69flTCyhbItNPyIneDa6xRJYWMb/9Z+DgeiEvcDwJGOtH0qgadv0QM/cW dt7na4jRVo3+qHQd9r5bahSQHbWtyDkDyEqaFkVYbfsLHutvA434E6usfnOjpzrst7DErcbLxVRBO UsB0LGZcjUBO7qQ0z9lPBsTDm7OPNglvRRxsUaxg8F5xKd7aWisf9C1IGq4n9dkZO/i8YTV3laBEF gegBrQZERs2jXUF2AlgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6kJY-008xCa-Vn; Mon, 10 Jan 2022 02:21:41 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6kJV-008xBq-1K for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 02:21:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31B5660F43; Mon, 10 Jan 2022 02:21:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70B29C36AEB; Mon, 10 Jan 2022 02:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641781294; bh=fwMzkUGrOc9jyiZkpGZAtpxJf9LJXqEcnc+KKGBFvf8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ar30fuVGg1V2g41ZPuij/58aOVQyg3aKxP8VS1YkTIb0ovXVH4rsRFKXIS0o1wuy3 o1zTCUgYsF5Tos8BP1/kqYV+UlWK2niqJwEEkynEBGo7TLLekRAbJjD+ZDt4eQVfWg opAQapfVoSySv0pw29DPXfppBn6sU1ybkPtaelnOz4XgJ947fs51xHn9mWg7jrZgfE tI9DA5+B1q3YfX5W7E6e1weTNk/hmU8ZrVFmRYrEL5VVdjkxxvrR3tBYfX6QeatE2W bLgjHSQjWtzT0/KYga4o1j/a+DxEY4zavfNPeNNsWgBlF+U4kS8qb/Z/On9v7peWLt tFRUU6mkpAEiQ== Date: Mon, 10 Jan 2022 03:21:27 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Bjorn Helgaas Cc: Thomas Petazzoni , Bjorn Helgaas , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Russell King , Antoine Tenart , Gregory Clement , Maxime Chevallier , Nadav Haklai , Victor Gu , =?UTF-8?B?TWlxdcOobA==?= Raynal , Zachary Zhang , Wilson Ding , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] PCI: aardvark: Implement emulated root PCI bridge Message-ID: <20220110032127.4ea60dc9@thinkpad> In-Reply-To: <20220107212736.GA404447@bhelgaas> References: <20180629092231.32207-4-thomas.petazzoni@bootlin.com> <20220107212736.GA404447@bhelgaas> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220109_182137_151935_C33EA895 X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 7 Jan 2022 15:27:36 -0600 Bjorn Helgaas wrote: > On Fri, Jun 29, 2018 at 11:22:31AM +0200, Thomas Petazzoni wrote: > > > +static void advk_sw_pci_bridge_init(struct advk_pcie *pcie) > > +{ > > + struct pci_sw_bridge *bridge = &pcie->bridge; > > > + /* Support interrupt A for MSI feature */ > > + bridge->conf.intpin = PCIE_CORE_INT_A_ASSERT_ENABLE; > > Only 3.5 years later, IIUC, this is the value you get when you read > PCI_INTERRUPT_PIN, so I think this should be PCI_INTERRUPT_INTA, not > PCIE_CORE_INT_A_ASSERT_ENABLE. > > Readers expect to get the values defined in the PCI spec, i.e., > > PCI_INTERRUPT_UNKNOWN > PCI_INTERRUPT_INTA > PCI_INTERRUPT_INTB > PCI_INTERRUPT_INTC > PCI_INTERRUPT_INTD Hello Bjorn, now sent v2 of batch 4 of fixes for pci-aardvark, where this is fixed in the first patch. https://lore.kernel.org/linux-pci/20220110015018.26359-1-kabel@kernel.org/ Could you find time to review the series? :-) Marek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel