All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Riku Voipio <riku.voipio@iki.fi>, Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3] leds: pca9532: Make pca9532_destroy_devices() return void
Date: Mon, 10 Jan 2022 08:23:17 +0100	[thread overview]
Message-ID: <20220110072317.sysdgvuzvlzzbcsb@pengutronix.de> (raw)
In-Reply-To: <20211022101707.1194979-1-u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

On Fri, Oct 22, 2021 at 12:17:07PM +0200, Uwe Kleine-König wrote:
> Up to now pca9532_destroy_devices() returns always zero because it's
> always called with data != NULL. Remove the never-taken error path and
> make it return void which makes it easier to see in the callers that
> there is no error to handle.
> 
> Also the return value of i2c remove callbacks is ignored anyway.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Ping. This patch is part of an effort to make the i2c remove callback a
void function, too. Are there any concerns, or plans to pick up this
patch?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-01-10  7:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 12:11 [PATCH] leds: pca9532: Make pca9532_destroy_devices() return void Uwe Kleine-König
2021-10-21 12:16 ` [PATCH v2] " Uwe Kleine-König
2021-10-22 10:17   ` [PATCH v3] " Uwe Kleine-König
2022-01-10  7:23     ` Uwe Kleine-König [this message]
2022-01-11 21:12       ` Pavel Machek
2022-01-11 21:30         ` Uwe Kleine-König
2022-03-31 13:19           ` Uwe Kleine-König
2022-04-28 16:08             ` Uwe Kleine-König
2022-05-04 17:38     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220110072317.sysdgvuzvlzzbcsb@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.