Hi Dhananjay, Thank you for the patch! Yet something to improve: [auto build test ERROR on mtd/spi-nor/next] [also build test ERROR on next-20220107] [cannot apply to v5.16] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dhananjay-Phadke/mtd-spi-nor-Add-support-for-w25q512jvm/20220109-124549 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next config: x86_64-randconfig-r002-20220109 (https://download.01.org/0day-ci/archive/20220110/202201100854.LUfUtNBy-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/6fdf5ef11f8f2e8bbfba403dcdfc299d119c51ee git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dhananjay-Phadke/mtd-spi-nor-Add-support-for-w25q512jvm/20220109-124549 git checkout 6fdf5ef11f8f2e8bbfba403dcdfc299d119c51ee # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/mtd/spi-nor/winbond.c:121:52: error: expected expression before ',' token 121 | { "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024), | ^ vim +121 drivers/mtd/spi-nor/winbond.c 34 35 static const struct flash_info winbond_parts[] = { 36 /* Winbond -- w25x "blocks" are 64K, "sectors" are 4KiB */ 37 { "w25x05", INFO(0xef3010, 0, 64 * 1024, 1) 38 NO_SFDP_FLAGS(SECT_4K) }, 39 { "w25x10", INFO(0xef3011, 0, 64 * 1024, 2) 40 NO_SFDP_FLAGS(SECT_4K) }, 41 { "w25x20", INFO(0xef3012, 0, 64 * 1024, 4) 42 NO_SFDP_FLAGS(SECT_4K) }, 43 { "w25x40", INFO(0xef3013, 0, 64 * 1024, 8) 44 NO_SFDP_FLAGS(SECT_4K) }, 45 { "w25x80", INFO(0xef3014, 0, 64 * 1024, 16) 46 NO_SFDP_FLAGS(SECT_4K) }, 47 { "w25x16", INFO(0xef3015, 0, 64 * 1024, 32) 48 NO_SFDP_FLAGS(SECT_4K) }, 49 { "w25q16dw", INFO(0xef6015, 0, 64 * 1024, 32) 50 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 51 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 52 SPI_NOR_QUAD_READ) }, 53 { "w25x32", INFO(0xef3016, 0, 64 * 1024, 64) 54 NO_SFDP_FLAGS(SECT_4K) }, 55 { "w25q16jv-im/jm", INFO(0xef7015, 0, 64 * 1024, 32) 56 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 57 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 58 SPI_NOR_QUAD_READ) }, 59 { "w25q20cl", INFO(0xef4012, 0, 64 * 1024, 4) 60 NO_SFDP_FLAGS(SECT_4K) }, 61 { "w25q20bw", INFO(0xef5012, 0, 64 * 1024, 4) 62 NO_SFDP_FLAGS(SECT_4K) }, 63 { "w25q20ew", INFO(0xef6012, 0, 64 * 1024, 4) 64 NO_SFDP_FLAGS(SECT_4K) }, 65 { "w25q32", INFO(0xef4016, 0, 64 * 1024, 64) 66 NO_SFDP_FLAGS(SECT_4K) }, 67 { "w25q32dw", INFO(0xef6016, 0, 64 * 1024, 64) 68 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 69 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) 70 OTP_INFO(256, 3, 0x1000, 0x1000) }, 71 { "w25q32jv", INFO(0xef7016, 0, 64 * 1024, 64) 72 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 73 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 74 SPI_NOR_QUAD_READ) }, 75 { "w25q32jwm", INFO(0xef8016, 0, 64 * 1024, 64) 76 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 77 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) 78 OTP_INFO(256, 3, 0x1000, 0x1000) }, 79 { "w25q64jwm", INFO(0xef8017, 0, 64 * 1024, 128) 80 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 81 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 82 SPI_NOR_QUAD_READ) }, 83 { "w25q128jwm", INFO(0xef8018, 0, 64 * 1024, 256) 84 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 85 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 86 SPI_NOR_QUAD_READ) }, 87 { "w25q256jwm", INFO(0xef8019, 0, 64 * 1024, 512) 88 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 89 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 90 SPI_NOR_QUAD_READ) }, 91 { "w25x64", INFO(0xef3017, 0, 64 * 1024, 128) 92 NO_SFDP_FLAGS(SECT_4K) }, 93 { "w25q64", INFO(0xef4017, 0, 64 * 1024, 128) 94 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 95 SPI_NOR_QUAD_READ) }, 96 { "w25q64dw", INFO(0xef6017, 0, 64 * 1024, 128) 97 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 98 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 99 SPI_NOR_QUAD_READ) }, 100 { "w25q64jvm", INFO(0xef7017, 0, 64 * 1024, 128) 101 NO_SFDP_FLAGS(SECT_4K) }, 102 { "w25q128fw", INFO(0xef6018, 0, 64 * 1024, 256) 103 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 104 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 105 SPI_NOR_QUAD_READ) }, 106 { "w25q128jv", INFO(0xef7018, 0, 64 * 1024, 256) 107 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) 108 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 109 SPI_NOR_QUAD_READ) }, 110 { "w25q80", INFO(0xef5014, 0, 64 * 1024, 16) 111 NO_SFDP_FLAGS(SECT_4K) }, 112 { "w25q80bl", INFO(0xef4014, 0, 64 * 1024, 16) 113 NO_SFDP_FLAGS(SECT_4K) }, 114 { "w25q128", INFO(0xef4018, 0, 64 * 1024, 256) 115 NO_SFDP_FLAGS(SECT_4K) }, 116 { "w25q256", INFO(0xef4019, 0, 64 * 1024, 512) 117 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) 118 .fixups = &w25q256_fixups }, 119 { "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512) 120 PARSE_SFDP }, > 121 { "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024), 122 PARSE_SFDP }, 123 { "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512) 124 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 125 SPI_NOR_QUAD_READ) }, 126 { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024) 127 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ | 128 SPI_NOR_DUAL_READ) }, 129 { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024) 130 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | 131 SPI_NOR_QUAD_READ) }, 132 }; 133 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org