From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FE7CC433EF for ; Mon, 10 Jan 2022 09:06:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8CA3E811E3; Mon, 10 Jan 2022 10:06:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="muvCuWgy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 29FBB805F9; Mon, 10 Jan 2022 10:06:35 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0EA2181C08 for ; Mon, 10 Jan 2022 10:06:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8ED92B811FE; Mon, 10 Jan 2022 09:06:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DC2EC36AE9; Mon, 10 Jan 2022 09:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641805589; bh=Gk9Q3Qah29IhWZ1tzeBGQUQyK5p8ElAlHTqZS54j2+U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=muvCuWgyG4iS3d+xHMSY9KXt9mDhD2COe0iw+94V3hDX2cuvFJlJ3ngVThEUL/3bz WCXoAtSm97TL+JYBg11M66cjyux5a/gblKKzZ/4qqcIJhxcOHiZ5GLGIRh3Xe+gzoh XOc5XzHvDy/YL0+brkeeyVt3iZ9c+kNFMjO8QamoE8cNDK9WHohvRYYgqvsQvDc8Ku VlQXabUY0vyftLGBVf8q4b6Syn+0Z8DymtRNLepTg1rW2mUjlDsNQhA2ZSm6YbvXIv d6f6DSOoeqFvJjO7U0Z4ur39nynIawayDMp6n4cNcv5+oA4LE0XxnBxHeUCTbEOXAX GhnB5MwEDtEBw== Received: by pali.im (Postfix) id DA183A52; Mon, 10 Jan 2022 10:06:25 +0100 (CET) Date: Mon, 10 Jan 2022 10:06:25 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Stefan Roese Cc: Marek =?utf-8?B?QmVow7pu?= , u-boot@lists.denx.de, Marek =?utf-8?B?QmVow7pu?= Subject: Re: [PATCH u-boot-marvell v2] arm: mvebu: turris_omnia: Fixup SATA or PCIe nodes at runtime in DT blob Message-ID: <20220110090625.i2nive52tufw6jx4@pali> References: <20220107125317.15768-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Monday 10 January 2022 08:43:17 Stefan Roese wrote: > > + /* If mSATA card is not present, disable SATA DT node */ > > + if (!mode_sata) { > > + fdt_for_each_node_by_compatible (node, blob, -1, > > + "marvell,armada-380-ahci") { > > Why are adding the space before the "(" here? This does not seem the > common and preferred coding style AFAICT. Hello Stefan! Just to note that I'm adding this space too when writing for-loops. E.g.: for (i = 0; i < 10; i++) { ... } or: fdt_for_each_node_by_compatible (node, blob, -1, compatible) { ... } > > + if (!fdtdec_get_is_enabled(blob, node)) > > + continue; > > + > > + if (fdt_status_disabled(blob, node) < 0) > > + printf("Cannot disable SATA DT node!\n"); > > + else > > + debug("Disabled SATA DT node\n"); > > + > > + break; > > + } > > + > > + return; > > + }