From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F1CEC433EF for ; Mon, 10 Jan 2022 09:17:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242839AbiAJJRi (ORCPT ); Mon, 10 Jan 2022 04:17:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242612AbiAJJRd (ORCPT ); Mon, 10 Jan 2022 04:17:33 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAAEDC061751 for ; Mon, 10 Jan 2022 01:17:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4953561225 for ; Mon, 10 Jan 2022 09:17:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85716C36AED; Mon, 10 Jan 2022 09:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641806252; bh=I6CA+wzhkholummADzrWOLHSeE/iqhS13t7Dpb5uFi8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ifTD9CZdUjAD/+ZOVp48sQrPq+x2B47ZgZtyjt5QT9/7YQrvvBnHqffzZ+saXWOtA EXK/j5mHFQRCj2LBrqSqZ1sBD9nb4ypR6DjhCnfS7LnYREtbvsx2stCdIotVlpk8CS 8iE1+cwGiegfrHLSr+KE0ptFDRT0RFfW6AdptbilnYj0S0+7YRZYE5lQAs73P9SsdD tVkigm3lhQWggPO5M8mJZJITf0DM/6CBoTuKPEnEF++Wiv8OP0wzL7tAkczAVwDKGQ wRtRo0cas7/S8BN1PY3xVM62n3VZ+ZczXp2QJ1aw20nKW8kAKgHH8KZLGilQEhh7qv +p6O7ylpnivCA== Received: by pali.im (Postfix) id 18212A52; Mon, 10 Jan 2022 10:17:30 +0100 (CET) Date: Mon, 10 Jan 2022 10:17:29 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: Thomas Petazzoni , Bjorn Helgaas , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Russell King , Antoine Tenart , Gregory Clement , Maxime Chevallier , Nadav Haklai , Victor Gu , =?utf-8?Q?Miqu=C3=A8l?= Raynal , Zachary Zhang , Wilson Ding , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] PCI: aardvark: Implement emulated root PCI bridge Message-ID: <20220110091729.owxno5ck3bihlrzj@pali> References: <20220107212736.GA404447@bhelgaas> <20220107231734.GA426583@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220107231734.GA426583@bhelgaas> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Friday 07 January 2022 17:17:34 Bjorn Helgaas wrote: > [+cc Pali; sorry, I meant to cc you on this but forgot] > > On Fri, Jan 07, 2022 at 03:27:38PM -0600, Bjorn Helgaas wrote: > > On Fri, Jun 29, 2018 at 11:22:31AM +0200, Thomas Petazzoni wrote: > > > > > +static void advk_sw_pci_bridge_init(struct advk_pcie *pcie) > > > +{ > > > + struct pci_sw_bridge *bridge = &pcie->bridge; > > > > > + /* Support interrupt A for MSI feature */ > > > + bridge->conf.intpin = PCIE_CORE_INT_A_ASSERT_ENABLE; > > > > Only 3.5 years later, IIUC, this is the value you get when you read > > PCI_INTERRUPT_PIN, so I think this should be PCI_INTERRUPT_INTA, not > > PCIE_CORE_INT_A_ASSERT_ENABLE. > > > > Readers expect to get the values defined in the PCI spec, i.e., > > > > PCI_INTERRUPT_UNKNOWN > > PCI_INTERRUPT_INTA > > PCI_INTERRUPT_INTB > > PCI_INTERRUPT_INTC > > PCI_INTERRUPT_INTD > > > > Bjorn Yes! We have a prepared patch for it and Marek now sent it: https://lore.kernel.org/linux-pci/20220110015018.26359-2-kabel@kernel.org/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CC33C433FE for ; Mon, 10 Jan 2022 09:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DKkCEVj5cFC/Tt2Bi1UHCifBAcjGMw53YE+eRRWHyBM=; b=bEw2hMpM0MRWfm MjaGz6fbV9hqTeRZC18PLKpywFOmdDKPbi9/sjsUGvTIQbr5ooZUYlzTcDn4yIzigXVoBCj6MZIbj tovq+9wOfqZ6L9Prs3OClmMkjrAjlYbIVmrTr/O0rDtZZ2wpawCmBAkA4WiaQ5a8rhU0aD77BZ2Bj 8QWLXntxjat6y4mS91kfZZ3LdmuqhXFbeqAkXdhhV0NRuKy+qLNHh8D5Wn0XYHh1TJikHo1kMbp04 waCX/GAcUtbq/bY/6mGMaPRCsdcfWjFCMhq7jzqyYlUCH7AYfYFur4sI4Uq+TePZaYOB1FLZgHjZu aIYyKi+1pubvXmKrnDAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6r4e-00ARBa-3V; Mon, 10 Jan 2022 09:34:44 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6qo3-00AGv4-Se for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 09:17:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DC110B81244; Mon, 10 Jan 2022 09:17:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85716C36AED; Mon, 10 Jan 2022 09:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641806252; bh=I6CA+wzhkholummADzrWOLHSeE/iqhS13t7Dpb5uFi8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ifTD9CZdUjAD/+ZOVp48sQrPq+x2B47ZgZtyjt5QT9/7YQrvvBnHqffzZ+saXWOtA EXK/j5mHFQRCj2LBrqSqZ1sBD9nb4ypR6DjhCnfS7LnYREtbvsx2stCdIotVlpk8CS 8iE1+cwGiegfrHLSr+KE0ptFDRT0RFfW6AdptbilnYj0S0+7YRZYE5lQAs73P9SsdD tVkigm3lhQWggPO5M8mJZJITf0DM/6CBoTuKPEnEF++Wiv8OP0wzL7tAkczAVwDKGQ wRtRo0cas7/S8BN1PY3xVM62n3VZ+ZczXp2QJ1aw20nKW8kAKgHH8KZLGilQEhh7qv +p6O7ylpnivCA== Received: by pali.im (Postfix) id 18212A52; Mon, 10 Jan 2022 10:17:30 +0100 (CET) Date: Mon, 10 Jan 2022 10:17:29 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: Thomas Petazzoni , Bjorn Helgaas , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Russell King , Antoine Tenart , Gregory Clement , Maxime Chevallier , Nadav Haklai , Victor Gu , =?utf-8?Q?Miqu=C3=A8l?= Raynal , Zachary Zhang , Wilson Ding , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] PCI: aardvark: Implement emulated root PCI bridge Message-ID: <20220110091729.owxno5ck3bihlrzj@pali> References: <20220107212736.GA404447@bhelgaas> <20220107231734.GA426583@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220107231734.GA426583@bhelgaas> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_011736_120585_2E71230C X-CRM114-Status: GOOD ( 17.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday 07 January 2022 17:17:34 Bjorn Helgaas wrote: > [+cc Pali; sorry, I meant to cc you on this but forgot] > > On Fri, Jan 07, 2022 at 03:27:38PM -0600, Bjorn Helgaas wrote: > > On Fri, Jun 29, 2018 at 11:22:31AM +0200, Thomas Petazzoni wrote: > > > > > +static void advk_sw_pci_bridge_init(struct advk_pcie *pcie) > > > +{ > > > + struct pci_sw_bridge *bridge = &pcie->bridge; > > > > > + /* Support interrupt A for MSI feature */ > > > + bridge->conf.intpin = PCIE_CORE_INT_A_ASSERT_ENABLE; > > > > Only 3.5 years later, IIUC, this is the value you get when you read > > PCI_INTERRUPT_PIN, so I think this should be PCI_INTERRUPT_INTA, not > > PCIE_CORE_INT_A_ASSERT_ENABLE. > > > > Readers expect to get the values defined in the PCI spec, i.e., > > > > PCI_INTERRUPT_UNKNOWN > > PCI_INTERRUPT_INTA > > PCI_INTERRUPT_INTB > > PCI_INTERRUPT_INTC > > PCI_INTERRUPT_INTD > > > > Bjorn Yes! We have a prepared patch for it and Marek now sent it: https://lore.kernel.org/linux-pci/20220110015018.26359-2-kabel@kernel.org/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel