All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Eduardo Habkost <eduardo@habkost.net>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	Daniel Berrange <berrange@redhat.com>,
	Beraldo Leal <bleal@redhat.com>,
	qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	Wainer Moschetta <wainersm@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>, Cleber Rosa <crosa@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: [PATCH v3 13/31] python/qmp: switch qom tools to AQMP
Date: Mon, 10 Jan 2022 18:28:52 -0500	[thread overview]
Message-ID: <20220110232910.1923864-14-jsnow@redhat.com> (raw)
In-Reply-To: <20220110232910.1923864-1-jsnow@redhat.com>

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Beraldo Leal <bleal@redhat.com>
---
 python/qemu/qmp/qom.py        |  5 +++--
 python/qemu/qmp/qom_common.py |  3 ++-
 python/qemu/qmp/qom_fuse.py   | 11 ++++++-----
 3 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/python/qemu/qmp/qom.py b/python/qemu/qmp/qom.py
index 8ff28a8343..bb5d1a78f5 100644
--- a/python/qemu/qmp/qom.py
+++ b/python/qemu/qmp/qom.py
@@ -32,7 +32,8 @@
 
 import argparse
 
-from . import QMPResponseError
+from qemu.aqmp import ExecuteError
+
 from .qom_common import QOMCommand
 
 
@@ -233,7 +234,7 @@ def _list_node(self, path: str) -> None:
                 rsp = self.qmp.command('qom-get', path=path,
                                        property=item.name)
                 print(f"  {item.name}: {rsp} ({item.type})")
-            except QMPResponseError as err:
+            except ExecuteError as err:
                 print(f"  {item.name}: <EXCEPTION: {err!s}> ({item.type})")
         print('')
         for item in items:
diff --git a/python/qemu/qmp/qom_common.py b/python/qemu/qmp/qom_common.py
index 2e4c741f77..e034a6f247 100644
--- a/python/qemu/qmp/qom_common.py
+++ b/python/qemu/qmp/qom_common.py
@@ -27,7 +27,8 @@
     TypeVar,
 )
 
-from . import QEMUMonitorProtocol, QMPError
+from qemu.aqmp import QMPError
+from qemu.aqmp.legacy import QEMUMonitorProtocol
 
 
 class ObjectPropertyInfo:
diff --git a/python/qemu/qmp/qom_fuse.py b/python/qemu/qmp/qom_fuse.py
index 43f4671fdb..653a76b93b 100644
--- a/python/qemu/qmp/qom_fuse.py
+++ b/python/qemu/qmp/qom_fuse.py
@@ -48,7 +48,8 @@
 import fuse
 from fuse import FUSE, FuseOSError, Operations
 
-from . import QMPResponseError
+from qemu.aqmp import ExecuteError
+
 from .qom_common import QOMCommand
 
 
@@ -99,7 +100,7 @@ def is_object(self, path: str) -> bool:
         try:
             self.qom_list(path)
             return True
-        except QMPResponseError:
+        except ExecuteError:
             return False
 
     def is_property(self, path: str) -> bool:
@@ -112,7 +113,7 @@ def is_property(self, path: str) -> bool:
                 if item.name == prop:
                     return True
             return False
-        except QMPResponseError:
+        except ExecuteError:
             return False
 
     def is_link(self, path: str) -> bool:
@@ -125,7 +126,7 @@ def is_link(self, path: str) -> bool:
                 if item.name == prop and item.link:
                     return True
             return False
-        except QMPResponseError:
+        except ExecuteError:
             return False
 
     def read(self, path: str, size: int, offset: int, fh: IO[bytes]) -> bytes:
@@ -138,7 +139,7 @@ def read(self, path: str, size: int, offset: int, fh: IO[bytes]) -> bytes:
         try:
             data = str(self.qmp.command('qom-get', path=path, property=prop))
             data += '\n'  # make values shell friendly
-        except QMPResponseError as err:
+        except ExecuteError as err:
             raise FuseOSError(EPERM) from err
 
         if offset > len(data):
-- 
2.31.1



  parent reply	other threads:[~2022-01-10 23:46 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 23:28 [PATCH v3 00/31] Python: delete synchronous qemu.qmp package John Snow
2022-01-10 23:28 ` [PATCH v3 01/31] python/aqmp: use absolute import statement John Snow
2022-01-10 23:28 ` [PATCH v3 02/31] Python/aqmp: fix type definitions for mypy 0.920 John Snow
2022-01-10 23:28 ` [PATCH v3 03/31] python: update type hints for mypy 0.930 John Snow
2022-01-10 23:28 ` [PATCH v3 04/31] simplebench: Fix Python syntax error (reported by LGTM) John Snow
2022-01-10 23:28 ` [PATCH v3 05/31] python/aqmp: fix docstring typo John Snow
2022-01-12 13:26   ` Beraldo Leal
2022-01-10 23:28 ` [PATCH v3 06/31] python/aqmp: add __del__ method to legacy interface John Snow
2022-01-10 23:28 ` [PATCH v3 07/31] python/aqmp: handle asyncio.TimeoutError on execute() John Snow
2022-01-10 23:28 ` [PATCH v3 08/31] python/aqmp: copy type definitions from qmp John Snow
2022-01-12 13:32   ` Beraldo Leal
2022-01-10 23:28 ` [PATCH v3 09/31] python/aqmp: add SocketAddrT to package root John Snow
2022-01-10 23:28 ` [PATCH v3 10/31] python/aqmp: rename AQMPError to QMPError John Snow
2022-01-12 13:35   ` Beraldo Leal
2022-01-10 23:28 ` [PATCH v3 11/31] python/qemu-ga-client: don't use deprecated CLI syntax in usage comment John Snow
2022-01-10 23:28 ` [PATCH v3 12/31] python/qmp: switch qemu-ga-client to AQMP John Snow
2022-01-10 23:28 ` John Snow [this message]
2022-01-10 23:28 ` [PATCH v3 14/31] python/qmp: switch qmp-shell " John Snow
2022-01-12 13:52   ` Beraldo Leal
2022-01-12 17:35     ` John Snow
2022-01-10 23:28 ` [PATCH v3 15/31] python: move qmp utilities to python/qemu/utils John Snow
2022-01-12 13:55   ` Beraldo Leal
2022-01-10 23:28 ` [PATCH v3 16/31] python: move qmp-shell under the AQMP package John Snow
2022-01-12 13:46   ` Beraldo Leal
2022-01-10 23:28 ` [PATCH v3 17/31] python/machine: permanently switch to AQMP John Snow
2022-01-10 23:28 ` [PATCH v3 18/31] scripts/cpu-x86-uarch-abi: fix CLI parsing John Snow
2022-01-10 23:28 ` [PATCH v3 19/31] scripts/cpu-x86-uarch-abi: switch to AQMP John Snow
2022-01-10 23:28 ` [PATCH v3 20/31] scripts/render-block-graph: " John Snow
2022-01-10 23:29 ` [PATCH v3 21/31] scripts/bench-block-job: " John Snow
2022-01-10 23:29 ` [PATCH v3 22/31] iotests/mirror-top-perms: " John Snow
2022-01-10 23:29 ` [PATCH v3 23/31] iotests: " John Snow
2022-01-14 19:12   ` Eric Blake
2022-01-17 19:32     ` John Snow
2022-01-10 23:29 ` [PATCH v3 24/31] python: temporarily silence pylint duplicate-code warnings John Snow
2022-01-10 23:29 ` [PATCH v3 25/31] python/aqmp: take QMPBadPortError and parse_address from qemu.qmp John Snow
2022-01-10 23:29 ` [PATCH v3 26/31] python/aqmp: fully separate from qmp.QEMUMonitorProtocol John Snow
2022-01-10 23:29 ` [PATCH v3 27/31] python/aqmp: copy qmp docstrings to qemu.aqmp.legacy John Snow
2022-01-10 23:29 ` [PATCH v3 28/31] python: remove the old QMP package John Snow
2022-01-10 23:29 ` [PATCH v3 29/31] python: re-enable pylint duplicate-code warnings John Snow
2022-01-10 23:29 ` [PATCH v3 30/31] python: rename qemu.aqmp to qemu.qmp John Snow
2022-01-12 14:21   ` Beraldo Leal
2022-01-10 23:29 ` [PATCH v3 31/31] python: rename 'aqmp-tui' to 'qmp-tui' John Snow
2022-01-12 14:00   ` Beraldo Leal
2022-01-10 23:33 ` [PATCH v3 00/31] Python: delete synchronous qemu.qmp package John Snow
2022-01-12 19:51   ` John Snow
2022-01-21  0:17 ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220110232910.1923864-14-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=hreitz@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.