All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Gao <chao.gao@intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, kevin.tian@intel.com,
	tglx@linutronix.de, Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] KVM: x86: Use kvm_x86_ops in kvm_arch_check_processor_compat
Date: Tue, 11 Jan 2022 11:06:28 +0800	[thread overview]
Message-ID: <20220111030626.GA2175@gao-cwp> (raw)
In-Reply-To: <YdygsjmoqmfwOVgv@google.com>

On Mon, Jan 10, 2022 at 09:10:10PM +0000, Sean Christopherson wrote:
>On Mon, Dec 27, 2021, Chao Gao wrote:
>> check_processor_compatibility() is a "runtime" ops now. Use
>> kvm_x86_ops directly such that kvm_arch_check_processor_compat
>> can be called at runtime.
>> 
>> Signed-off-by: Chao Gao <chao.gao@intel.com>
>> ---
>>  arch/x86/kvm/x86.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index 6411417b6871..770b68e72391 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -11383,7 +11383,6 @@ void kvm_arch_hardware_unsetup(void)
>>  int kvm_arch_check_processor_compat(void *opaque)
>>  {
>>  	struct cpuinfo_x86 *c = &cpu_data(smp_processor_id());
>> -	struct kvm_x86_init_ops *ops = opaque;
>>  
>>  	WARN_ON(!irqs_disabled());
>>  
>> @@ -11391,7 +11390,7 @@ int kvm_arch_check_processor_compat(void *opaque)
>>  	    __cr4_reserved_bits(cpu_has, &boot_cpu_data))
>>  		return -EIO;
>>  
>> -	return ops->runtime_ops->check_processor_compatibility();
>> +	return kvm_x86_ops.check_processor_compatibility();
>
>I'd just squash this with patch 01.  And might as well make this a static_call().

Will do

  reply	other threads:[~2022-01-11  2:55 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-27  8:15 [PATCH 0/6] Improve KVM's interaction with CPU hotplug Chao Gao
2021-12-27  8:15 ` Chao Gao
2021-12-27  8:15 ` Chao Gao
2021-12-27  8:15 ` Chao Gao
2021-12-27  8:15 ` [PATCH 1/6] KVM: x86: Move check_processor_compatibility from init ops to runtime ops Chao Gao
2022-01-10 23:27   ` Sean Christopherson
2022-01-11  3:36     ` Chao Gao
2022-01-12 17:59       ` Sean Christopherson
2021-12-27  8:15 ` [PATCH 2/6] KVM: x86: Use kvm_x86_ops in kvm_arch_check_processor_compat Chao Gao
2022-01-10 21:10   ` Sean Christopherson
2022-01-11  3:06     ` Chao Gao [this message]
2021-12-27  8:15 ` [PATCH 3/6] KVM: Remove opaque from kvm_arch_check_processor_compat Chao Gao
2021-12-27  8:15   ` Chao Gao
2021-12-27  8:15   ` Chao Gao
2021-12-27  8:15   ` Chao Gao
2022-01-10 23:06   ` Sean Christopherson
2022-01-10 23:06     ` Sean Christopherson
2022-01-10 23:06     ` Sean Christopherson
2022-01-10 23:06     ` Sean Christopherson
2022-01-11  3:19     ` Chao Gao
2022-01-11  3:19       ` Chao Gao
2022-01-11  3:19       ` Chao Gao
2022-01-11  3:19       ` Chao Gao
2022-01-12 17:20       ` Sean Christopherson
2022-01-12 17:20         ` Sean Christopherson
2022-01-12 17:20         ` Sean Christopherson
2022-01-12 17:20         ` Sean Christopherson
2022-01-12 17:21         ` Sean Christopherson
2022-01-12 17:21           ` Sean Christopherson
2022-01-12 17:21           ` Sean Christopherson
2022-01-12 17:21           ` Sean Christopherson
2021-12-27  8:15 ` [PATCH 4/6] KVM: Rename and move CPUHP_AP_KVM_STARTING to ONLINE section Chao Gao
2021-12-27  8:15 ` [PATCH 5/6] KVM: x86: Remove WARN_ON in kvm_arch_check_processor_compat Chao Gao
2022-01-10 22:59   ` Sean Christopherson
2022-01-11  2:15     ` Tian, Kevin
2022-01-11 19:48       ` Sean Christopherson
2022-01-12 11:00         ` Chao Gao
2022-01-12 17:35           ` Sean Christopherson
2022-01-17 13:35             ` Chao Gao
2022-01-17 13:46               ` Chao Gao
2022-01-19  0:34                 ` Sean Christopherson
2021-12-27  8:15 ` [PATCH 6/6] KVM: Do compatibility checks on hotplugged CPUs Chao Gao
2022-01-11  0:46   ` Sean Christopherson
2022-01-11  5:32     ` Chao Gao
2022-01-12 17:52       ` Sean Christopherson
2022-01-12 23:01         ` Jim Mattson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220111030626.GA2175@gao-cwp \
    --to=chao.gao@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.