On Mon, Jan 10, 2022 at 02:12:58PM -0800, Christy Lee wrote:
> On Mon, Jan 10, 2022 at 1:52 PM Song Liu <song@kernel.org> wrote:
> >
> > On Fri, Jan 7, 2022 at 4:59 PM Christy Lee <christylee@fb.com> wrote:
> > >
> > > env->scratched_stack_slots is a 64-bit value, we should use ULL
> > > instead of UL literal values.
> > >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > Signed-off-by: Christy Lee <christylee@fb.com>
> >
> > The fix looks good to me. Thus:
> >
> > Acked-by: Song Liu <songliubraving@fb.com>
> >
> > However, the patch looks corrupted. Also, the subject is probably too
> > long (./scripts/checkpatch.pl should complain about it).
> >
> 
> I just checked that even with an absurdly long subject (more than 200
> characters), ./scripts/checkpatch.pl doesn't complain. It only complains
> when the commit message body has longer than 75 characters but not the
> subject line.  What's the maximum subject line length?
> 

People say 50 characters but that just seems more aspirational than
realistic.  This patch needs a subsystem prefix as well.

regards,
dan carpenter