All of lore.kernel.org
 help / color / mirror / Atom feed
From: hmz007 <hmz007@gmail.com>
To: peng.fan@nxp.com, jh80.chung@samsung.com, ley.foon.tan@intel.com,
	u-boot@lists.denx.de
Cc: hmz007 <hmz007@gmail.com>
Subject: [PATCH] mmc: dw_mmc: Fixes timeout issue for FIFO mode
Date: Tue, 11 Jan 2022 18:24:11 +0800	[thread overview]
Message-ID: <20220111102411.16666-1-hmz007@gmail.com> (raw)

Clearing the DTO interrupt should be unnecessary, and it would
potentially result in never receiving this interrupt again.

Do power-on or reset from uboot for a while can reproduce the issue:
  dwmci_data_transfer: Timeout waiting for data!
  mmc_load_image_raw_sector: mmc block read error

Tested on NanoPi R4S with SanDisk Extreme PRO 32GB.

Fixes: 8cb9d3ed3a ("mmc: dw_mmc: Fixes data read when receiving DTO interrupt in FIFO mode")
Signed-off-by: hmz007 <hmz007@gmail.com>
---
 drivers/mmc/dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
index a949dad574..8fa26b340b 100644
--- a/drivers/mmc/dw_mmc.c
+++ b/drivers/mmc/dw_mmc.c
@@ -168,7 +168,7 @@ static int dwmci_data_transfer(struct dwmci_host *host, struct mmc_data *data)
 			if (data->flags == MMC_DATA_READ &&
 			    (mask & (DWMCI_INTMSK_RXDR | DWMCI_INTMSK_DTO))) {
 				dwmci_writel(host, DWMCI_RINTSTS,
-					     DWMCI_INTMSK_RXDR | DWMCI_INTMSK_DTO);
+					     DWMCI_INTMSK_RXDR);
 				while (size) {
 					ret = dwmci_fifo_ready(host,
 							DWMCI_FIFO_EMPTY,
-- 
2.34.1


             reply	other threads:[~2022-01-11 13:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220111102419epcas1p17569dac08e8ccb4e3a07e74e70d83023@epcas1p1.samsung.com>
2022-01-11 10:24 ` hmz007 [this message]
2022-01-11 10:39   ` [PATCH] mmc: dw_mmc: Fixes timeout issue for FIFO mode Jaehoon Chung
2022-01-11 11:05     ` gtXfined H.
2022-01-11 23:04       ` Jaehoon Chung
     [not found]         ` <CAGr7CZnkeQtxbJ+7d+RMBtB4N3cWUD5Ws8ikXykFiTxA58-rzw@mail.gmail.com>
2022-01-12 11:15           ` Jaehoon Chung
2022-01-12 12:55             ` gtXfined H.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220111102411.16666-1-hmz007@gmail.com \
    --to=hmz007@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=ley.foon.tan@intel.com \
    --cc=peng.fan@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.