From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77B1BC433EF for ; Tue, 11 Jan 2022 13:16:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240347AbiAKNQI (ORCPT ); Tue, 11 Jan 2022 08:16:08 -0500 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]:35405 "EHLO wnew1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231301AbiAKNQF (ORCPT ); Tue, 11 Jan 2022 08:16:05 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id BF2342B000AA; Tue, 11 Jan 2022 08:16:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 11 Jan 2022 08:16:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=yXTF+1sEdjFyfoYhAlSGINwu0y1 8yyw0z2aXapj6u4s=; b=em2fys3m84jBAFDKBEC2AtPfRilTDRqkdzw8ozzA6l6 30K4NDfPlt1b8QYIJMPqk7fIWDEziCILf40sm/KhSZspwryVD4twAz5xNT98hWbu QiWMjFg1ReB+ejs5OYkDtWff3+s23Ky5H9DyXGJMANhEQGfPzGaktvEmCfOG+KaE 6rB6nVIMEVGnL8pywaZl0GjF/+y1B0Gv7I739IjwcgsMLPo/dd3yecNIoqBM3S92 6+b1f0swMcOXFtZPoPn/lWrDEUK+Q3PP96/JL2UWupTV/ULVMHDAWpSvTzt4unT/ X0yfFyBA27LEykZEMDpQLSmrTseAZSZjVw+wm/W4V1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=yXTF+1 sEdjFyfoYhAlSGINwu0y18yyw0z2aXapj6u4s=; b=C+zr0Y0956COKArNfHRi56 IDtjkytBsqm5Coct7+bYOVMexGoB29J/yOeQyHxFVtSN3NWHM2eQVtKi9AuM0OXE svEwkJKmG33o8eYktYg2kBQl2WOzCV6jAjdYhuHS7uq1eAY/09g1NopLe+VO5hrj 1hIod3wivTRUUSbEgvoSrao56fp9YYlL7NjYfSVEtGSJm8HOeKfR59VKMSeBZfRA dtAsksVWzZofW2v3BNP4kS2wVu9RegXT5oHv6JByPakrtV9tWejYN/F8yzGlZMVR o0OEkUyPeM+QTHILkQhSZFHolVy3ZzB2W+FgRrtfco3FV2enF7/w0WNc9Jxla7vg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudehfedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Jan 2022 08:16:02 -0500 (EST) Date: Tue, 11 Jan 2022 14:16:01 +0100 From: Maxime Ripard To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Daniel Vetter , dri-devel@lists.freedesktop.org, Kris Karas , Geert Uytterhoeven , Peter Robinson , Thomas Zimmermann , Greg Kroah-Hartman , Borislav Petkov Subject: Re: [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver Message-ID: <20220111131601.u36j6grsvnir5gvp@houat> References: <20220110095625.278836-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5rhk7fpudnheurb4" Content-Disposition: inline In-Reply-To: <20220110095625.278836-1-javierm@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5rhk7fpudnheurb4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Jan 10, 2022 at 10:56:23AM +0100, Javier Martinez Canillas wrote: > This patch series contains two fixes for the vga16fb driver. I looked at > the driver due a regression reported [0], caused by commit d391c5827107 > ("drivers/firmware: move x86 Generic System Framebuffers support"). >=20 > The mentioned commit didn't change any logic but just moved the platform > device registration that matches the vesafb and efifb drivers to happen > later. And this caused the vga16fb driver to be probed even in machines > that don't have an EGA or VGA video adapter. >=20 > This is a v2 of the patch series that addresses issues pointed out by > Geert Uytterhoeven. >=20 > Patch #1 is fixing the wrong check to determine if either EGA or VGA is > used and patch #2 adds a check to the driver to only be loaded for EGA > and VGA 16 color graphic cards. For both patches, Acked-by: Maxime Ripard Maxime --5rhk7fpudnheurb4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYd2DEQAKCRDj7w1vZxhR xbXXAP4gpuUuyyTwx3PEj37oaIJQF37qaFBZHNDqYNK9DJonuQD+LsvkihtOL+7n xXiJmQtTvSoH/8OE236YGI56zT1kvAQ= =fqNz -----END PGP SIGNATURE----- --5rhk7fpudnheurb4-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A47E5C433F5 for ; Tue, 11 Jan 2022 13:16:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D5B9510FAF6; Tue, 11 Jan 2022 13:16:06 +0000 (UTC) Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F1F310FAF6 for ; Tue, 11 Jan 2022 13:16:05 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id BF2342B000AA; Tue, 11 Jan 2022 08:16:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 11 Jan 2022 08:16:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=yXTF+1sEdjFyfoYhAlSGINwu0y1 8yyw0z2aXapj6u4s=; b=em2fys3m84jBAFDKBEC2AtPfRilTDRqkdzw8ozzA6l6 30K4NDfPlt1b8QYIJMPqk7fIWDEziCILf40sm/KhSZspwryVD4twAz5xNT98hWbu QiWMjFg1ReB+ejs5OYkDtWff3+s23Ky5H9DyXGJMANhEQGfPzGaktvEmCfOG+KaE 6rB6nVIMEVGnL8pywaZl0GjF/+y1B0Gv7I739IjwcgsMLPo/dd3yecNIoqBM3S92 6+b1f0swMcOXFtZPoPn/lWrDEUK+Q3PP96/JL2UWupTV/ULVMHDAWpSvTzt4unT/ X0yfFyBA27LEykZEMDpQLSmrTseAZSZjVw+wm/W4V1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=yXTF+1 sEdjFyfoYhAlSGINwu0y18yyw0z2aXapj6u4s=; b=C+zr0Y0956COKArNfHRi56 IDtjkytBsqm5Coct7+bYOVMexGoB29J/yOeQyHxFVtSN3NWHM2eQVtKi9AuM0OXE svEwkJKmG33o8eYktYg2kBQl2WOzCV6jAjdYhuHS7uq1eAY/09g1NopLe+VO5hrj 1hIod3wivTRUUSbEgvoSrao56fp9YYlL7NjYfSVEtGSJm8HOeKfR59VKMSeBZfRA dtAsksVWzZofW2v3BNP4kS2wVu9RegXT5oHv6JByPakrtV9tWejYN/F8yzGlZMVR o0OEkUyPeM+QTHILkQhSZFHolVy3ZzB2W+FgRrtfco3FV2enF7/w0WNc9Jxla7vg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudehfedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Jan 2022 08:16:02 -0500 (EST) Date: Tue, 11 Jan 2022 14:16:01 +0100 From: Maxime Ripard To: Javier Martinez Canillas Subject: Re: [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver Message-ID: <20220111131601.u36j6grsvnir5gvp@houat> References: <20220110095625.278836-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5rhk7fpudnheurb4" Content-Disposition: inline In-Reply-To: <20220110095625.278836-1-javierm@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kris Karas , Geert Uytterhoeven , Peter Robinson , Thomas Zimmermann , Greg Kroah-Hartman , Borislav Petkov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --5rhk7fpudnheurb4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Jan 10, 2022 at 10:56:23AM +0100, Javier Martinez Canillas wrote: > This patch series contains two fixes for the vga16fb driver. I looked at > the driver due a regression reported [0], caused by commit d391c5827107 > ("drivers/firmware: move x86 Generic System Framebuffers support"). >=20 > The mentioned commit didn't change any logic but just moved the platform > device registration that matches the vesafb and efifb drivers to happen > later. And this caused the vga16fb driver to be probed even in machines > that don't have an EGA or VGA video adapter. >=20 > This is a v2 of the patch series that addresses issues pointed out by > Geert Uytterhoeven. >=20 > Patch #1 is fixing the wrong check to determine if either EGA or VGA is > used and patch #2 adds a check to the driver to only be loaded for EGA > and VGA 16 color graphic cards. For both patches, Acked-by: Maxime Ripard Maxime --5rhk7fpudnheurb4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYd2DEQAKCRDj7w1vZxhR xbXXAP4gpuUuyyTwx3PEj37oaIJQF37qaFBZHNDqYNK9DJonuQD+LsvkihtOL+7n xXiJmQtTvSoH/8OE236YGI56zT1kvAQ= =fqNz -----END PGP SIGNATURE----- --5rhk7fpudnheurb4--