Re: [PATCH] MIPS: ath79: drop _machine_restart again

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Mon, Jan 10, 2022 at 11:48:44PM +0100, Lech Perczak wrote:
> Commit 81424d0ad0d4 ("MIPS: ath79: Use the reset controller to restart
> OF machines") removed setup of _machine_restart on OF machines to use
> reset handler in reset controller driver.
> While removing remnants of non-OF machines in commit 3a77e0d75eed
> ("MIPS: ath79: drop machfiles"), this was introduced again, making it
> impossible to use additional restart handlers registered through device
> tree. Drop setting _machine_restart altogether, and ath79_restart
> function, which is no longer used after this.
> 
> Fixes: 3a77e0d75eed ("MIPS: ath79: drop machfiles")
> Cc: John Crispin <john@phrozen.org>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
> ---
> 
> Side note: a lot of code, that was previously encompassed by
> "if (mips_machtype != ATH79_MACH_GENERIC_OF) {...} " seems to be
> unnecessary at the time of dropping the non-OF machine definitions.
> However it was retained for some reason, and I see a lot of references
> to it by the drivers. OTOH, OF part of ath79 platform - basically whole ath79
> target of OpenWrt works well without this code in 19.07 release, using 4.14.y
> tree, on which the bug I'm fixing here is absent as well.
> 
> I tested this change on several devices:
> TP-Link TL-WDR4300, TP-Link Archer C7v2, Meraki MR18 using OF,
> and on ZTE MF286 - using OF as well - which is the very reason I discovered
> this issue, as it requires registration of  gpio-restart handler,
> ineffective due to this issue.
> 
>  arch/mips/ath79/setup.c | 10 ----------
>  1 file changed, 10 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]