From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A303BC433F5 for ; Tue, 11 Jan 2022 20:15:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243357AbiAKUP2 (ORCPT ); Tue, 11 Jan 2022 15:15:28 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:37756 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242528AbiAKUPY (ORCPT ); Tue, 11 Jan 2022 15:15:24 -0500 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id EA47F40019 for ; Tue, 11 Jan 2022 20:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641932123; bh=yMRg5bpikDO180MsuJoGQbsc7amvRmcUNEN2QLw9x1s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BlVjFCFEDEqxUu4C8Rj3D0gmwrrmo2eO80CEE2ggoiXOMSSNPnbvHkAwOoMatLW7Z V/h30LRjs6P4QRgyAd2uT7WGlccQM3uH8ElWnKp+P/kv9b5OA418QCAJNSOl9jAcgO 9mnY1cGInaXgdcIk1kyeiDNRQN46LwrwPV4m3irrUOIeYO/GTUIGmNlOFMw7jGPmXH HRvTH6zb7htgwVEMYFuRRmlfjFxwtkXrZUicvdxb7JrIPPOZOZ6QgDu058TgDJ/X2c hdIjmW7ZN30e9IWyEzArqfHnTMMKXELEqxYiNr13Nd7hOO2TYj2bcvZ74Pv6Xqyzq5 rPpH9RVyyAVPQ== Received: by mail-ed1-f71.google.com with SMTP id v18-20020a056402349200b003f8d3b7ee8dso139816edc.23 for ; Tue, 11 Jan 2022 12:15:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yMRg5bpikDO180MsuJoGQbsc7amvRmcUNEN2QLw9x1s=; b=ZSVRS91v64ArCLTBIh4GTMCPNPCacXfiSF5e2tPf6UEdLqKpvmT0Y6fBFduHzJKoZa UqK+wb1KJKqO3CZ4HX2CaWAiGcd6eCr8yAs5XD96raUFce/dp1IotgbNRpDPIslkZGMB /SBenXCmZv91cLlD3Is6380cDDBRGQ6Q3ViLgDVl5NOzjj6pAoH8zBocpbYNnEfZ1bUe cTUy+AJqBhoZ/HqfyKO8RbvJtfz43Vaas6RMFth4uKuTTpSJp5+2GZWEIsMj5+Bp2hzH E8lb7xiyaNiIa90fvVxpXTCioZH3UD7OTL2oSAZ+8D6S3+GZDM3cILUMkc6YDkvPL94d DJqg== X-Gm-Message-State: AOAM532GCn9DYuDS5lPanGdXpL62961E7uwtm8BIk+SFl562sghZFIKQ lCsd8BwOhh+AYhxn0NwZXJs7WbaPMchVvtvoPPlQyOMt335OuG5wlW6BVufMBGuoY6ZyOqf+i6J 59W1FZ7AvL5qRhucSYojgxCi51GpkJ1XtajgqL3s= X-Received: by 2002:a17:906:e92:: with SMTP id p18mr4852333ejf.616.1641932122794; Tue, 11 Jan 2022 12:15:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxy0jhY+ruxR5/A+E+ypB8QX7lhJyLehZkmqyLuFS2EyP4zC5Ct+Xt3e8pj1XNa67xaH8Jh9A== X-Received: by 2002:a17:906:e92:: with SMTP id p18mr4852317ejf.616.1641932122648; Tue, 11 Jan 2022 12:15:22 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id f23sm3852212ejj.128.2022.01.11.12.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 12:15:22 -0800 (PST) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Sam Protsenko , Chanho Park , Alim Akhtar , Alim Akhtar Subject: [PATCH v2 05/28] ARM: dts: exynos: override pins by label in Peach Pit Date: Tue, 11 Jan 2022 21:14:03 +0100 Message-Id: <20220111201426.326777-6-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220111201426.326777-1-krzysztof.kozlowski@canonical.com> References: <20220111201426.326777-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Using node paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped label on the other hand, will cause a dtc compile error (during build time). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 44 +++++++++++----------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index e76fb104db19..1ae5528e9ebf 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -868,27 +868,26 @@ pmic_dvs_1: pmic-dvs-1 { }; }; -&pinctrl_1 { - /* Adjust WiFi drive strengths lower for EMI */ - sd1_clk: sd1-clk { - samsung,pin-drv = ; - }; +/* pinctrl_1 */ +/* Adjust WiFi drive strengths lower for EMI */ +&sd1_bus1 { + samsung,pin-drv = ; +}; - sd1_cmd: sd1-cmd { - samsung,pin-drv = ; - }; +&sd1_bus4 { + samsung,pin-drv = ; +}; - sd1_bus1: sd1-bus-width1 { - samsung,pin-drv = ; - }; +&sd1_bus8 { + samsung,pin-drv = ; +}; - sd1_bus4: sd1-bus-width4 { - samsung,pin-drv = ; - }; +&sd1_clk { + samsung,pin-drv = ; +}; - sd1_bus8: sd1-bus-width8 { - samsung,pin-drv = ; - }; +&sd1_cmd { + samsung,pin-drv = ; }; &pinctrl_2 { @@ -907,12 +906,13 @@ pmic_dvs_3: pmic-dvs-3 { }; }; -&pinctrl_3 { - /* Drive SPI lines at x2 for better integrity */ - spi2-bus { - samsung,pin-drv = ; - }; +/* pinctrl_3*/ +/* Drive SPI lines at x2 for better integrity */ +&spi2_bus { + samsung,pin-drv = ; +}; +&pinctrl_3 { /* Drive SPI chip select at x2 for better integrity */ ec_spi_cs: ec-spi-cs { samsung,pins = "gpb1-2"; -- 2.32.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 172A1C4167D for ; Tue, 11 Jan 2022 20:18:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EElnAjsrLYuzj+guaynjKFGv66GhmSKnmXsrpNv+CUc=; b=pf1EEhey7yVhsD pudJdO05Hyozy0lmQ/75yU8jjMgIY0deO032iFg3fsD5FrjeCPdayXcI9abBtNmK/NFHw39V++hog 1fZXVvHuQH7sFCDzJZh38PanNuqTOAA0vlMMpFlhUOvvBzGBWKwSDRxuknwAghxqcACDsw7PmgLOG gOR+h1dKqxG3Ek6zUSKVYHFfJOunoJ+kBIolakltfvDjTqXYXEGT3MzC+3vryuCVAAxvvM+2hiHFC Dn6b0oRPk6xSb+wX1N/l7CZYhGm50t+L8GNuclKPMrLDXnCwOFDacNrVvnnHOtITC0ey9u2fF7uTK 8yNI7ZRX7GxMgT/6Df1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7NZa-00HWUd-HV; Tue, 11 Jan 2022 20:16:50 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7NYF-00HVuB-7l for linux-arm-kernel@lists.infradead.org; Tue, 11 Jan 2022 20:15:30 +0000 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id BEB7A40ADE for ; Tue, 11 Jan 2022 20:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641932124; bh=yMRg5bpikDO180MsuJoGQbsc7amvRmcUNEN2QLw9x1s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=orysjNuryqaE58kl78dbOTnbZREdy4Nzn8HqMfXDqpmgeiBJTIznK+Ko1+RdM4cvF 12UpINmJ7z/S49LIYYs/u+WEpDDGxe/TzHpvlr7/UC1MBbjC49rb8dK1EiC+Kgtcsc hUjvJe71yK+wBxzTAE7IP5vK0w1HOBC49jxAAMYTRlNfQVuuLUlEgsQ0LB41iChegV PSSRVciUngfL6XD1gG+PuDZC1JWbvDdHMVv6KI/4zd7pyAkYo1+NBDbDpLEFjY4plK L+fuIfjwGKsza17qrYc7I5LiR6ebrWC7pXsO6xk6uiDrqLyyhggANMTbJWbEDaelWI sZdUU6PH6rSAw== Received: by mail-ed1-f71.google.com with SMTP id g11-20020a056402090b00b003f8fd1ac475so215174edz.1 for ; Tue, 11 Jan 2022 12:15:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yMRg5bpikDO180MsuJoGQbsc7amvRmcUNEN2QLw9x1s=; b=X9x1tTJEz2N3ywhMpvo5r5i9R/XcPTX1LG3PyTlESe8IluB7/TaXb02CnacbYgkAUl C4eK66HNtrsqtH9Lhiy0lxGjatBnCzY+gScuCphFC7bpYxDbRKoeZ4AW0t/2jeLnPo80 FWPhkmvRyc3MvYo2emQaZsGieTK+AHQABNGcnPvsBUAwXqFygSGL87zgBSj3TRqabDZt W+Gd+8rIyBg08xp+ZQKiEbuNKDkvjaswME202zWnrb2+SfstoksTkTrowBFjJZF2dyYV fRef//DHv9vGdxJZX9izaYN7KWYIS+SfVBWlsxhFpKpmdfPCrSaQuuhG0bn4vaAOqqJJ 7M7A== X-Gm-Message-State: AOAM530+Sciae4EarpaJqDSbYB01Y2/fcSHfhZk/voK2ri0KVYn5RB/i bz07ubk5+VLR6NoTprkRkXB5/hG0SvFSOrNzlse17Ac1o2UsXjHqzJWBUTMRjhMLAduwNm7LRWz hSDWtkVg8UygQzFp6CJSkuh9uRzZYHJP80vPlhp61VD7glw+b5/Qi X-Received: by 2002:a17:906:e92:: with SMTP id p18mr4852336ejf.616.1641932122801; Tue, 11 Jan 2022 12:15:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxy0jhY+ruxR5/A+E+ypB8QX7lhJyLehZkmqyLuFS2EyP4zC5Ct+Xt3e8pj1XNa67xaH8Jh9A== X-Received: by 2002:a17:906:e92:: with SMTP id p18mr4852317ejf.616.1641932122648; Tue, 11 Jan 2022 12:15:22 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id f23sm3852212ejj.128.2022.01.11.12.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 12:15:22 -0800 (PST) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Sam Protsenko , Chanho Park , Alim Akhtar , Alim Akhtar Subject: [PATCH v2 05/28] ARM: dts: exynos: override pins by label in Peach Pit Date: Tue, 11 Jan 2022 21:14:03 +0100 Message-Id: <20220111201426.326777-6-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220111201426.326777-1-krzysztof.kozlowski@canonical.com> References: <20220111201426.326777-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220111_121527_452890_21EE2E48 X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using node paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped label on the other hand, will cause a dtc compile error (during build time). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 44 +++++++++++----------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index e76fb104db19..1ae5528e9ebf 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -868,27 +868,26 @@ pmic_dvs_1: pmic-dvs-1 { }; }; -&pinctrl_1 { - /* Adjust WiFi drive strengths lower for EMI */ - sd1_clk: sd1-clk { - samsung,pin-drv = ; - }; +/* pinctrl_1 */ +/* Adjust WiFi drive strengths lower for EMI */ +&sd1_bus1 { + samsung,pin-drv = ; +}; - sd1_cmd: sd1-cmd { - samsung,pin-drv = ; - }; +&sd1_bus4 { + samsung,pin-drv = ; +}; - sd1_bus1: sd1-bus-width1 { - samsung,pin-drv = ; - }; +&sd1_bus8 { + samsung,pin-drv = ; +}; - sd1_bus4: sd1-bus-width4 { - samsung,pin-drv = ; - }; +&sd1_clk { + samsung,pin-drv = ; +}; - sd1_bus8: sd1-bus-width8 { - samsung,pin-drv = ; - }; +&sd1_cmd { + samsung,pin-drv = ; }; &pinctrl_2 { @@ -907,12 +906,13 @@ pmic_dvs_3: pmic-dvs-3 { }; }; -&pinctrl_3 { - /* Drive SPI lines at x2 for better integrity */ - spi2-bus { - samsung,pin-drv = ; - }; +/* pinctrl_3*/ +/* Drive SPI lines at x2 for better integrity */ +&spi2_bus { + samsung,pin-drv = ; +}; +&pinctrl_3 { /* Drive SPI chip select at x2 for better integrity */ ec_spi_cs: ec-spi-cs { samsung,pins = "gpb1-2"; -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel