From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDEEEC433EF for ; Wed, 12 Jan 2022 13:21:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353517AbiALNVK (ORCPT ); Wed, 12 Jan 2022 08:21:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:21738 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233171AbiALNVJ (ORCPT ); Wed, 12 Jan 2022 08:21:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641993668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z7HUhTMlbXY8IkiDpmh6rY91adlsE5cm+HaqeJ7xc6w=; b=h+u6L98uXyR8eIFtRb6X2wgqv6SWoACXBKtTg/oDt8f3wPUP2kRlCC6rm/aIuWJT/B7U4f UmUuro42SkoTOPitRTCcDfN2bzT4nXlnrUA51XB7luapxNdn1fXapUxQXPKoW2uXJjatKU 5Y4V0yJVTyPl9su4Od13BUL4kcCvuwA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-241-HxZHy4TmOTaqdiz2qyS-4w-1; Wed, 12 Jan 2022 08:21:07 -0500 X-MC-Unique: HxZHy4TmOTaqdiz2qyS-4w-1 Received: by mail-wm1-f72.google.com with SMTP id c188-20020a1c35c5000000b00346a2160ea8so499855wma.9 for ; Wed, 12 Jan 2022 05:21:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z7HUhTMlbXY8IkiDpmh6rY91adlsE5cm+HaqeJ7xc6w=; b=D8x78K2KQnjLWyky61SczSOG+bnTc+SQCzkJAAqn2E1jaqtOcNRwNdJdEd4t0yPOjh 2ip12g7xgz7nuFSIMXg0pmKLvvZ+TKPtqvYZrYi3n+EA2ehvaldTvitsq9A0gl4yom+p V/dnuEm6cPNMxkwz4QCo/WhhLiA8ZvU5VtL+E91vNEtylIY32Gr5D1YFhdDT3cfkettd aP9xU+mQIMXytKDuEB+4Zf58TvmnNFi9Vqu7jFpGvuCo4HAA28RPbnlUj7S+SkEPtDen /eKVJLypXkoqhG+AtRxB8FKYFjHH8zPuO5nKWgAitBWsRjFAPnntibxqHbldlLI/i4G+ ny1w== X-Gm-Message-State: AOAM530kgwfXR5apL/63y7vlfydNrszz9i9S5hKrQG57iKMbMpwZf4np T8DEZ5y8sZ3ikPYsFAtc9Q8eDF3pT24XqPEdluABU7oCArnxZA/TnGrIyNQghgPJW/vuuMam784 k3rJj2TLSnjLFZHZ91e9R2acD X-Received: by 2002:adf:8b50:: with SMTP id v16mr5647090wra.44.1641993666416; Wed, 12 Jan 2022 05:21:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwanSxI4qVidY2mX5BJOgQL83lB5Nh6uTW/AYob5zmC0ZddXVW3+Lc7mz+ajohYj/ntkM3eCg== X-Received: by 2002:adf:8b50:: with SMTP id v16mr5647071wra.44.1641993666212; Wed, 12 Jan 2022 05:21:06 -0800 (PST) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id o38sm5271904wms.11.2022.01.12.05.21.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 05:21:05 -0800 (PST) Date: Wed, 12 Jan 2022 13:21:04 +0000 From: Aaron Tomlin To: Allen Cc: Luis Chamberlain , Christoph Lameter , Petr Mladek , Miroslav Benes , Andrew Morton , jeyu@kernel.org, Linux Kernel Mailing List , linux-modules@vger.kernel.org, atomlin@atomlin.com, ghalat@redhat.com Subject: Re: [RFC PATCH v2 00/13] module: core code clean up Message-ID: <20220112132104.7emyelwuv3jmmhdt@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20220106234319.2067842-1-atomlin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: On Tue 2022-01-11 17:16 -0800, Allen wrote: > Hi Aaron, Hi Allen, > Was the code compile tested? Not entirely i.e. not the whole of kernel/module/Makefile, unfortunately. Furthermore, only x86-64 was compiled tested. At the moment, I felt the need to share the concept/or approach thus far to simply obtain some overall feedback before further modifications. > Unfortunately, I could not apply the series cleanly on top of the > latest 5.17-rc1. Sorry about that: this work was based on Linus' commit 81361b837a34 ("Merge tag 'kbuild-v5.14' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild."). > I did rebase the patches and fixed minor compile time failures as > well a few small checkpatch errors. > I have pushed the series to > https://github.com/allenpais/Linux/commits/refactor_module_v3 > [The series now is based on > 84bfcc0b6994 2022-01-11 Merge tag 'integrity-v5.17' of > git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity] Thanks for that. I'll have a look shortly to incorporate into RFC PATCH v3. > So far I could only manage to compile test the patches. Will test it > on BM(x86/arm) in a day or two. Much appreciated. Kind regards, -- Aaron Tomlin