Re: [PATCH 3/3] xfs: remove the XFS_IOC_FSSETDM definitions

[Dave Chinner <david@fromorbit.com>]

On Tue, Jan 11, 2022 at 03:22:57PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Remove the definitions for these ioctls, since the functionality (and,
> weirdly, the 32-bit compat ioctl definitions) were removed from the
> kernel in November 2019.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  fs/xfs/libxfs/xfs_fs.h |   29 ++++-------------------------
>  1 file changed, 4 insertions(+), 25 deletions(-)

Looks fine to me.

THe only user I know of is xfsdump, and it will only use this
functionality if a special CLI option is given to it. Given that
this would just be writing zeros as this is what will be in the
inodes that are backed up by xfsdump, I don't see it a big problem
if this fails now.

Nothing else out there is likely to be using this ioctl - the DMAPI
state was specific to a long dead proprietary SGI HSM product and
that's the only thing I know of that used this ioctl to set non-zero
values in the first place. 

Hence I think removing this ioctl has very little risk of userspace
regression.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com