From: Jakub Kicinski <kuba@kernel.org>
To: Kevin Bracey <kevin@bracey.fi>
Cc: Eric Dumazet <edumazet@google.com>,
netdev <netdev@vger.kernel.org>, Jiri Pirko <jiri@resnulli.us>,
Vimalkumar <j.vimal@gmail.com>,
maximmi@nvidia.com
Subject: Re: [PATCH net-next v2] net_sched: restore "mpu xxx" handling
Date: Thu, 13 Jan 2022 11:08:01 -0800 [thread overview]
Message-ID: <20220113110801.7c1a6347@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <00960549-3a4a-abe3-0a28-ab866a7dbe97@bracey.fi>
On Wed, 12 Jan 2022 19:31:54 +0200 Kevin Bracey wrote:
> On 12/01/2022 19:08, Eric Dumazet wrote:
> > On Wed, Jan 12, 2022 at 9:02 AM Kevin Bracey <kevin@bracey.fi> wrote:
> >> commit 56b765b79e9a ("htb: improved accuracy at high rates") broke
> >> "overhead X", "linklayer atm" and "mpu X" attributes.
Applied, thanks!
> > Thanks for the nice changelog.
> >
> > I do have a question related to HTB offload.
> >
> > Is this mpu attribute considered there ?
>
> I had not considered that. None of these 3 adjustment parameters are
> passed to its setup - tc_htb_qopt_offload merely contains u64 rate and ceil.
>
> Dealing with that looks like it might be a bit fiddly. htb_change_class
> would need reordering. It appears the software case permits parameter
> changing and it is ordered on that basis, but the offload locks in
> parameters on creation.
>
> But in principle, tc_htb_qopt_offload could contain a pair of
> psched_ratecfg rather than a pair of u64s, and then offload would have
> all the adjustment information.
CC Maxim, offload should at least be rejected if user request
unsupported params.
prev parent reply other threads:[~2022-01-13 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 17:02 [PATCH net-next v2] net_sched: restore "mpu xxx" handling Kevin Bracey
2022-01-12 17:08 ` Eric Dumazet
2022-01-12 17:31 ` Kevin Bracey
2022-01-13 19:08 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113110801.7c1a6347@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=edumazet@google.com \
--cc=j.vimal@gmail.com \
--cc=jiri@resnulli.us \
--cc=kevin@bracey.fi \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.