All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
	Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH 2/5] nvme-fabrics: remove unnecessary braces for case
Date: Thu, 13 Jan 2022 08:16:14 -0800	[thread overview]
Message-ID: <20220113161614.GC3230285@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <20220112062101.90102-3-chaitanyak@nvidia.com>

On Tue, Jan 11, 2022 at 10:20:58PM -0800, Chaitanya Kulkarni wrote:
> From: Chaitanya Kulkarni <kch@nvidia.com>
> 
> Braces are not required for enum value NVME_SC_CONNECT_INVALID_PARAM
> when used on the switch-case statement, remove the braces.
> 
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>

Looks good.

Reviewed-by: Keith Busch <kbusch@kernel.org>


  reply	other threads:[~2022-01-13 16:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12  6:20 [PATCH 0/5] nvme-fabrics: small cleanup Chaitanya Kulkarni
2022-01-12  6:20 ` [PATCH 1/5] nvme-fabrics: use consistent zeroout pattern Chaitanya Kulkarni
2022-01-13 16:15   ` Keith Busch
2022-01-12  6:20 ` [PATCH 2/5] nvme-fabrics: remove unnecessary braces for case Chaitanya Kulkarni
2022-01-13 16:16   ` Keith Busch [this message]
2022-01-12  6:20 ` [PATCH 3/5] nvme-fabrics: use unsigned int type Chaitanya Kulkarni
2022-01-12 11:41   ` Max Gurtovoy
2022-01-13 16:20   ` Keith Busch
2022-01-12  6:21 ` [PATCH 4/5] " Chaitanya Kulkarni
2022-01-12  6:21 ` [PATCH 5/5] nvme-fabrics: set ret to -ENODEV for error case Chaitanya Kulkarni
2022-01-13 16:28   ` Keith Busch
2022-01-17  8:50     ` Chaitanya Kulkarni
2022-01-19  6:26       ` Sagi Grimberg
2022-01-19  7:40         ` Chaitanya Kulkarni
2022-01-19 11:24           ` Sagi Grimberg
2022-01-26 16:32 ` [PATCH 0/5] nvme-fabrics: small cleanup Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220113161614.GC3230285@dhcp-10-100-145-180.wdc.com \
    --to=kbusch@kernel.org \
    --cc=chaitanyak@nvidia.com \
    --cc=hch@lst.de \
    --cc=kch@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.