All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "José Pekkarinen" <jose.pekkarinen@unikie.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] package/opensc: new package
Date: Thu, 13 Jan 2022 21:22:22 +0100	[thread overview]
Message-ID: <20220113212222.282b9a9c@windsurf> (raw)
In-Reply-To: <20220113205437.47e82728@windsurf>

Hello,

On Thu, 13 Jan 2022 20:54:37 +0100
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> > +	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM  
> 
> Unfortunately, this is not acceptable. If it breaks with this
> particular toolchain, it's also likely to break with other toolchains
> that share similar characteristics (gcc version, etc.).

Just pass --disable-strict in OPENSC_CONF_OPTS, and opensc will nicely
build with the Sourcery toolchain.

> > +	select BR2_PACKAGE_PCSC_LITE
> > +	select BR2_PACKAGE_OPENSSL
> > +	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL  
> 
> Why do you force OpenSSL here? Is LibreSSL confirmed to not work with
> opensc? If so, please add a comment above this select that explains
> what explain is broken.

I just tested the build with LibreSSL, and it works, so please drop
this BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-13 20:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 11:49 [Buildroot] [PATCH v3] package/opensc: new package José Pekkarinen
2022-01-13 19:54 ` Thomas Petazzoni
2022-01-13 20:22   ` Thomas Petazzoni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-11-25  7:27 José Pekkarinen
2021-11-25  7:29 ` José Pekkarinen
2021-11-25  7:22 José Pekkarinen
2021-11-30 13:16 ` José Pekkarinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220113212222.282b9a9c@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=jose.pekkarinen@unikie.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.